nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

kernel/fail_function: fix memory leak with using debugfs_lookup()

Browse source 
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time.  To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.

Cc: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20230202151633.2310897-1-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Greg Kroah-Hartman 2023-02-02 16:16:33 +01:00
parent a0bc3f78d0
commit 2bb3669f57
1 changed files with 1 additions and 4 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

5
kernel/fail_function.c
View file

@ -163,10 +163,7 @@ static void fei_debugfs_add_attr(struct fei_attr *attr)
static void fei_debugfs_remove_attr(struct fei_attr *attr) static void fei_debugfs_remove_attr(struct fei_attr *attr)
{ {
struct dentry *dir; debugfs_lookup_and_remove(attr->kp.symbol_name, fei_debugfs_dir);
dir = debugfs_lookup(attr->kp.symbol_name, fei_debugfs_dir);
debugfs_remove_recursive(dir);
} }
static int fei_kprobe_handler(struct kprobe *kp, struct pt_regs *regs) static int fei_kprobe_handler(struct kprobe *kp, struct pt_regs *regs)