nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

char_dev: pin parent kobject

Browse source 
In certain cases (for example when a cdev structure is embedded into
another object whose lifetime is controlled by a separate kobject) it is
beneficial to tie lifetime of another object to the lifetime of
character device so that related object is not freed until after
char_dev object is freed.

To achieve this let's pin kobject's parent when doing cdev_add() and
unpin when last reference to cdev structure is being released.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Acked-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Dmitry Torokhov 2012-10-21 17:57:19 -07:00 committed by Linus Torvalds
parent 6f0c0580b7
commit 2f0157f13f
1 changed files with 17 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

18
fs/char_dev.c
View file

@ -471,9 +471,19 @@ static int exact_lock(dev_t dev, void *data)
*/ */
int cdev_add(struct cdev *p, dev_t dev, unsigned count) int cdev_add(struct cdev *p, dev_t dev, unsigned count)
{ {
int error;
p->dev = dev; p->dev = dev;
p->count = count; p->count = count;
return kobj_map(cdev_map, dev, count, NULL, exact_match, exact_lock, p);
error = kobj_map(cdev_map, dev, count, NULL,
exact_match, exact_lock, p);
if (error)
return error;
kobject_get(p->kobj.parent);
return 0;
} }
static void cdev_unmap(dev_t dev, unsigned count) static void cdev_unmap(dev_t dev, unsigned count)
@ -498,14 +508,20 @@ void cdev_del(struct cdev *p)
static void cdev_default_release(struct kobject *kobj) static void cdev_default_release(struct kobject *kobj)
{ {
struct cdev *p = container_of(kobj, struct cdev, kobj); struct cdev *p = container_of(kobj, struct cdev, kobj);
struct kobject *parent = kobj->parent;
cdev_purge(p); cdev_purge(p);
kobject_put(parent);
} }
static void cdev_dynamic_release(struct kobject *kobj) static void cdev_dynamic_release(struct kobject *kobj)
{ {
struct cdev *p = container_of(kobj, struct cdev, kobj); struct cdev *p = container_of(kobj, struct cdev, kobj);
struct kobject *parent = kobj->parent;
cdev_purge(p); cdev_purge(p);
kfree(p); kfree(p);
kobject_put(parent);
} }
static struct kobj_type ktype_cdev_default = { static struct kobj_type ktype_cdev_default = {