nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

rtc: pl030: drop needless struct pl030_rtc::rtc member

Browse source 
The memory pointed to by the ::rtc member is managed via devres, and
no code in this driver uses it past _probe().

We can drop it from the structure and just use a local temporary
variable, reducing runtime memory consumption by a few bytes.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: André Draszik <andre.draszik@linaro.org>
Link: https://lore.kernel.org/r/20250304-rtc-cleanups-v2-10-d4689a71668c@linaro.org
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
This commit is contained in:
André Draszik 2025-03-04 17:05:38 +00:00 committed by Alexandre Belloni
parent 38c7aaeab8
commit 3d5d0fe1cb
1 changed files with 7 additions and 7 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

14
drivers/rtc/rtc-pl030.c
View file

@ -21,7 +21,6 @@
#define RTC_CR_MIE (1 << 0) #define RTC_CR_MIE (1 << 0)
struct pl030_rtc { struct pl030_rtc {
struct rtc_device *rtc;
void __iomem *base; void __iomem *base;
}; };
@ -86,6 +85,7 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id)
{ {
struct pl030_rtc *rtc; struct pl030_rtc *rtc;
int ret; int ret;
struct rtc_device *rtc_dev;
ret = amba_request_regions(dev, NULL); ret = amba_request_regions(dev, NULL);
if (ret) if (ret)
@ -97,14 +97,14 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id)
goto err_rtc; goto err_rtc;
} }
rtc->rtc = devm_rtc_allocate_device(&dev->dev); rtc_dev = devm_rtc_allocate_device(&dev->dev);
if (IS_ERR(rtc->rtc)) { if (IS_ERR(rtc_dev)) {
ret = PTR_ERR(rtc->rtc); ret = PTR_ERR(rtc_dev);
goto err_rtc; goto err_rtc;
} }
rtc->rtc->ops = &pl030_ops; rtc_dev->ops = &pl030_ops;
rtc->rtc->range_max = U32_MAX; rtc_dev->range_max = U32_MAX;
rtc->base = ioremap(dev->res.start, resource_size(&dev->res)); rtc->base = ioremap(dev->res.start, resource_size(&dev->res));
if (!rtc->base) { if (!rtc->base) {
ret = -ENOMEM; ret = -ENOMEM;
@ -121,7 +121,7 @@ static int pl030_probe(struct amba_device *dev, const struct amba_id *id)
if (ret) if (ret)
goto err_irq; goto err_irq;
ret = devm_rtc_register_device(rtc->rtc); ret = devm_rtc_register_device(rtc_dev);
if (ret) if (ret)
goto err_reg; goto err_reg;