nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

sch_gred: should not use GFP_KERNEL while holding a spinlock

Browse source 
gred_change_vq() is called under sch_tree_lock(sch).

This means a spinlock is held, and we are not allowed to sleep in this
context.

We might pre-allocate memory using GFP_KERNEL before taking spinlock,
but this is not suitable for stable material.

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Eric Dumazet 2011-12-11 23:42:53 +00:00 committed by David S. Miller
parent 72b36015ba
commit 3f1e6d3fd3
1 changed files with 1 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
net/sched/sch_gred.c
View file

@ -385,7 +385,7 @@ static inline int gred_change_vq(struct Qdisc *sch, int dp,
struct gred_sched_data *q; struct gred_sched_data *q;
if (table->tab[dp] == NULL) { if (table->tab[dp] == NULL) {
table->tab[dp] = kzalloc(sizeof(*q), GFP_KERNEL); table->tab[dp] = kzalloc(sizeof(*q), GFP_ATOMIC);
if (table->tab[dp] == NULL) if (table->tab[dp] == NULL)
return -ENOMEM; return -ENOMEM;
} }