nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

kgdb: fix gcc-11 warning on indentation

Browse source 
gcc-11 starts warning about misleading indentation inside of macros:

drivers/misc/kgdbts.c: In function ‘kgdbts_break_test’:
drivers/misc/kgdbts.c:103:9: error: this ‘if’ clause does not guard... [-Werror=misleading-indentation]
  103 |         if (verbose > 1) \
      |         ^~
drivers/misc/kgdbts.c:200:9: note: in expansion of macro ‘v2printk’
  200 |         v2printk("kgdbts: breakpoint complete\n");
      |         ^~~~~~~~
drivers/misc/kgdbts.c:105:17: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ‘if’
  105 |                 touch_nmi_watchdog();   \
      |                 ^~~~~~~~~~~~~~~~~~

The code looks correct to me, so just reindent it for readability.

Fixes: e8d31c204e ("kgdb: add kgdb internal test suite")
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20210322164308.827846-1-arnd@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Arnd Bergmann 2021-03-22 17:43:03 +01:00 committed by Greg Kroah-Hartman
parent 30a2ac9a8b
commit 40cc3a80bb
1 changed files with 13 additions and 13 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

6
drivers/misc/kgdbts.c
View file

@ -98,16 +98,16 @@
#define v1printk(a...) do { \ #define v1printk(a...) do { \
if (verbose) \ if (verbose) \
printk(KERN_INFO a); \ printk(KERN_INFO a); \
} while (0) } while (0)
#define v2printk(a...) do { \ #define v2printk(a...) do { \
if (verbose > 1) \ if (verbose > 1) \
printk(KERN_INFO a); \ printk(KERN_INFO a); \
touch_nmi_watchdog(); \ touch_nmi_watchdog(); \
} while (0) } while (0)
#define eprintk(a...) do { \ #define eprintk(a...) do { \
printk(KERN_ERR a); \ printk(KERN_ERR a); \
WARN_ON(1); \ WARN_ON(1); \
} while (0) } while (0)
#define MAX_CONFIG_LEN 40 #define MAX_CONFIG_LEN 40
static struct kgdb_io kgdbts_io_ops; static struct kgdb_io kgdbts_io_ops;