nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

net: add debug atomic_inc_not_zero() in dst_hold()

Browse source 
This patch is meant to add a debug warning on the situation where dst is
being held during its destroy phase. This could potentially cause double
free issue on the dst.

Signed-off-by: Wei Wang <weiwan@google.com>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Wei Wang 2017-06-17 10:42:44 -07:00 committed by David S. Miller
parent 1eb04e7c9e
commit 44ebe79149
1 changed files with 1 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
include/net/dst.h
View file

@ -251,7 +251,7 @@ static inline void dst_hold(struct dst_entry *dst)
* __pad_to_align_refcnt declaration in struct dst_entry * __pad_to_align_refcnt declaration in struct dst_entry
*/ */
BUILD_BUG_ON(offsetof(struct dst_entry, __refcnt) & 63); BUILD_BUG_ON(offsetof(struct dst_entry, __refcnt) & 63);
atomic_inc(&dst->__refcnt); WARN_ON(atomic_inc_not_zero(&dst->__refcnt) == 0);
} }
static inline void dst_use(struct dst_entry *dst, unsigned long time) static inline void dst_use(struct dst_entry *dst, unsigned long time)