nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

ASoC: cs35l56: fix reversed if statement in cs35l56_dspwait_asp1tx_put()

Browse source 
It looks like the "!" character was added accidentally.  The
regmap_update_bits_check() function is normally going to succeed.  This
means the rest of the function is unreachable and we don't handle the
situation where "changed" is true correctly.

Fixes: 07f7d6e7a1 ("ASoC: cs35l56: Fix for initializing ASP1 mixer registers")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Link: https://lore.kernel.org/r/0c254c07-d1c0-4a5c-a22b-7e135cab032c@moroto.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
Dan Carpenter 2024-02-05 15:44:30 +03:00 committed by Mark Brown
parent e81fdba020
commit 4703b014f2
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
1 changed files with 1 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
sound/soc/codecs/cs35l56.c
View file

@ -115,7 +115,7 @@ static int cs35l56_dspwait_asp1tx_put(struct snd_kcontrol *kcontrol,
ret = regmap_update_bits_check(cs35l56->base.regmap, addr, ret = regmap_update_bits_check(cs35l56->base.regmap, addr,
CS35L56_ASP_TXn_SRC_MASK, val, &changed); CS35L56_ASP_TXn_SRC_MASK, val, &changed);
if (!ret) if (ret)
return ret; return ret;
if (changed) if (changed)