nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

hwmon: Deal with errors from the thermal subsystem

Browse source 
If the thermal subsystem returne -EPROBE_DEFER or any other error
when hwmon calls devm_thermal_zone_of_sensor_register(), this is
silently ignored.

I ran into this with an incorrectly defined thermal zone, making
it non-existing and thus this call failed with -EPROBE_DEFER
assuming it would appear later. The sensor was still added
which is incorrect: sensors must strictly be added after the
thermal zones, so deferred probe must be respected.

Fixes: d560168b5d ("hwmon: (core) New hwmon registration API")
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
This commit is contained in:
Linus Walleij 2017-12-05 09:36:14 +01:00 committed by Guenter Roeck
parent 464e1d5f23
commit 47c332deb8
1 changed files with 17 additions and 4 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

19
drivers/hwmon/hwmon.c
View file

@ -143,6 +143,7 @@ static int hwmon_thermal_add_sensor(struct device *dev,
struct hwmon_device *hwdev, int index) struct hwmon_device *hwdev, int index)
{ {
struct hwmon_thermal_data *tdata; struct hwmon_thermal_data *tdata;
struct thermal_zone_device *tzd;
tdata = devm_kzalloc(dev, sizeof(*tdata), GFP_KERNEL); tdata = devm_kzalloc(dev, sizeof(*tdata), GFP_KERNEL);
if (!tdata) if (!tdata)
@ -151,8 +152,14 @@ static int hwmon_thermal_add_sensor(struct device *dev,
tdata->hwdev = hwdev; tdata->hwdev = hwdev;
tdata->index = index; tdata->index = index;
devm_thermal_zone_of_sensor_register(&hwdev->dev, index, tdata, tzd = devm_thermal_zone_of_sensor_register(&hwdev->dev, index, tdata,
&hwmon_thermal_ops); &hwmon_thermal_ops);
/*
* If CONFIG_THERMAL_OF is disabled, this returns -ENODEV,
* so ignore that error but forward any other error.
*/
if (IS_ERR(tzd) && (PTR_ERR(tzd) != -ENODEV))
return PTR_ERR(tzd);
return 0; return 0;
} }
@ -621,14 +628,20 @@ __hwmon_device_register(struct device *dev, const char *name, void *drvdata,
if (!chip->ops->is_visible(drvdata, hwmon_temp, if (!chip->ops->is_visible(drvdata, hwmon_temp,
hwmon_temp_input, j)) hwmon_temp_input, j))
continue; continue;
if (info[i]->config[j] & HWMON_T_INPUT) if (info[i]->config[j] & HWMON_T_INPUT) {
hwmon_thermal_add_sensor(dev, hwdev, j); err = hwmon_thermal_add_sensor(dev,
hwdev, j);
if (err)
goto free_device;
}
} }
} }
} }
return hdev; return hdev;
free_device:
device_unregister(hdev);
free_hwmon: free_hwmon:
kfree(hwdev); kfree(hwdev);
ida_remove: ida_remove: