forked from mirrors/linux
		
	net sched actions: aggregate dumping of actions timeinfo
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com> Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
		
							parent
							
								
									53eb440f4a
								
							
						
					
					
						commit
						48d8ee1694
					
				
					 13 changed files with 29 additions and 48 deletions
				
			
		|  | @ -80,6 +80,14 @@ static inline void tcf_lastuse_update(struct tcf_t *tm) | ||||||
| 		tm->firstuse = now; | 		tm->firstuse = now; | ||||||
| } | } | ||||||
| 
 | 
 | ||||||
|  | static inline void tcf_tm_dump(struct tcf_t *dtm, const struct tcf_t *stm) | ||||||
|  | { | ||||||
|  | 	dtm->install = jiffies_to_clock_t(jiffies - stm->install); | ||||||
|  | 	dtm->lastuse = jiffies_to_clock_t(jiffies - stm->lastuse); | ||||||
|  | 	dtm->firstuse = jiffies_to_clock_t(jiffies - stm->firstuse); | ||||||
|  | 	dtm->expires = jiffies_to_clock_t(stm->expires); | ||||||
|  | } | ||||||
|  | 
 | ||||||
| struct tc_action { | struct tc_action { | ||||||
| 	void			*priv; | 	void			*priv; | ||||||
| 	const struct tc_action_ops	*ops; | 	const struct tc_action_ops	*ops; | ||||||
|  |  | ||||||
|  | @ -154,11 +154,7 @@ static int tcf_bpf_dump(struct sk_buff *skb, struct tc_action *act, | ||||||
| 	if (ret) | 	if (ret) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 
 | 
 | ||||||
| 	tm.install = jiffies_to_clock_t(jiffies - prog->tcf_tm.install); | 	tcf_tm_dump(&tm, &prog->tcf_tm); | ||||||
| 	tm.lastuse = jiffies_to_clock_t(jiffies - prog->tcf_tm.lastuse); |  | ||||||
| 	tm.firstuse = jiffies_to_clock_t(jiffies - prog->tcf_tm.firstuse); |  | ||||||
| 	tm.expires = jiffies_to_clock_t(prog->tcf_tm.expires); |  | ||||||
| 
 |  | ||||||
| 	if (nla_put_64bit(skb, TCA_ACT_BPF_TM, sizeof(tm), &tm, | 	if (nla_put_64bit(skb, TCA_ACT_BPF_TM, sizeof(tm), &tm, | ||||||
| 			  TCA_ACT_BPF_PAD)) | 			  TCA_ACT_BPF_PAD)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
|  |  | ||||||
|  | @ -160,10 +160,7 @@ static inline int tcf_connmark_dump(struct sk_buff *skb, struct tc_action *a, | ||||||
| 	if (nla_put(skb, TCA_CONNMARK_PARMS, sizeof(opt), &opt)) | 	if (nla_put(skb, TCA_CONNMARK_PARMS, sizeof(opt), &opt)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 
 | 
 | ||||||
| 	t.install = jiffies_to_clock_t(jiffies - ci->tcf_tm.install); | 	tcf_tm_dump(&t, &ci->tcf_tm); | ||||||
| 	t.lastuse = jiffies_to_clock_t(jiffies - ci->tcf_tm.lastuse); |  | ||||||
| 	t.expires = jiffies_to_clock_t(ci->tcf_tm.expires); |  | ||||||
| 	t.firstuse = jiffies_to_clock_t(jiffies - ci->tcf_tm.firstuse); |  | ||||||
| 	if (nla_put_64bit(skb, TCA_CONNMARK_TM, sizeof(t), &t, | 	if (nla_put_64bit(skb, TCA_CONNMARK_TM, sizeof(t), &t, | ||||||
| 			  TCA_CONNMARK_PAD)) | 			  TCA_CONNMARK_PAD)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
|  |  | ||||||
|  | @ -546,10 +546,8 @@ static int tcf_csum_dump(struct sk_buff *skb, | ||||||
| 
 | 
 | ||||||
| 	if (nla_put(skb, TCA_CSUM_PARMS, sizeof(opt), &opt)) | 	if (nla_put(skb, TCA_CSUM_PARMS, sizeof(opt), &opt)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 	t.install = jiffies_to_clock_t(jiffies - p->tcf_tm.install); | 
 | ||||||
| 	t.lastuse = jiffies_to_clock_t(jiffies - p->tcf_tm.lastuse); | 	tcf_tm_dump(&t, &p->tcf_tm); | ||||||
| 	t.firstuse = jiffies_to_clock_t(jiffies - p->tcf_tm.firstuse); |  | ||||||
| 	t.expires = jiffies_to_clock_t(p->tcf_tm.expires); |  | ||||||
| 	if (nla_put_64bit(skb, TCA_CSUM_TM, sizeof(t), &t, TCA_CSUM_PAD)) | 	if (nla_put_64bit(skb, TCA_CSUM_TM, sizeof(t), &t, TCA_CSUM_PAD)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 
 | 
 | ||||||
|  |  | ||||||
|  | @ -188,10 +188,7 @@ static int tcf_gact_dump(struct sk_buff *skb, struct tc_action *a, int bind, int | ||||||
| 			goto nla_put_failure; | 			goto nla_put_failure; | ||||||
| 	} | 	} | ||||||
| #endif | #endif | ||||||
| 	t.install = jiffies_to_clock_t(jiffies - gact->tcf_tm.install); | 	tcf_tm_dump(&t, &gact->tcf_tm); | ||||||
| 	t.lastuse = jiffies_to_clock_t(jiffies - gact->tcf_tm.lastuse); |  | ||||||
| 	t.firstuse = jiffies_to_clock_t(jiffies - gact->tcf_tm.firstuse); |  | ||||||
| 	t.expires = jiffies_to_clock_t(gact->tcf_tm.expires); |  | ||||||
| 	if (nla_put_64bit(skb, TCA_GACT_TM, sizeof(t), &t, TCA_GACT_PAD)) | 	if (nla_put_64bit(skb, TCA_GACT_TM, sizeof(t), &t, TCA_GACT_PAD)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 	return skb->len; | 	return skb->len; | ||||||
|  |  | ||||||
|  | @ -553,9 +553,7 @@ static int tcf_ife_dump(struct sk_buff *skb, struct tc_action *a, int bind, | ||||||
| 	if (nla_put(skb, TCA_IFE_PARMS, sizeof(opt), &opt)) | 	if (nla_put(skb, TCA_IFE_PARMS, sizeof(opt), &opt)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 
 | 
 | ||||||
| 	t.install = jiffies_to_clock_t(jiffies - ife->tcf_tm.install); | 	tcf_tm_dump(&t, &ife->tcf_tm); | ||||||
| 	t.lastuse = jiffies_to_clock_t(jiffies - ife->tcf_tm.lastuse); |  | ||||||
| 	t.expires = jiffies_to_clock_t(ife->tcf_tm.expires); |  | ||||||
| 	if (nla_put_64bit(skb, TCA_IFE_TM, sizeof(t), &t, TCA_IFE_PAD)) | 	if (nla_put_64bit(skb, TCA_IFE_TM, sizeof(t), &t, TCA_IFE_PAD)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 
 | 
 | ||||||
|  |  | ||||||
|  | @ -277,12 +277,11 @@ static int tcf_ipt_dump(struct sk_buff *skb, struct tc_action *a, int bind, int | ||||||
| 	    nla_put(skb, TCA_IPT_CNT, sizeof(struct tc_cnt), &c) || | 	    nla_put(skb, TCA_IPT_CNT, sizeof(struct tc_cnt), &c) || | ||||||
| 	    nla_put_string(skb, TCA_IPT_TABLE, ipt->tcfi_tname)) | 	    nla_put_string(skb, TCA_IPT_TABLE, ipt->tcfi_tname)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 	tm.install = jiffies_to_clock_t(jiffies - ipt->tcf_tm.install); | 
 | ||||||
| 	tm.lastuse = jiffies_to_clock_t(jiffies - ipt->tcf_tm.lastuse); | 	tcf_tm_dump(&tm, &ipt->tcf_tm); | ||||||
| 	tm.firstuse = jiffies_to_clock_t(jiffies - ipt->tcf_tm.firstuse); |  | ||||||
| 	tm.expires = jiffies_to_clock_t(ipt->tcf_tm.expires); |  | ||||||
| 	if (nla_put_64bit(skb, TCA_IPT_TM, sizeof(tm), &tm, TCA_IPT_PAD)) | 	if (nla_put_64bit(skb, TCA_IPT_TM, sizeof(tm), &tm, TCA_IPT_PAD)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
|  | 
 | ||||||
| 	kfree(t); | 	kfree(t); | ||||||
| 	return skb->len; | 	return skb->len; | ||||||
| 
 | 
 | ||||||
|  |  | ||||||
|  | @ -218,10 +218,8 @@ static int tcf_mirred_dump(struct sk_buff *skb, struct tc_action *a, int bind, i | ||||||
| 
 | 
 | ||||||
| 	if (nla_put(skb, TCA_MIRRED_PARMS, sizeof(opt), &opt)) | 	if (nla_put(skb, TCA_MIRRED_PARMS, sizeof(opt), &opt)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 	t.install = jiffies_to_clock_t(jiffies - m->tcf_tm.install); | 
 | ||||||
| 	t.lastuse = jiffies_to_clock_t(jiffies - m->tcf_tm.lastuse); | 	tcf_tm_dump(&t, &m->tcf_tm); | ||||||
| 	t.firstuse = jiffies_to_clock_t(jiffies - m->tcf_tm.firstuse); |  | ||||||
| 	t.expires = jiffies_to_clock_t(m->tcf_tm.expires); |  | ||||||
| 	if (nla_put_64bit(skb, TCA_MIRRED_TM, sizeof(t), &t, TCA_MIRRED_PAD)) | 	if (nla_put_64bit(skb, TCA_MIRRED_TM, sizeof(t), &t, TCA_MIRRED_PAD)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 	return skb->len; | 	return skb->len; | ||||||
|  |  | ||||||
|  | @ -264,10 +264,8 @@ static int tcf_nat_dump(struct sk_buff *skb, struct tc_action *a, | ||||||
| 
 | 
 | ||||||
| 	if (nla_put(skb, TCA_NAT_PARMS, sizeof(opt), &opt)) | 	if (nla_put(skb, TCA_NAT_PARMS, sizeof(opt), &opt)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 	t.install = jiffies_to_clock_t(jiffies - p->tcf_tm.install); | 
 | ||||||
| 	t.lastuse = jiffies_to_clock_t(jiffies - p->tcf_tm.lastuse); | 	tcf_tm_dump(&t, &p->tcf_tm); | ||||||
| 	t.firstuse = jiffies_to_clock_t(jiffies - p->tcf_tm.firstuse); |  | ||||||
| 	t.expires = jiffies_to_clock_t(p->tcf_tm.expires); |  | ||||||
| 	if (nla_put_64bit(skb, TCA_NAT_TM, sizeof(t), &t, TCA_NAT_PAD)) | 	if (nla_put_64bit(skb, TCA_NAT_TM, sizeof(t), &t, TCA_NAT_PAD)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 
 | 
 | ||||||
|  |  | ||||||
|  | @ -200,12 +200,11 @@ static int tcf_pedit_dump(struct sk_buff *skb, struct tc_action *a, | ||||||
| 
 | 
 | ||||||
| 	if (nla_put(skb, TCA_PEDIT_PARMS, s, opt)) | 	if (nla_put(skb, TCA_PEDIT_PARMS, s, opt)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 	t.install = jiffies_to_clock_t(jiffies - p->tcf_tm.install); | 
 | ||||||
| 	t.lastuse = jiffies_to_clock_t(jiffies - p->tcf_tm.lastuse); | 	tcf_tm_dump(&t, &p->tcf_tm); | ||||||
| 	t.firstuse = jiffies_to_clock_t(jiffies - p->tcf_tm.firstuse); |  | ||||||
| 	t.expires = jiffies_to_clock_t(p->tcf_tm.expires); |  | ||||||
| 	if (nla_put_64bit(skb, TCA_PEDIT_TM, sizeof(t), &t, TCA_PEDIT_PAD)) | 	if (nla_put_64bit(skb, TCA_PEDIT_TM, sizeof(t), &t, TCA_PEDIT_PAD)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
|  | 
 | ||||||
| 	kfree(opt); | 	kfree(opt); | ||||||
| 	return skb->len; | 	return skb->len; | ||||||
| 
 | 
 | ||||||
|  |  | ||||||
|  | @ -158,10 +158,8 @@ static int tcf_simp_dump(struct sk_buff *skb, struct tc_action *a, | ||||||
| 	if (nla_put(skb, TCA_DEF_PARMS, sizeof(opt), &opt) || | 	if (nla_put(skb, TCA_DEF_PARMS, sizeof(opt), &opt) || | ||||||
| 	    nla_put_string(skb, TCA_DEF_DATA, d->tcfd_defdata)) | 	    nla_put_string(skb, TCA_DEF_DATA, d->tcfd_defdata)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 	t.install = jiffies_to_clock_t(jiffies - d->tcf_tm.install); | 
 | ||||||
| 	t.lastuse = jiffies_to_clock_t(jiffies - d->tcf_tm.lastuse); | 	tcf_tm_dump(&t, &d->tcf_tm); | ||||||
| 	t.firstuse = jiffies_to_clock_t(jiffies - d->tcf_tm.firstuse); |  | ||||||
| 	t.expires = jiffies_to_clock_t(d->tcf_tm.expires); |  | ||||||
| 	if (nla_put_64bit(skb, TCA_DEF_TM, sizeof(t), &t, TCA_DEF_PAD)) | 	if (nla_put_64bit(skb, TCA_DEF_TM, sizeof(t), &t, TCA_DEF_PAD)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 	return skb->len; | 	return skb->len; | ||||||
|  |  | ||||||
|  | @ -168,10 +168,8 @@ static int tcf_skbedit_dump(struct sk_buff *skb, struct tc_action *a, | ||||||
| 	    nla_put(skb, TCA_SKBEDIT_MARK, sizeof(d->mark), | 	    nla_put(skb, TCA_SKBEDIT_MARK, sizeof(d->mark), | ||||||
| 		    &d->mark)) | 		    &d->mark)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 	t.install = jiffies_to_clock_t(jiffies - d->tcf_tm.install); | 
 | ||||||
| 	t.lastuse = jiffies_to_clock_t(jiffies - d->tcf_tm.lastuse); | 	tcf_tm_dump(&t, &d->tcf_tm); | ||||||
| 	t.firstuse = jiffies_to_clock_t(jiffies - d->tcf_tm.firstuse); |  | ||||||
| 	t.expires = jiffies_to_clock_t(d->tcf_tm.expires); |  | ||||||
| 	if (nla_put_64bit(skb, TCA_SKBEDIT_TM, sizeof(t), &t, TCA_SKBEDIT_PAD)) | 	if (nla_put_64bit(skb, TCA_SKBEDIT_TM, sizeof(t), &t, TCA_SKBEDIT_PAD)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 	return skb->len; | 	return skb->len; | ||||||
|  |  | ||||||
|  | @ -182,10 +182,7 @@ static int tcf_vlan_dump(struct sk_buff *skb, struct tc_action *a, | ||||||
| 	     nla_put_be16(skb, TCA_VLAN_PUSH_VLAN_PROTOCOL, v->tcfv_push_proto))) | 	     nla_put_be16(skb, TCA_VLAN_PUSH_VLAN_PROTOCOL, v->tcfv_push_proto))) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 
 | 
 | ||||||
| 	t.install = jiffies_to_clock_t(jiffies - v->tcf_tm.install); | 	tcf_tm_dump(&t, &v->tcf_tm); | ||||||
| 	t.lastuse = jiffies_to_clock_t(jiffies - v->tcf_tm.lastuse); |  | ||||||
| 	t.firstuse = jiffies_to_clock_t(jiffies - v->tcf_tm.firstuse); |  | ||||||
| 	t.expires = jiffies_to_clock_t(v->tcf_tm.expires); |  | ||||||
| 	if (nla_put_64bit(skb, TCA_VLAN_TM, sizeof(t), &t, TCA_VLAN_PAD)) | 	if (nla_put_64bit(skb, TCA_VLAN_TM, sizeof(t), &t, TCA_VLAN_PAD)) | ||||||
| 		goto nla_put_failure; | 		goto nla_put_failure; | ||||||
| 	return skb->len; | 	return skb->len; | ||||||
|  |  | ||||||
		Loading…
	
		Reference in a new issue
	
	 Jamal Hadi Salim
						Jamal Hadi Salim