nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

ice, irdma: fix an off by one in error handling code

Browse source 
If we don't allocate the MIN number of IRQs then we need to free what
we have and return -ENOMEM.  The problem is this loop is off by one
so it frees an entry that wasn't allocated and it doesn't free the
first entry where i == 0.

Fixes: 3e0d3cb3fb ("ice, irdma: move interrupts code to irdma")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Tatyana Nikolova <tatyana.e.nikolova@intel.com>
Link: https://patch.msgid.link/20250414234231.523-2-tatyana.e.nikolova@intel.com
Reviewed-by: Michal Swiatkowski <michal.swiatkowski@linux.intel.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
This commit is contained in:
Dan Carpenter 2025-04-14 18:42:31 -05:00 committed by Leon Romanovsky
parent 80f2ab46c2
commit 4bcc063939
1 changed files with 1 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/infiniband/hw/irdma/main.c
View file

@ -221,7 +221,7 @@ static int irdma_init_interrupts(struct irdma_pci_f *rf, struct ice_pf *pf)
break; break;
if (i < IRDMA_MIN_MSIX) { if (i < IRDMA_MIN_MSIX) {
for (; i > 0; i--) while (--i >= 0)
ice_free_rdma_qvector(pf, &rf->msix_entries[i]); ice_free_rdma_qvector(pf, &rf->msix_entries[i]);
kfree(rf->msix_entries); kfree(rf->msix_entries);