nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

media: ov5640: Make the return rate type more explicit

Browse source 
In the ov5640_try_frame_interval function, the ret variable actually holds
the frame rate index to use, which is represented by the enum
ov5640_frame_rate in the driver.

Make it more obvious.

Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Tested-by: Adam Ford <aford173@gmail.com> #imx6dq
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
This commit is contained in:
Maxime Ripard 2018-12-03 03:44:24 -05:00 committed by Mauro Carvalho Chehab
parent 086c25f8fe
commit 5a3ad937bc
1 changed files with 4 additions and 4 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

8
drivers/media/i2c/ov5640.c
View file

@ -2052,8 +2052,8 @@ static int ov5640_try_frame_interval(struct ov5640_dev *sensor,
u32 width, u32 height) u32 width, u32 height)
{ {
const struct ov5640_mode_info *mode; const struct ov5640_mode_info *mode;
enum ov5640_frame_rate rate = OV5640_30_FPS;
u32 minfps, maxfps, fps; u32 minfps, maxfps, fps;
int ret;
minfps = ov5640_framerates[OV5640_15_FPS]; minfps = ov5640_framerates[OV5640_15_FPS];
maxfps = ov5640_framerates[OV5640_30_FPS]; maxfps = ov5640_framerates[OV5640_30_FPS];
@ -2076,10 +2076,10 @@ static int ov5640_try_frame_interval(struct ov5640_dev *sensor,
else else
fi->denominator = minfps; fi->denominator = minfps;
ret = (fi->denominator == minfps) ? OV5640_15_FPS : OV5640_30_FPS; rate = (fi->denominator == minfps) ? OV5640_15_FPS : OV5640_30_FPS;
mode = ov5640_find_mode(sensor, ret, width, height, false); mode = ov5640_find_mode(sensor, rate, width, height, false);
return mode ? ret : -EINVAL; return mode ? rate : -EINVAL;
} }
static int ov5640_get_fmt(struct v4l2_subdev *sd, static int ov5640_get_fmt(struct v4l2_subdev *sd,