nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

spi: Remove the now unused ctlr->idling flag

Browse source 
The ctlr->idling flag is never checked now, so we don't need to set it
either.

Signed-off-by: David Jander <david@protonic.nl>
Link: https://lore.kernel.org/r/20220621061234.3626638-8-david@protonic.nl
Signed-off-by: Mark Brown <broonie@kernel.org>
This commit is contained in:
David Jander 2022-06-21 08:12:30 +02:00 committed by Mark Brown
parent 049d6ccc4d
commit 66a221593c
No known key found for this signature in database
GPG key ID: 24D68B725D5487D0
2 changed files with 0 additions and 4 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/spi/spi.c
View file

@ -1674,7 +1674,6 @@ static void __spi_pump_messages(struct spi_controller *ctlr, bool in_kthread)
} }
ctlr->busy = false; ctlr->busy = false;
ctlr->idling = true;
spin_unlock_irqrestore(&ctlr->queue_lock, flags); spin_unlock_irqrestore(&ctlr->queue_lock, flags);
kfree(ctlr->dummy_rx); kfree(ctlr->dummy_rx);
@ -1689,7 +1688,6 @@ static void __spi_pump_messages(struct spi_controller *ctlr, bool in_kthread)
trace_spi_controller_idle(ctlr); trace_spi_controller_idle(ctlr);
spin_lock_irqsave(&ctlr->queue_lock, flags); spin_lock_irqsave(&ctlr->queue_lock, flags);
ctlr->idling = false;
ctlr->queue_empty = true; ctlr->queue_empty = true;
goto out_unlock; goto out_unlock;
} }

2
include/linux/spi/spi.h
View file

@ -383,7 +383,6 @@ extern struct spi_device *spi_new_ancillary_device(struct spi_device *spi, u8 ch
* @pump_messages: work struct for scheduling work to the message pump * @pump_messages: work struct for scheduling work to the message pump
* @queue_lock: spinlock to syncronise access to message queue * @queue_lock: spinlock to syncronise access to message queue
* @queue: message queue * @queue: message queue
* @idling: the device is entering idle state
* @cur_msg: the currently in-flight message * @cur_msg: the currently in-flight message
* @cur_msg_mapped: message has been mapped for DMA * @cur_msg_mapped: message has been mapped for DMA
* @last_cs: the last chip_select that is recorded by set_cs, -1 on non chip * @last_cs: the last chip_select that is recorded by set_cs, -1 on non chip
@ -616,7 +615,6 @@ struct spi_controller {
spinlock_t queue_lock; spinlock_t queue_lock;
struct list_head queue; struct list_head queue;
struct spi_message *cur_msg; struct spi_message *cur_msg;
bool idling;
bool busy; bool busy;
bool running; bool running;
bool rt; bool rt;