nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

MD: warn for potential deadlock

Browse source 
The personality thread shouldn't call mddev_suspend(). Because
mddev_suspend() will for all IO finish, but IO is handled in personality
thread, so this could cause deadlock. To trigger this early, add a
warning if mddev_suspend() is called from personality thread.

Suggested-by: NeilBrown <neilb@suse.com>
Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
Signed-off-by: Shaohua Li <shli@fb.com>
This commit is contained in:
Shaohua Li 2016-02-24 17:41:01 -08:00
parent 399146b80e
commit 70d9798b95
1 changed files with 1 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/md/md.c
View file

@ -305,6 +305,7 @@ static blk_qc_t md_make_request(struct request_queue *q, struct bio *bio)
*/ */
void mddev_suspend(struct mddev *mddev) void mddev_suspend(struct mddev *mddev)
{ {
WARN_ON_ONCE(current == mddev->thread->tsk);
if (mddev->suspended++) if (mddev->suspended++)
return; return;
synchronize_rcu(); synchronize_rcu();