nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

btrfs: Don't panic when we can't find a root key

Browse source 
When we failed to find a root key in btrfs_update_root(), we just panic.

That's definitely not cool, fix it by outputting an unique error
message, aborting current transaction and return -EUCLEAN. This should
not normally happen as the root has been used by the callers in some
way.

Reviewed-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Qu Wenruo <wqu@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
This commit is contained in:
Qu Wenruo 2019-02-26 16:33:56 +08:00 committed by David Sterba
parent c53839fc32
commit 7ac1e464c4
1 changed files with 8 additions and 5 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

13
fs/btrfs/root-tree.c
View file

@ -137,11 +137,14 @@ int btrfs_update_root(struct btrfs_trans_handle *trans, struct btrfs_root
goto out; goto out;
} }
if (ret != 0) { if (ret > 0) {
btrfs_print_leaf(path->nodes[0]); btrfs_crit(fs_info,
btrfs_crit(fs_info, "unable to update root key %llu %u %llu", "unable to find root key (%llu %u %llu) in tree %llu",
key->objectid, key->type, key->offset); key->objectid, key->type, key->offset,
BUG_ON(1); root->root_key.objectid);
ret = -EUCLEAN;
btrfs_abort_transaction(trans, ret);
goto out;
} }
l = path->nodes[0]; l = path->nodes[0];