nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

i40e: Invoke softirqs after napi_reschedule

Browse source 
The following message is logged from time to time when using i40e:
NOHZ: local_softirq_pending 08

i40e may schedule napi from a workqueue. Afterwards, softirqs are not run
in a deterministic time frame. The problem is the same as what was
described in commit ec13ee8014 ("virtio_net: invoke softirqs after
__napi_schedule") and this patch applies the same fix to i40e.

Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
This commit is contained in:
Benjamin Poirier 2017-01-12 17:04:14 -08:00 committed by Jeff Kirsher
parent ee847d9351
commit 83a0c6e589
1 changed files with 2 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/net/ethernet/intel/i40e/i40e_main.c
View file

@ -4685,8 +4685,10 @@ static void i40e_detect_recover_hung_queue(int q_idx, struct i40e_vsi *vsi)
*/ */
if ((!tx_pending_hw) && i40e_get_tx_pending(tx_ring, true) && if ((!tx_pending_hw) && i40e_get_tx_pending(tx_ring, true) &&
(!(val & I40E_PFINT_DYN_CTLN_INTENA_MASK))) { (!(val & I40E_PFINT_DYN_CTLN_INTENA_MASK))) {
local_bh_disable();
if (napi_reschedule(&tx_ring->q_vector->napi)) if (napi_reschedule(&tx_ring->q_vector->napi))
tx_ring->tx_stats.tx_lost_interrupt++; tx_ring->tx_stats.tx_lost_interrupt++;
local_bh_enable();
} }
} }