nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

checkpatch: warn on bare unsigned or signed declarations without int

Browse source 
Kernel style prefers "unsigned int <foo>" over "unsigned <foo>" and
"signed int <foo>" over "signed <foo>".

Emit a warning for these simple signed/unsigned <foo> declarations.  Fix
it too if desired.

Signed-off-by: Joe Perches <joe@perches.com>
Acked-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
This commit is contained in:
Joe Perches 2016-03-15 14:58:03 -07:00 committed by Linus Torvalds
parent 42e152931d
commit a1ce18e4f9
1 changed files with 20 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

20
scripts/checkpatch.pl
View file

@ -3239,6 +3239,26 @@ sub process {
#ignore lines not being added #ignore lines not being added
next if ($line =~ /^[^\+]/); next if ($line =~ /^[^\+]/);
# check for declarations of signed or unsigned without int
while ($line =~ m{($Declare++)\s*($Ident)\s*[=,;\[\)]}g) {
my $type = $1;
my $var = $2;
if ($type =~ /^((?:un)?signed)((?:\s*\*)*)\s*$/) {
my $sign = $1;
my $pointer = $2;
$pointer = "" if (!defined $pointer);
if (WARN("UNSPECIFIED_INT",
"Prefer '" . trim($sign) . " int" . rtrim($pointer) . "' to bare use of '$sign" . rtrim($pointer) . "'\n" . $herecurr) &&
$fix) {
my $decl = trim($sign) . " int ";
$decl .= trim($pointer) if (rtrim($pointer) ne "");
$fixed[$fixlinenr] =~ s@\b\Q$type\E\s*$var\b@$decl$var@;
}
}
}
# TEST: allow direct testing of the type matcher. # TEST: allow direct testing of the type matcher.
if ($dbg_type) { if ($dbg_type) {
if ($line =~ /^.\s*$Declare\s*$/) { if ($line =~ /^.\s*$Declare\s*$/) {