nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

blk-iolatency: only account submitted bios

Browse source 
As is, iolatency recognizes done_bio and cleanup as ending paths. If a
request is marked REQ_NOWAIT and fails to get a request, the bio is
cleaned up via rq_qos_cleanup() and ended in bio_wouldblock_error().
This results in underflowing the inflight counter. Fix this by only
accounting bios that were actually submitted.

Signed-off-by: Dennis Zhou <dennis@kernel.org>
Cc: Josef Bacik <josef@toxicpanda.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
Dennis Zhou 2019-05-23 16:10:18 -04:00 committed by Jens Axboe
parent d27e84a305
commit a3fb01ba5a
1 changed files with 4 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

4
block/blk-iolatency.c
View file

@ -600,6 +600,10 @@ static void blkcg_iolatency_done_bio(struct rq_qos *rqos, struct bio *bio)
if (!blkg || !bio_flagged(bio, BIO_TRACKED)) if (!blkg || !bio_flagged(bio, BIO_TRACKED))
return; return;
/* We didn't actually submit this bio, don't account it. */
if (bio->bi_status == BLK_STS_AGAIN)
return;
iolat = blkg_to_lat(bio->bi_blkg); iolat = blkg_to_lat(bio->bi_blkg);
if (!iolat) if (!iolat)
return; return;