nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

net: devmem: do not WARN conditionally after netdev_rx_queue_restart()

Browse source 
When devmem socket is closed, netdev_rx_queue_restart() is called to
reset queue by the net_devmem_unbind_dmabuf(). But callback may return
-ENETDOWN if the interface is down because queues are already freed
when the interface is down so queue reset is not needed.
So, it should not warn if the return value is -ENETDOWN.

Signed-off-by: Taehee Yoo <ap420073@gmail.com>
Reviewed-by: Mina Almasry <almasrymina@google.com>
Link: https://patch.msgid.link/20250309134219.91670-8-ap420073@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
This commit is contained in:
Taehee Yoo 2025-03-09 13:42:18 +00:00 committed by Jakub Kicinski
parent 87dd285083
commit a70f891e0f
1 changed files with 3 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

4
net/core/devmem.c
View file

@ -109,6 +109,7 @@ void net_devmem_unbind_dmabuf(struct net_devmem_dmabuf_binding *binding)
struct netdev_rx_queue *rxq; struct netdev_rx_queue *rxq;
unsigned long xa_idx; unsigned long xa_idx;
unsigned int rxq_idx; unsigned int rxq_idx;
int err;
if (binding->list.next) if (binding->list.next)
list_del(&binding->list); list_del(&binding->list);
@ -120,7 +121,8 @@ void net_devmem_unbind_dmabuf(struct net_devmem_dmabuf_binding *binding)
rxq_idx = get_netdev_rx_queue_index(rxq); rxq_idx = get_netdev_rx_queue_index(rxq);
WARN_ON(netdev_rx_queue_restart(binding->dev, rxq_idx)); err = netdev_rx_queue_restart(binding->dev, rxq_idx);
WARN_ON(err && err != -ENETDOWN);
} }
xa_erase(&net_devmem_dmabuf_bindings, binding->id); xa_erase(&net_devmem_dmabuf_bindings, binding->id);