nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

net: bcmgenet: Return PTR_ERR() for fixed_phy_register()

Browse source 
fixed_phy_register() returns -EPROBE_DEFER, -EINVAL and -EBUSY,
etc, in addition to -ENODEV. The Best practice is to return these
error codes with PTR_ERR().

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Acked-by: Doug Berger <opendmb@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ruan Jinjie 2023-08-18 15:07:06 +08:00 committed by David S. Miller
parent d6499f0b7c
commit acf50d1adb
1 changed files with 1 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/net/ethernet/broadcom/genet/bcmmii.c
View file

@ -619,7 +619,7 @@ static int bcmgenet_mii_pd_init(struct bcmgenet_priv *priv)
phydev = fixed_phy_register(PHY_POLL, &fphy_status, NULL);
if (!phydev || IS_ERR(phydev)) {
dev_err(kdev, "failed to register fixed PHY device\n");
return -ENODEV;
return PTR_ERR(phydev);
}
/* Make sure we initialize MoCA PHYs with a link down */