nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

usb: atm: Use struct_size() helper

Browse source 
Make use of the struct_size() helper instead of an open-coded version,
in order to avoid any potential type mistakes or integer overflows that,
in the worse scenario, could lead to heap overflows.

Link: https://github.com/KSPP/linux/issues/160
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20210928233935.GA299525@embeddedor
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Gustavo A. R. Silva 2021-09-28 18:39:35 -05:00 committed by Greg Kroah-Hartman
parent c1baf6c591
commit b626871a7c
1 changed files with 3 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

4
drivers/usb/atm/usbatm.c
View file

@ -1015,9 +1015,11 @@ int usbatm_usb_probe(struct usb_interface *intf, const struct usb_device_id *id,
int error = -ENOMEM; int error = -ENOMEM;
int i, length; int i, length;
unsigned int maxpacket, num_packets; unsigned int maxpacket, num_packets;
size_t size;
/* instance init */ /* instance init */
instance = kzalloc(sizeof(*instance) + sizeof(struct urb *) * (num_rcv_urbs + num_snd_urbs), GFP_KERNEL); size = struct_size(instance, urbs, num_rcv_urbs + num_snd_urbs);
instance = kzalloc(size, GFP_KERNEL);
if (!instance) if (!instance)
return -ENOMEM; return -ENOMEM;