nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

lightnvm: remove set but not used variables 'data_len' and 'rq_len'

Browse source 
drivers/lightnvm/pblk-read.c: In function pblk_submit_read_gc:
drivers/lightnvm/pblk-read.c:423:6: warning: variable data_len set but not used [-Wunused-but-set-variable]
drivers/lightnvm/pblk-recovery.c: In function pblk_recov_scan_oob:
drivers/lightnvm/pblk-recovery.c:368:15: warning: variable rq_len set but not used [-Wunused-but-set-variable]

They are not used since commit 48e5da7255 ("lightnvm:
move metadata mapping to lower level driver")

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
This commit is contained in:
YueHaibing 2019-08-07 21:18:47 +08:00 committed by Jens Axboe
parent e8fc87f6a9
commit ba6f7da99a
2 changed files with 1 additions and 4 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/lightnvm/pblk-read.c
View file

@ -420,7 +420,6 @@ int pblk_submit_read_gc(struct pblk *pblk, struct pblk_gc_rq *gc_rq)
struct nvm_tgt_dev *dev = pblk->dev; struct nvm_tgt_dev *dev = pblk->dev;
struct nvm_geo *geo = &dev->geo; struct nvm_geo *geo = &dev->geo;
struct nvm_rq rqd; struct nvm_rq rqd;
int data_len;
int ret = NVM_IO_OK; int ret = NVM_IO_OK;
memset(&rqd, 0, sizeof(struct nvm_rq)); memset(&rqd, 0, sizeof(struct nvm_rq));
@ -445,7 +444,6 @@ int pblk_submit_read_gc(struct pblk *pblk, struct pblk_gc_rq *gc_rq)
if (!(gc_rq->secs_to_gc)) if (!(gc_rq->secs_to_gc))
goto out; goto out;
data_len = (gc_rq->secs_to_gc) * geo->csecs;
rqd.opcode = NVM_OP_PREAD; rqd.opcode = NVM_OP_PREAD;
rqd.nr_ppas = gc_rq->secs_to_gc; rqd.nr_ppas = gc_rq->secs_to_gc;

3
drivers/lightnvm/pblk-recovery.c
View file

@ -365,7 +365,7 @@ static int pblk_recov_scan_oob(struct pblk *pblk, struct pblk_line *line,
__le64 *lba_list; __le64 *lba_list;
u64 paddr = pblk_line_smeta_start(pblk, line) + lm->smeta_sec; u64 paddr = pblk_line_smeta_start(pblk, line) + lm->smeta_sec;
bool padded = false; bool padded = false;
int rq_ppas, rq_len; int rq_ppas;
int i, j; int i, j;
int ret; int ret;
u64 left_ppas = pblk_sec_in_open_line(pblk, line) - lm->smeta_sec; u64 left_ppas = pblk_sec_in_open_line(pblk, line) - lm->smeta_sec;
@ -388,7 +388,6 @@ static int pblk_recov_scan_oob(struct pblk *pblk, struct pblk_line *line,
rq_ppas = pblk_calc_secs(pblk, left_ppas, 0, false); rq_ppas = pblk_calc_secs(pblk, left_ppas, 0, false);
if (!rq_ppas) if (!rq_ppas)
rq_ppas = pblk->min_write_pgs; rq_ppas = pblk->min_write_pgs;
rq_len = rq_ppas * geo->csecs;
retry_rq: retry_rq:
rqd->bio = NULL; rqd->bio = NULL;