nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

net: cosa: fix error check return value of register_chrdev()

Browse source 
If major equal 0, register_chrdev() returns error code when it fails.
This function dynamically allocate a major and return its number on
success, so we should use "< 0" to check it instead of "!".

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
Acked-By: Jan "Yenya" Kasprzak <kas@fi.muni.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Lv Ruyi 2022-04-18 10:58:34 +00:00 committed by David S. Miller
parent 59f0c2447e
commit d48fea8401
1 changed files with 1 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/net/wan/cosa.c
View file

@ -349,7 +349,7 @@ static int __init cosa_init(void)
} }
} else { } else {
cosa_major = register_chrdev(0, "cosa", &cosa_fops); cosa_major = register_chrdev(0, "cosa", &cosa_fops);
if (!cosa_major) { if (cosa_major < 0) {
pr_warn("unable to register chardev\n"); pr_warn("unable to register chardev\n");
err = -EIO; err = -EIO;
goto out; goto out;