nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

net: bgmac: Return PTR_ERR() for fixed_phy_register()

Browse source 
fixed_phy_register() returns -EPROBE_DEFER, -EINVAL and -EBUSY,
etc, in addition to -ENODEV. The best practice is to return
these error codes with PTR_ERR().

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
This commit is contained in:
Ruan Jinjie 2023-08-18 15:07:05 +08:00 committed by David S. Miller
parent b22eef6864
commit d6499f0b7c
1 changed files with 1 additions and 1 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

2
drivers/net/ethernet/broadcom/bgmac.c
View file

@ -1450,7 +1450,7 @@ int bgmac_phy_connect_direct(struct bgmac *bgmac)
phy_dev = fixed_phy_register(PHY_POLL, &fphy_status, NULL); phy_dev = fixed_phy_register(PHY_POLL, &fphy_status, NULL);
if (!phy_dev || IS_ERR(phy_dev)) { if (!phy_dev || IS_ERR(phy_dev)) {
dev_err(bgmac->dev, "Failed to register fixed PHY device\n"); dev_err(bgmac->dev, "Failed to register fixed PHY device\n");
return -ENODEV; return PTR_ERR(phy_dev);
} }
err = phy_connect_direct(bgmac->net_dev, phy_dev, bgmac_adjust_link, err = phy_connect_direct(bgmac->net_dev, phy_dev, bgmac_adjust_link,