nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

platform/x86: thinkpad_acpi: Fix max_brightness of thinklight

Browse source 
Thinklight has only two values, on/off so it's reasonable for
max_brightness to be 0 and 1 as if you write anything between 0 and 255
it will be 255 anyway so there's no point for it to be 255.

This may look like it is a userspace API change, but writes with
a value larget then the new max_brightness will still be accepted,
these will be silently clamped to the new max_brightness by
led_set_brightness_nosleep(). So no userspace API problems are
expected.

Reported-by: Michał Szczepaniak <m.szczepaniak.000@gmail.com>
Link: https://lore.kernel.org/platform-driver-x86/55400326-e64f-5444-94e5-22b8214d00b6@gmail.com/
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
Hans de Goede 2022-11-07 13:43:22 +01:00
parent e57d58ee18
commit db5e2a4ca0
1 changed files with 1 additions and 0 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

1
drivers/platform/x86/thinkpad_acpi.c
View file

@ -5572,6 +5572,7 @@ static enum led_brightness light_sysfs_get(struct led_classdev *led_cdev)
static struct tpacpi_led_classdev tpacpi_led_thinklight = { static struct tpacpi_led_classdev tpacpi_led_thinklight = {
.led_classdev = { .led_classdev = {
.name = "tpacpi::thinklight", .name = "tpacpi::thinklight",
.max_brightness = 1,
.brightness_set_blocking = &light_sysfs_set, .brightness_set_blocking = &light_sysfs_set,
.brightness_get = &light_sysfs_get, .brightness_get = &light_sysfs_get,
} }