forked from mirrors/linux
		
	driver core: Set fw_devlink=on by default
Cyclic dependencies in some firmware was one of the last remaining reasons fw_devlink=on couldn't be set by default. Now that cyclic dependencies don't block probing, set fw_devlink=on by default. Setting fw_devlink=on by default brings a bunch of benefits (currently, only for systems with device tree firmware): * Significantly cuts down deferred probes. * Device probe is effectively attempted in graph order. * Makes it much easier to load drivers as modules without having to worry about functional dependencies between modules (depmod is still needed for symbol dependencies). If this patch prevents some devices from probing, it's very likely due to the system having one or more device drivers that "probe"/set up a device (DT node with compatible property) without creating a struct device for it. If we hit such cases, the device drivers need to be fixed so that they populate struct devices and probe them like normal device drivers so that the driver core is aware of the devices and their status. See [1] for an example of such a case. [1] - https://lore.kernel.org/lkml/CAGETcx9PiX==mLxB9PO8Myyk6u2vhPVwTMsA5NkD-ywH5xhusw@mail.gmail.com/ Signed-off-by: Saravana Kannan <saravanak@google.com> Link: https://lore.kernel.org/r/20201218031703.3053753-6-saravanak@google.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
		
							parent
							
								
									c13b827927
								
							
						
					
					
						commit
						e590474768
					
				
					 1 changed files with 1 additions and 1 deletions
				
			
		|  | @ -1457,7 +1457,7 @@ static void device_links_purge(struct device *dev) | |||
| #define FW_DEVLINK_FLAGS_RPM		(FW_DEVLINK_FLAGS_ON | \ | ||||
| 					 DL_FLAG_PM_RUNTIME) | ||||
| 
 | ||||
| static u32 fw_devlink_flags = FW_DEVLINK_FLAGS_PERMISSIVE; | ||||
| static u32 fw_devlink_flags = FW_DEVLINK_FLAGS_ON; | ||||
| static int __init fw_devlink_setup(char *arg) | ||||
| { | ||||
| 	if (!arg) | ||||
|  |  | |||
		Loading…
	
		Reference in a new issue
	
	 Saravana Kannan
						Saravana Kannan