nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

crypto: rng - Fix a refcounting bug in crypto_rng_reset()

Browse source 
We need to decrement this refcounter on these error paths.

Fixes: f7d76e05d0 ("crypto: user - fix use_after_free of struct xxx_request")
Cc: <stable@vger.kernel.org>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
This commit is contained in:
Dan Carpenter 2020-01-20 17:38:04 +03:00 committed by Herbert Xu
parent 00e62e868c
commit eed74b3eba
1 changed files with 6 additions and 2 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

8
crypto/rng.c
View file

@ -37,12 +37,16 @@ int crypto_rng_reset(struct crypto_rng *tfm, const u8 *seed, unsigned int slen)
crypto_stats_get(alg); crypto_stats_get(alg);
if (!seed && slen) { if (!seed && slen) {
buf = kmalloc(slen, GFP_KERNEL); buf = kmalloc(slen, GFP_KERNEL);
if (!buf) if (!buf) {
crypto_alg_put(alg);
return -ENOMEM; return -ENOMEM;
}
err = get_random_bytes_wait(buf, slen); err = get_random_bytes_wait(buf, slen);
if (err) if (err) {
crypto_alg_put(alg);
goto out; goto out;
}
seed = buf; seed = buf;
} }