nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

zsmalloc: remove unnecessary size_class NULL check

Browse source 
pool->size_class array elements can't be NULL, so this check
is not needed.

In the whole code, we assign pool->size_class[i] values that are
not NULL. Releasing memory for these values occurs in the
zs_destroy_pool() function, which also releases and destroys the pool.

In addition, in the zs_stats_size_show() and async_free_zspage(),
with similar iterations over the array, we don't check it for NULL
pointer.

Link: https://lkml.kernel.org/r/20220811153755.16102-3-avromanov@sberdevices.ru
Signed-off-by: Alexey Romanov <avromanov@sberdevices.ru>
Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Nitin Gupta <ngupta@vflare.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
This commit is contained in:
Alexey Romanov 2022-08-11 18:37:55 +03:00 committed by Andrew Morton
parent 050a388b7f
commit f24263a5a0
1 changed files with 0 additions and 7 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

7
mm/zsmalloc.c
View file

@ -2110,8 +2110,6 @@ unsigned long zs_compact(struct zs_pool *pool)
for (i = ZS_SIZE_CLASSES - 1; i >= 0; i--) { for (i = ZS_SIZE_CLASSES - 1; i >= 0; i--) {
class = pool->size_class[i]; class = pool->size_class[i];
if (!class)
continue;
if (class->index != i) if (class->index != i)
continue; continue;
pages_freed += __zs_compact(pool, class); pages_freed += __zs_compact(pool, class);
@ -2156,8 +2154,6 @@ static unsigned long zs_shrinker_count(struct shrinker *shrinker,
for (i = ZS_SIZE_CLASSES - 1; i >= 0; i--) { for (i = ZS_SIZE_CLASSES - 1; i >= 0; i--) {
class = pool->size_class[i]; class = pool->size_class[i];
if (!class)
continue;
if (class->index != i) if (class->index != i)
continue; continue;
@ -2315,9 +2311,6 @@ void zs_destroy_pool(struct zs_pool *pool)
int fg; int fg;
struct size_class *class = pool->size_class[i]; struct size_class *class = pool->size_class[i];
if (!class)
continue;
if (class->index != i) if (class->index != i)
continue; continue;