nagai/kernel
3
0
Fork 0
forked from mirrors/linux
Code Pull requests Activity

dmaengine: stm32-dma: use platform_get_irq()

Browse source 
platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
requesting IRQ's resources, as they can be not ready yet. Using
platform_get_irq() instead is preferred for getting IRQ even if it was
not retrieved earlier.

Signed-off-by: Fabien Dessenne <fabien.dessenne@st.com>
Reviewed-by: Pierre-Yves MORDRET <pierre-yves.mordret@st.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
This commit is contained in:
Fabien Dessenne 2019-04-24 11:21:25 +02:00 committed by Vinod Koul
parent 8a6061c34a
commit f4fd2ec08f
1 changed files with 6 additions and 5 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

11
drivers/dma/stm32-dma.c
View file

@ -1302,13 +1302,14 @@ static int stm32_dma_probe(struct platform_device *pdev)
for (i = 0; i < STM32_DMA_MAX_CHANNELS; i++) { for (i = 0; i < STM32_DMA_MAX_CHANNELS; i++) {
chan = &dmadev->chan[i]; chan = &dmadev->chan[i];
res = platform_get_resource(pdev, IORESOURCE_IRQ, i); chan->irq = platform_get_irq(pdev, i);
if (!res) { if (chan->irq < 0) {
ret = -EINVAL; ret = chan->irq;
dev_err(&pdev->dev, "No irq resource for chan %d\n", i); if (ret != -EPROBE_DEFER)
dev_err(&pdev->dev,
"No irq resource for chan %d\n", i);
goto err_unregister; goto err_unregister;
} }
chan->irq = res->start;
ret = devm_request_irq(&pdev->dev, chan->irq, ret = devm_request_irq(&pdev->dev, chan->irq,
stm32_dma_chan_irq, 0, stm32_dma_chan_irq, 0,
dev_name(chan2dev(chan)), chan); dev_name(chan2dev(chan)), chan);