forked from mirrors/linux
		
	drm/bridge: analogix_dp: Fix clk-disable removal
Commit6579a03e68("drm/bridge: analogix_dp: Remove the unnecessary calls to clk_disable_unprepare() during probing") removed the mismatched clock_disable calls from analogix_dp_probe. But that patch was created and sent before commite5e9fa9f7a("drm/bridge: analogix_dp: Add support to get panel from the DP AUX bus") was merged, so couldn't know about this change. So in the original patch the last change is if (ret) { dev_err(&pdev->dev, "failed to request irq\n"); - goto err_disable_clk; + return ERR_PTR(ret); } disable_irq(dp->irq); return dp; - -err_disable_clk: - clk_disable_unprepare(dp->clock); - return ERR_PTR(ret); } EXPORT_SYMBOL_GPL(analogix_dp_probe); the analogix_dp_core.c actually now has the runtime-pm handling between disable_irq() and return do introducing another goto err_clk_disable there. So remove that one too and return an error pointer, to not create build breakage. Fixes:6579a03e68("drm/bridge: analogix_dp: Remove the unnecessary calls to clk_disable_unprepare() during probing") Signed-off-by: Heiko Stuebner <heiko@sntech.de> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> Link: https://lore.kernel.org/r/20250527225120.3361663-1-heiko@sntech.de Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
This commit is contained in:
		
							parent
							
								
									6579a03e68
								
							
						
					
					
						commit
						fd03f82a02
					
				
					 1 changed files with 1 additions and 1 deletions
				
			
		|  | @ -1586,7 +1586,7 @@ analogix_dp_probe(struct device *dev, struct analogix_dp_plat_data *plat_data) | ||||||
| 	pm_runtime_set_autosuspend_delay(dp->dev, 100); | 	pm_runtime_set_autosuspend_delay(dp->dev, 100); | ||||||
| 	ret = devm_pm_runtime_enable(dp->dev); | 	ret = devm_pm_runtime_enable(dp->dev); | ||||||
| 	if (ret) | 	if (ret) | ||||||
| 		goto err_disable_clk; | 		return ERR_PTR(ret); | ||||||
| 
 | 
 | ||||||
| 	return dp; | 	return dp; | ||||||
| } | } | ||||||
|  |  | ||||||
		Loading…
	
		Reference in a new issue
	
	 Heiko Stuebner
						Heiko Stuebner