forked from mirrors/linux
		
	 a090931524
			
		
	
	
		a090931524
		
	
	
	
	
		
			
			Read a record is cleared by others, but the deleted record cache entry is still created by erst_get_record_id_next. When next enumerate the records, get the cached deleted record, then erst_read() return -ENOENT and try to get next record, loop back to first ID will return 0 in function __erst_record_id_cache_add_one and then set record_id as APEI_ERST_INVALID_RECORD_ID, finished this time read operation. It will result in read the records just in the cache hereafter. This patch cleared the deleted record cache, fix the issue that "./erst-inject -p" shows record counts not equal to "./erst-inject -n". A reproducer of the problem(retry many times): [root@localhost erst-inject]# ./erst-inject -c 0xaaaaa00011 [root@localhost erst-inject]# ./erst-inject -p rc: 273 rcd sig: CPER rcd id: 0xaaaaa00012 rc: 273 rcd sig: CPER rcd id: 0xaaaaa00013 rc: 273 rcd sig: CPER rcd id: 0xaaaaa00014 [root@localhost erst-inject]# ./erst-inject -i 0xaaaaa000006 [root@localhost erst-inject]# ./erst-inject -i 0xaaaaa000007 [root@localhost erst-inject]# ./erst-inject -i 0xaaaaa000008 [root@localhost erst-inject]# ./erst-inject -p rc: 273 rcd sig: CPER rcd id: 0xaaaaa00012 rc: 273 rcd sig: CPER rcd id: 0xaaaaa00013 rc: 273 rcd sig: CPER rcd id: 0xaaaaa00014 [root@localhost erst-inject]# ./erst-inject -n total error record count: 6 Signed-off-by: Liu Xinpeng <liuxp11@chinatelecom.cn> Reviewed-by: Tony Luck <tony.luck@intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
		
			
				
	
	
		
			57 lines
		
	
	
	
		
			1.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			57 lines
		
	
	
	
		
			1.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /* SPDX-License-Identifier: GPL-2.0 */
 | |
| /*
 | |
|  * apei.h - ACPI Platform Error Interface
 | |
|  */
 | |
| 
 | |
| #ifndef ACPI_APEI_H
 | |
| #define ACPI_APEI_H
 | |
| 
 | |
| #include <linux/acpi.h>
 | |
| #include <linux/cper.h>
 | |
| #include <asm/ioctls.h>
 | |
| 
 | |
| #define APEI_ERST_INVALID_RECORD_ID	0xffffffffffffffffULL
 | |
| 
 | |
| #define APEI_ERST_CLEAR_RECORD		_IOW('E', 1, u64)
 | |
| #define APEI_ERST_GET_RECORD_COUNT	_IOR('E', 2, u32)
 | |
| 
 | |
| #ifdef __KERNEL__
 | |
| 
 | |
| enum hest_status {
 | |
| 	HEST_ENABLED,
 | |
| 	HEST_DISABLED,
 | |
| 	HEST_NOT_FOUND,
 | |
| };
 | |
| 
 | |
| extern int hest_disable;
 | |
| extern int erst_disable;
 | |
| #ifdef CONFIG_ACPI_APEI_GHES
 | |
| extern bool ghes_disable;
 | |
| void __init acpi_ghes_init(void);
 | |
| #else
 | |
| #define ghes_disable 1
 | |
| static inline void acpi_ghes_init(void) { }
 | |
| #endif
 | |
| 
 | |
| #ifdef CONFIG_ACPI_APEI
 | |
| void __init acpi_hest_init(void);
 | |
| #else
 | |
| static inline void acpi_hest_init(void) { }
 | |
| #endif
 | |
| 
 | |
| int erst_write(const struct cper_record_header *record);
 | |
| ssize_t erst_get_record_count(void);
 | |
| int erst_get_record_id_begin(int *pos);
 | |
| int erst_get_record_id_next(int *pos, u64 *record_id);
 | |
| void erst_get_record_id_end(void);
 | |
| ssize_t erst_read(u64 record_id, struct cper_record_header *record,
 | |
| 		  size_t buflen);
 | |
| ssize_t erst_read_record(u64 record_id, struct cper_record_header *record,
 | |
| 		size_t buflen, size_t recordlen, const guid_t *creatorid);
 | |
| int erst_clear(u64 record_id);
 | |
| 
 | |
| int arch_apei_enable_cmcff(struct acpi_hest_header *hest_hdr, void *data);
 | |
| void arch_apei_report_mem_error(int sev, struct cper_sec_mem_err *mem_err);
 | |
| 
 | |
| #endif
 | |
| #endif
 |