forked from mirrors/linux
		
	omap_fbdev_init() and omap_fbdev_free() use priv->fbdev directly. However, omap_fbdev_init() returns the fbdev, and omap_drv.c also assigns the return value to priv->fbdev. This is slightly confusing. Clean this up by removing the omap_fbdev_init() return value, as we don't care whether fbdev init succeeded or not. Also change omap_drv.c to call omap_fbdev_free() always, and omap_fbdev_free() does the check if fbdev was initialized. While at it, rename omap_fbdev_free() to omap_fbdev_fini() to better match the "init" counterpart. Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
		
			
				
	
	
		
			38 lines
		
	
	
	
		
			1.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			38 lines
		
	
	
	
		
			1.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * omap_fbdev.h -- OMAP DRM FBDEV Compatibility
 | 
						|
 *
 | 
						|
 * Copyright (C) 2011 Texas Instruments
 | 
						|
 * Author: Rob Clark <rob@ti.com>
 | 
						|
 *
 | 
						|
 * This program is free software; you can redistribute it and/or modify it
 | 
						|
 * under the terms of the GNU General Public License version 2 as published by
 | 
						|
 * the Free Software Foundation.
 | 
						|
 *
 | 
						|
 * This program is distributed in the hope that it will be useful, but WITHOUT
 | 
						|
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 | 
						|
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 | 
						|
 * more details.
 | 
						|
 *
 | 
						|
 * You should have received a copy of the GNU General Public License along with
 | 
						|
 * this program.  If not, see <http://www.gnu.org/licenses/>.
 | 
						|
 */
 | 
						|
 | 
						|
#ifndef __OMAPDRM_FBDEV_H__
 | 
						|
#define __OMAPDRM_FBDEV_H__
 | 
						|
 | 
						|
struct drm_device;
 | 
						|
struct drm_fb_helper;
 | 
						|
 | 
						|
#ifdef CONFIG_DRM_FBDEV_EMULATION
 | 
						|
void omap_fbdev_init(struct drm_device *dev);
 | 
						|
void omap_fbdev_fini(struct drm_device *dev);
 | 
						|
#else
 | 
						|
static inline void omap_fbdev_init(struct drm_device *dev)
 | 
						|
{
 | 
						|
}
 | 
						|
static inline void omap_fbdev_fini(struct drm_device *dev)
 | 
						|
{
 | 
						|
}
 | 
						|
#endif
 | 
						|
 | 
						|
#endif /* __OMAPDRM_FBDEV_H__ */
 |