forked from mirrors/linux
		
	Planes with identical zpos value will result undefined behavior: disappearing planes, screen flickering and it is not supported by the hardware. Use normalized zpos to make sure that we don't encounter invalid configuration. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> CC: Tomi Valkeinen <tomi.valkeinen@ti.com> Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> Link: https://patchwork.freedesktop.org/patch/msgid/20180321102029.15248-7-peter.ujfalusi@ti.com
		
			
				
	
	
		
			308 lines
		
	
	
	
		
			8.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			308 lines
		
	
	
	
		
			8.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com/
 | 
						|
 * Author: Rob Clark <rob.clark@linaro.org>
 | 
						|
 *
 | 
						|
 * This program is free software; you can redistribute it and/or modify it
 | 
						|
 * under the terms of the GNU General Public License version 2 as published by
 | 
						|
 * the Free Software Foundation.
 | 
						|
 *
 | 
						|
 * This program is distributed in the hope that it will be useful, but WITHOUT
 | 
						|
 * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or
 | 
						|
 * FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
 | 
						|
 * more details.
 | 
						|
 *
 | 
						|
 * You should have received a copy of the GNU General Public License along with
 | 
						|
 * this program.  If not, see <http://www.gnu.org/licenses/>.
 | 
						|
 */
 | 
						|
 | 
						|
#include <drm/drm_atomic.h>
 | 
						|
#include <drm/drm_atomic_helper.h>
 | 
						|
#include <drm/drm_plane_helper.h>
 | 
						|
 | 
						|
#include "omap_dmm_tiler.h"
 | 
						|
#include "omap_drv.h"
 | 
						|
 | 
						|
/*
 | 
						|
 * plane funcs
 | 
						|
 */
 | 
						|
 | 
						|
#define to_omap_plane(x) container_of(x, struct omap_plane, base)
 | 
						|
 | 
						|
struct omap_plane {
 | 
						|
	struct drm_plane base;
 | 
						|
	enum omap_plane_id id;
 | 
						|
	const char *name;
 | 
						|
};
 | 
						|
 | 
						|
static int omap_plane_prepare_fb(struct drm_plane *plane,
 | 
						|
				 struct drm_plane_state *new_state)
 | 
						|
{
 | 
						|
	if (!new_state->fb)
 | 
						|
		return 0;
 | 
						|
 | 
						|
	return omap_framebuffer_pin(new_state->fb);
 | 
						|
}
 | 
						|
 | 
						|
static void omap_plane_cleanup_fb(struct drm_plane *plane,
 | 
						|
				  struct drm_plane_state *old_state)
 | 
						|
{
 | 
						|
	if (old_state->fb)
 | 
						|
		omap_framebuffer_unpin(old_state->fb);
 | 
						|
}
 | 
						|
 | 
						|
static void omap_plane_atomic_update(struct drm_plane *plane,
 | 
						|
				     struct drm_plane_state *old_state)
 | 
						|
{
 | 
						|
	struct omap_drm_private *priv = plane->dev->dev_private;
 | 
						|
	struct omap_plane *omap_plane = to_omap_plane(plane);
 | 
						|
	struct drm_plane_state *state = plane->state;
 | 
						|
	struct omap_overlay_info info;
 | 
						|
	int ret;
 | 
						|
 | 
						|
	DBG("%s, crtc=%p fb=%p", omap_plane->name, state->crtc, state->fb);
 | 
						|
 | 
						|
	memset(&info, 0, sizeof(info));
 | 
						|
	info.rotation_type = OMAP_DSS_ROT_NONE;
 | 
						|
	info.rotation = DRM_MODE_ROTATE_0;
 | 
						|
	info.global_alpha = 0xff;
 | 
						|
	info.zorder = state->normalized_zpos;
 | 
						|
 | 
						|
	/* update scanout: */
 | 
						|
	omap_framebuffer_update_scanout(state->fb, state, &info);
 | 
						|
 | 
						|
	DBG("%dx%d -> %dx%d (%d)", info.width, info.height,
 | 
						|
			info.out_width, info.out_height,
 | 
						|
			info.screen_width);
 | 
						|
	DBG("%d,%d %pad %pad", info.pos_x, info.pos_y,
 | 
						|
			&info.paddr, &info.p_uv_addr);
 | 
						|
 | 
						|
	/* and finally, update omapdss: */
 | 
						|
	ret = priv->dispc_ops->ovl_setup(priv->dispc, omap_plane->id, &info,
 | 
						|
			      omap_crtc_timings(state->crtc), false,
 | 
						|
			      omap_crtc_channel(state->crtc));
 | 
						|
	if (ret) {
 | 
						|
		dev_err(plane->dev->dev, "Failed to setup plane %s\n",
 | 
						|
			omap_plane->name);
 | 
						|
		priv->dispc_ops->ovl_enable(priv->dispc, omap_plane->id, false);
 | 
						|
		return;
 | 
						|
	}
 | 
						|
 | 
						|
	priv->dispc_ops->ovl_enable(priv->dispc, omap_plane->id, true);
 | 
						|
}
 | 
						|
 | 
						|
static void omap_plane_atomic_disable(struct drm_plane *plane,
 | 
						|
				      struct drm_plane_state *old_state)
 | 
						|
{
 | 
						|
	struct omap_drm_private *priv = plane->dev->dev_private;
 | 
						|
	struct omap_plane *omap_plane = to_omap_plane(plane);
 | 
						|
 | 
						|
	plane->state->rotation = DRM_MODE_ROTATE_0;
 | 
						|
	plane->state->zpos = plane->type == DRM_PLANE_TYPE_PRIMARY
 | 
						|
			   ? 0 : omap_plane->id;
 | 
						|
 | 
						|
	priv->dispc_ops->ovl_enable(priv->dispc, omap_plane->id, false);
 | 
						|
}
 | 
						|
 | 
						|
static int omap_plane_atomic_check(struct drm_plane *plane,
 | 
						|
				   struct drm_plane_state *state)
 | 
						|
{
 | 
						|
	struct drm_crtc_state *crtc_state;
 | 
						|
 | 
						|
	if (!state->fb)
 | 
						|
		return 0;
 | 
						|
 | 
						|
	/* crtc should only be NULL when disabling (i.e., !state->fb) */
 | 
						|
	if (WARN_ON(!state->crtc))
 | 
						|
		return 0;
 | 
						|
 | 
						|
	crtc_state = drm_atomic_get_existing_crtc_state(state->state, state->crtc);
 | 
						|
	/* we should have a crtc state if the plane is attached to a crtc */
 | 
						|
	if (WARN_ON(!crtc_state))
 | 
						|
		return 0;
 | 
						|
 | 
						|
	if (!crtc_state->enable)
 | 
						|
		return 0;
 | 
						|
 | 
						|
	if (state->crtc_x < 0 || state->crtc_y < 0)
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	if (state->crtc_x + state->crtc_w > crtc_state->adjusted_mode.hdisplay)
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	if (state->crtc_y + state->crtc_h > crtc_state->adjusted_mode.vdisplay)
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	if (state->rotation != DRM_MODE_ROTATE_0 &&
 | 
						|
	    !omap_framebuffer_supports_rotation(state->fb))
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static const struct drm_plane_helper_funcs omap_plane_helper_funcs = {
 | 
						|
	.prepare_fb = omap_plane_prepare_fb,
 | 
						|
	.cleanup_fb = omap_plane_cleanup_fb,
 | 
						|
	.atomic_check = omap_plane_atomic_check,
 | 
						|
	.atomic_update = omap_plane_atomic_update,
 | 
						|
	.atomic_disable = omap_plane_atomic_disable,
 | 
						|
};
 | 
						|
 | 
						|
static void omap_plane_destroy(struct drm_plane *plane)
 | 
						|
{
 | 
						|
	struct omap_plane *omap_plane = to_omap_plane(plane);
 | 
						|
 | 
						|
	DBG("%s", omap_plane->name);
 | 
						|
 | 
						|
	drm_plane_cleanup(plane);
 | 
						|
 | 
						|
	kfree(omap_plane);
 | 
						|
}
 | 
						|
 | 
						|
/* helper to install properties which are common to planes and crtcs */
 | 
						|
void omap_plane_install_properties(struct drm_plane *plane,
 | 
						|
		struct drm_mode_object *obj)
 | 
						|
{
 | 
						|
	struct drm_device *dev = plane->dev;
 | 
						|
	struct omap_drm_private *priv = dev->dev_private;
 | 
						|
 | 
						|
	if (priv->has_dmm) {
 | 
						|
		if (!plane->rotation_property)
 | 
						|
			drm_plane_create_rotation_property(plane,
 | 
						|
							   DRM_MODE_ROTATE_0,
 | 
						|
							   DRM_MODE_ROTATE_0 | DRM_MODE_ROTATE_90 |
 | 
						|
							   DRM_MODE_ROTATE_180 | DRM_MODE_ROTATE_270 |
 | 
						|
							   DRM_MODE_REFLECT_X | DRM_MODE_REFLECT_Y);
 | 
						|
 | 
						|
		/* Attach the rotation property also to the crtc object */
 | 
						|
		if (plane->rotation_property && obj != &plane->base)
 | 
						|
			drm_object_attach_property(obj, plane->rotation_property,
 | 
						|
						   DRM_MODE_ROTATE_0);
 | 
						|
	}
 | 
						|
 | 
						|
	drm_object_attach_property(obj, priv->zorder_prop, 0);
 | 
						|
}
 | 
						|
 | 
						|
static void omap_plane_reset(struct drm_plane *plane)
 | 
						|
{
 | 
						|
	struct omap_plane *omap_plane = to_omap_plane(plane);
 | 
						|
 | 
						|
	drm_atomic_helper_plane_reset(plane);
 | 
						|
	if (!plane->state)
 | 
						|
		return;
 | 
						|
 | 
						|
	/*
 | 
						|
	 * Set the zpos default depending on whether we are a primary or overlay
 | 
						|
	 * plane.
 | 
						|
	 */
 | 
						|
	plane->state->zpos = plane->type == DRM_PLANE_TYPE_PRIMARY
 | 
						|
			   ? 0 : omap_plane->id;
 | 
						|
}
 | 
						|
 | 
						|
static int omap_plane_atomic_set_property(struct drm_plane *plane,
 | 
						|
					  struct drm_plane_state *state,
 | 
						|
					  struct drm_property *property,
 | 
						|
					  u64 val)
 | 
						|
{
 | 
						|
	struct omap_drm_private *priv = plane->dev->dev_private;
 | 
						|
 | 
						|
	if (property == priv->zorder_prop)
 | 
						|
		state->zpos = val;
 | 
						|
	else
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static int omap_plane_atomic_get_property(struct drm_plane *plane,
 | 
						|
					  const struct drm_plane_state *state,
 | 
						|
					  struct drm_property *property,
 | 
						|
					  u64 *val)
 | 
						|
{
 | 
						|
	struct omap_drm_private *priv = plane->dev->dev_private;
 | 
						|
 | 
						|
	if (property == priv->zorder_prop)
 | 
						|
		*val = state->zpos;
 | 
						|
	else
 | 
						|
		return -EINVAL;
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static const struct drm_plane_funcs omap_plane_funcs = {
 | 
						|
	.update_plane = drm_atomic_helper_update_plane,
 | 
						|
	.disable_plane = drm_atomic_helper_disable_plane,
 | 
						|
	.reset = omap_plane_reset,
 | 
						|
	.destroy = omap_plane_destroy,
 | 
						|
	.atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state,
 | 
						|
	.atomic_destroy_state = drm_atomic_helper_plane_destroy_state,
 | 
						|
	.atomic_set_property = omap_plane_atomic_set_property,
 | 
						|
	.atomic_get_property = omap_plane_atomic_get_property,
 | 
						|
};
 | 
						|
 | 
						|
static const char *plane_id_to_name[] = {
 | 
						|
	[OMAP_DSS_GFX] = "gfx",
 | 
						|
	[OMAP_DSS_VIDEO1] = "vid1",
 | 
						|
	[OMAP_DSS_VIDEO2] = "vid2",
 | 
						|
	[OMAP_DSS_VIDEO3] = "vid3",
 | 
						|
};
 | 
						|
 | 
						|
static const enum omap_plane_id plane_idx_to_id[] = {
 | 
						|
	OMAP_DSS_GFX,
 | 
						|
	OMAP_DSS_VIDEO1,
 | 
						|
	OMAP_DSS_VIDEO2,
 | 
						|
	OMAP_DSS_VIDEO3,
 | 
						|
};
 | 
						|
 | 
						|
/* initialize plane */
 | 
						|
struct drm_plane *omap_plane_init(struct drm_device *dev,
 | 
						|
		int idx, enum drm_plane_type type,
 | 
						|
		u32 possible_crtcs)
 | 
						|
{
 | 
						|
	struct omap_drm_private *priv = dev->dev_private;
 | 
						|
	unsigned int num_planes = priv->dispc_ops->get_num_ovls(priv->dispc);
 | 
						|
	struct drm_plane *plane;
 | 
						|
	struct omap_plane *omap_plane;
 | 
						|
	enum omap_plane_id id;
 | 
						|
	int ret;
 | 
						|
	u32 nformats;
 | 
						|
	const u32 *formats;
 | 
						|
 | 
						|
	if (WARN_ON(idx >= ARRAY_SIZE(plane_idx_to_id)))
 | 
						|
		return ERR_PTR(-EINVAL);
 | 
						|
 | 
						|
	id = plane_idx_to_id[idx];
 | 
						|
 | 
						|
	DBG("%s: type=%d", plane_id_to_name[id], type);
 | 
						|
 | 
						|
	omap_plane = kzalloc(sizeof(*omap_plane), GFP_KERNEL);
 | 
						|
	if (!omap_plane)
 | 
						|
		return ERR_PTR(-ENOMEM);
 | 
						|
 | 
						|
	formats = priv->dispc_ops->ovl_get_color_modes(priv->dispc, id);
 | 
						|
	for (nformats = 0; formats[nformats]; ++nformats)
 | 
						|
		;
 | 
						|
	omap_plane->id = id;
 | 
						|
	omap_plane->name = plane_id_to_name[id];
 | 
						|
 | 
						|
	plane = &omap_plane->base;
 | 
						|
 | 
						|
	ret = drm_universal_plane_init(dev, plane, possible_crtcs,
 | 
						|
				       &omap_plane_funcs, formats,
 | 
						|
				       nformats, NULL, type, NULL);
 | 
						|
	if (ret < 0)
 | 
						|
		goto error;
 | 
						|
 | 
						|
	drm_plane_helper_add(plane, &omap_plane_helper_funcs);
 | 
						|
 | 
						|
	omap_plane_install_properties(plane, &plane->base);
 | 
						|
	drm_plane_create_zpos_property(plane, 0, 0, num_planes - 1);
 | 
						|
 | 
						|
	return plane;
 | 
						|
 | 
						|
error:
 | 
						|
	dev_err(dev->dev, "%s(): could not create plane: %s\n",
 | 
						|
		__func__, plane_id_to_name[id]);
 | 
						|
 | 
						|
	kfree(omap_plane);
 | 
						|
	return NULL;
 | 
						|
}
 |