forked from mirrors/linux
		
	Cleanup commit73679e5082("compiler-intel.h: Remove duplicate definition") removed the double definition of __memory_barrier() intrinsics. However, in doing so, it also removed the preceding #undef barrier by accident, meaning, the actual barrier() macro from compiler-gcc.h with inline asm is still in place as __GNUC__ is provided. Subsequently, barrier() can never be defined as __memory_barrier() from compiler.h since it already has a definition in place and if we trust the comment in compiler-intel.h, ecc doesn't support gcc specific asm statements. I don't have an ecc at hand (unsure if that's still used in the field?) and only found this by accident during code review, a revert of that cleanup would be simplest option. Fixes:73679e5082("compiler-intel.h: Remove duplicate definition") Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Reviewed-by: Pranith Kumar <bobby.prani@gmail.com> Cc: Pranith Kumar <bobby.prani@gmail.com> Cc: H. Peter Anvin <hpa@zytor.com> Cc: mancha security <mancha1@zoho.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
		
			
				
	
	
		
			45 lines
		
	
	
	
		
			1.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			45 lines
		
	
	
	
		
			1.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
#ifndef __LINUX_COMPILER_H
 | 
						|
#error "Please don't include <linux/compiler-intel.h> directly, include <linux/compiler.h> instead."
 | 
						|
#endif
 | 
						|
 | 
						|
#ifdef __ECC
 | 
						|
 | 
						|
/* Some compiler specific definitions are overwritten here
 | 
						|
 * for Intel ECC compiler
 | 
						|
 */
 | 
						|
 | 
						|
#include <asm/intrinsics.h>
 | 
						|
 | 
						|
/* Intel ECC compiler doesn't support gcc specific asm stmts.
 | 
						|
 * It uses intrinsics to do the equivalent things.
 | 
						|
 */
 | 
						|
#undef barrier
 | 
						|
#undef barrier_data
 | 
						|
#undef RELOC_HIDE
 | 
						|
#undef OPTIMIZER_HIDE_VAR
 | 
						|
 | 
						|
#define barrier() __memory_barrier()
 | 
						|
#define barrier_data(ptr) barrier()
 | 
						|
 | 
						|
#define RELOC_HIDE(ptr, off)					\
 | 
						|
  ({ unsigned long __ptr;					\
 | 
						|
     __ptr = (unsigned long) (ptr);				\
 | 
						|
    (typeof(ptr)) (__ptr + (off)); })
 | 
						|
 | 
						|
/* This should act as an optimization barrier on var.
 | 
						|
 * Given that this compiler does not have inline assembly, a compiler barrier
 | 
						|
 * is the best we can do.
 | 
						|
 */
 | 
						|
#define OPTIMIZER_HIDE_VAR(var) barrier()
 | 
						|
 | 
						|
/* Intel ECC compiler doesn't support __builtin_types_compatible_p() */
 | 
						|
#define __must_be_array(a) 0
 | 
						|
 | 
						|
#endif
 | 
						|
 | 
						|
#ifndef __HAVE_BUILTIN_BSWAP16__
 | 
						|
/* icc has this, but it's called _bswap16 */
 | 
						|
#define __HAVE_BUILTIN_BSWAP16__
 | 
						|
#define __builtin_bswap16 _bswap16
 | 
						|
#endif
 | 
						|
 |