forked from mirrors/linux
		
	The name for a bdi of a gendisk is derived from the gendisk's devt. However, since the gendisk is destroyed before the bdi it leaves a window where a new gendisk could dynamically reuse the same devt while a bdi with the same name is still live. Arrange for the bdi to hold a reference against its "owner" disk device while it is registered. Otherwise we can hit sysfs duplicate name collisions like the following: WARNING: CPU: 10 PID: 2078 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x64/0x80 sysfs: cannot create duplicate filename '/devices/virtual/bdi/259:1' Hardware name: HP ProLiant DL580 Gen8, BIOS P79 05/06/2015 0000000000000286 0000000002c04ad5 ffff88006f24f970 ffffffff8134caec ffff88006f24f9c0 0000000000000000 ffff88006f24f9b0 ffffffff8108c351 0000001f0000000c ffff88105d236000 ffff88105d1031e0 ffff8800357427f8 Call Trace: [<ffffffff8134caec>] dump_stack+0x63/0x87 [<ffffffff8108c351>] __warn+0xd1/0xf0 [<ffffffff8108c3cf>] warn_slowpath_fmt+0x5f/0x80 [<ffffffff812a0d34>] sysfs_warn_dup+0x64/0x80 [<ffffffff812a0e1e>] sysfs_create_dir_ns+0x7e/0x90 [<ffffffff8134faaa>] kobject_add_internal+0xaa/0x320 [<ffffffff81358d4e>] ? vsnprintf+0x34e/0x4d0 [<ffffffff8134ff55>] kobject_add+0x75/0xd0 [<ffffffff816e66b2>] ? mutex_lock+0x12/0x2f [<ffffffff8148b0a5>] device_add+0x125/0x610 [<ffffffff8148b788>] device_create_groups_vargs+0xd8/0x100 [<ffffffff8148b7cc>] device_create_vargs+0x1c/0x20 [<ffffffff811b775c>] bdi_register+0x8c/0x180 [<ffffffff811b7877>] bdi_register_dev+0x27/0x30 [<ffffffff813317f5>] add_disk+0x175/0x4a0 Cc: <stable@vger.kernel.org> Reported-by: Yi Zhang <yizhan@redhat.com> Tested-by: Yi Zhang <yizhan@redhat.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> Fixed up missing 0 return in bdi_register_owner(). Signed-off-by: Jens Axboe <axboe@fb.com>
		
			
				
	
	
		
			260 lines
		
	
	
	
		
			7.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			260 lines
		
	
	
	
		
			7.4 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
#ifndef __LINUX_BACKING_DEV_DEFS_H
 | 
						|
#define __LINUX_BACKING_DEV_DEFS_H
 | 
						|
 | 
						|
#include <linux/list.h>
 | 
						|
#include <linux/radix-tree.h>
 | 
						|
#include <linux/rbtree.h>
 | 
						|
#include <linux/spinlock.h>
 | 
						|
#include <linux/percpu_counter.h>
 | 
						|
#include <linux/percpu-refcount.h>
 | 
						|
#include <linux/flex_proportions.h>
 | 
						|
#include <linux/timer.h>
 | 
						|
#include <linux/workqueue.h>
 | 
						|
 | 
						|
struct page;
 | 
						|
struct device;
 | 
						|
struct dentry;
 | 
						|
 | 
						|
/*
 | 
						|
 * Bits in bdi_writeback.state
 | 
						|
 */
 | 
						|
enum wb_state {
 | 
						|
	WB_registered,		/* bdi_register() was done */
 | 
						|
	WB_writeback_running,	/* Writeback is in progress */
 | 
						|
	WB_has_dirty_io,	/* Dirty inodes on ->b_{dirty|io|more_io} */
 | 
						|
};
 | 
						|
 | 
						|
enum wb_congested_state {
 | 
						|
	WB_async_congested,	/* The async (write) queue is getting full */
 | 
						|
	WB_sync_congested,	/* The sync queue is getting full */
 | 
						|
};
 | 
						|
 | 
						|
typedef int (congested_fn)(void *, int);
 | 
						|
 | 
						|
enum wb_stat_item {
 | 
						|
	WB_RECLAIMABLE,
 | 
						|
	WB_WRITEBACK,
 | 
						|
	WB_DIRTIED,
 | 
						|
	WB_WRITTEN,
 | 
						|
	NR_WB_STAT_ITEMS
 | 
						|
};
 | 
						|
 | 
						|
#define WB_STAT_BATCH (8*(1+ilog2(nr_cpu_ids)))
 | 
						|
 | 
						|
/*
 | 
						|
 * For cgroup writeback, multiple wb's may map to the same blkcg.  Those
 | 
						|
 * wb's can operate mostly independently but should share the congested
 | 
						|
 * state.  To facilitate such sharing, the congested state is tracked using
 | 
						|
 * the following struct which is created on demand, indexed by blkcg ID on
 | 
						|
 * its bdi, and refcounted.
 | 
						|
 */
 | 
						|
struct bdi_writeback_congested {
 | 
						|
	unsigned long state;		/* WB_[a]sync_congested flags */
 | 
						|
	atomic_t refcnt;		/* nr of attached wb's and blkg */
 | 
						|
 | 
						|
#ifdef CONFIG_CGROUP_WRITEBACK
 | 
						|
	struct backing_dev_info *bdi;	/* the associated bdi */
 | 
						|
	int blkcg_id;			/* ID of the associated blkcg */
 | 
						|
	struct rb_node rb_node;		/* on bdi->cgwb_congestion_tree */
 | 
						|
#endif
 | 
						|
};
 | 
						|
 | 
						|
/*
 | 
						|
 * Each wb (bdi_writeback) can perform writeback operations, is measured
 | 
						|
 * and throttled, independently.  Without cgroup writeback, each bdi
 | 
						|
 * (bdi_writeback) is served by its embedded bdi->wb.
 | 
						|
 *
 | 
						|
 * On the default hierarchy, blkcg implicitly enables memcg.  This allows
 | 
						|
 * using memcg's page ownership for attributing writeback IOs, and every
 | 
						|
 * memcg - blkcg combination can be served by its own wb by assigning a
 | 
						|
 * dedicated wb to each memcg, which enables isolation across different
 | 
						|
 * cgroups and propagation of IO back pressure down from the IO layer upto
 | 
						|
 * the tasks which are generating the dirty pages to be written back.
 | 
						|
 *
 | 
						|
 * A cgroup wb is indexed on its bdi by the ID of the associated memcg,
 | 
						|
 * refcounted with the number of inodes attached to it, and pins the memcg
 | 
						|
 * and the corresponding blkcg.  As the corresponding blkcg for a memcg may
 | 
						|
 * change as blkcg is disabled and enabled higher up in the hierarchy, a wb
 | 
						|
 * is tested for blkcg after lookup and removed from index on mismatch so
 | 
						|
 * that a new wb for the combination can be created.
 | 
						|
 */
 | 
						|
struct bdi_writeback {
 | 
						|
	struct backing_dev_info *bdi;	/* our parent bdi */
 | 
						|
 | 
						|
	unsigned long state;		/* Always use atomic bitops on this */
 | 
						|
	unsigned long last_old_flush;	/* last old data flush */
 | 
						|
 | 
						|
	struct list_head b_dirty;	/* dirty inodes */
 | 
						|
	struct list_head b_io;		/* parked for writeback */
 | 
						|
	struct list_head b_more_io;	/* parked for more writeback */
 | 
						|
	struct list_head b_dirty_time;	/* time stamps are dirty */
 | 
						|
	spinlock_t list_lock;		/* protects the b_* lists */
 | 
						|
 | 
						|
	struct percpu_counter stat[NR_WB_STAT_ITEMS];
 | 
						|
 | 
						|
	struct bdi_writeback_congested *congested;
 | 
						|
 | 
						|
	unsigned long bw_time_stamp;	/* last time write bw is updated */
 | 
						|
	unsigned long dirtied_stamp;
 | 
						|
	unsigned long written_stamp;	/* pages written at bw_time_stamp */
 | 
						|
	unsigned long write_bandwidth;	/* the estimated write bandwidth */
 | 
						|
	unsigned long avg_write_bandwidth; /* further smoothed write bw, > 0 */
 | 
						|
 | 
						|
	/*
 | 
						|
	 * The base dirty throttle rate, re-calculated on every 200ms.
 | 
						|
	 * All the bdi tasks' dirty rate will be curbed under it.
 | 
						|
	 * @dirty_ratelimit tracks the estimated @balanced_dirty_ratelimit
 | 
						|
	 * in small steps and is much more smooth/stable than the latter.
 | 
						|
	 */
 | 
						|
	unsigned long dirty_ratelimit;
 | 
						|
	unsigned long balanced_dirty_ratelimit;
 | 
						|
 | 
						|
	struct fprop_local_percpu completions;
 | 
						|
	int dirty_exceeded;
 | 
						|
 | 
						|
	spinlock_t work_lock;		/* protects work_list & dwork scheduling */
 | 
						|
	struct list_head work_list;
 | 
						|
	struct delayed_work dwork;	/* work item used for writeback */
 | 
						|
 | 
						|
	struct list_head bdi_node;	/* anchored at bdi->wb_list */
 | 
						|
 | 
						|
#ifdef CONFIG_CGROUP_WRITEBACK
 | 
						|
	struct percpu_ref refcnt;	/* used only for !root wb's */
 | 
						|
	struct fprop_local_percpu memcg_completions;
 | 
						|
	struct cgroup_subsys_state *memcg_css; /* the associated memcg */
 | 
						|
	struct cgroup_subsys_state *blkcg_css; /* and blkcg */
 | 
						|
	struct list_head memcg_node;	/* anchored at memcg->cgwb_list */
 | 
						|
	struct list_head blkcg_node;	/* anchored at blkcg->cgwb_list */
 | 
						|
 | 
						|
	union {
 | 
						|
		struct work_struct release_work;
 | 
						|
		struct rcu_head rcu;
 | 
						|
	};
 | 
						|
#endif
 | 
						|
};
 | 
						|
 | 
						|
struct backing_dev_info {
 | 
						|
	struct list_head bdi_list;
 | 
						|
	unsigned long ra_pages;	/* max readahead in PAGE_SIZE units */
 | 
						|
	unsigned int capabilities; /* Device capabilities */
 | 
						|
	congested_fn *congested_fn; /* Function pointer if device is md/dm */
 | 
						|
	void *congested_data;	/* Pointer to aux data for congested func */
 | 
						|
 | 
						|
	char *name;
 | 
						|
 | 
						|
	unsigned int min_ratio;
 | 
						|
	unsigned int max_ratio, max_prop_frac;
 | 
						|
 | 
						|
	/*
 | 
						|
	 * Sum of avg_write_bw of wbs with dirty inodes.  > 0 if there are
 | 
						|
	 * any dirty wbs, which is depended upon by bdi_has_dirty().
 | 
						|
	 */
 | 
						|
	atomic_long_t tot_write_bandwidth;
 | 
						|
 | 
						|
	struct bdi_writeback wb;  /* the root writeback info for this bdi */
 | 
						|
	struct list_head wb_list; /* list of all wbs */
 | 
						|
#ifdef CONFIG_CGROUP_WRITEBACK
 | 
						|
	struct radix_tree_root cgwb_tree; /* radix tree of active cgroup wbs */
 | 
						|
	struct rb_root cgwb_congested_tree; /* their congested states */
 | 
						|
	atomic_t usage_cnt; /* counts both cgwbs and cgwb_contested's */
 | 
						|
#else
 | 
						|
	struct bdi_writeback_congested *wb_congested;
 | 
						|
#endif
 | 
						|
	wait_queue_head_t wb_waitq;
 | 
						|
 | 
						|
	struct device *dev;
 | 
						|
	struct device *owner;
 | 
						|
 | 
						|
	struct timer_list laptop_mode_wb_timer;
 | 
						|
 | 
						|
#ifdef CONFIG_DEBUG_FS
 | 
						|
	struct dentry *debug_dir;
 | 
						|
	struct dentry *debug_stats;
 | 
						|
#endif
 | 
						|
};
 | 
						|
 | 
						|
enum {
 | 
						|
	BLK_RW_ASYNC	= 0,
 | 
						|
	BLK_RW_SYNC	= 1,
 | 
						|
};
 | 
						|
 | 
						|
void clear_wb_congested(struct bdi_writeback_congested *congested, int sync);
 | 
						|
void set_wb_congested(struct bdi_writeback_congested *congested, int sync);
 | 
						|
 | 
						|
static inline void clear_bdi_congested(struct backing_dev_info *bdi, int sync)
 | 
						|
{
 | 
						|
	clear_wb_congested(bdi->wb.congested, sync);
 | 
						|
}
 | 
						|
 | 
						|
static inline void set_bdi_congested(struct backing_dev_info *bdi, int sync)
 | 
						|
{
 | 
						|
	set_wb_congested(bdi->wb.congested, sync);
 | 
						|
}
 | 
						|
 | 
						|
#ifdef CONFIG_CGROUP_WRITEBACK
 | 
						|
 | 
						|
/**
 | 
						|
 * wb_tryget - try to increment a wb's refcount
 | 
						|
 * @wb: bdi_writeback to get
 | 
						|
 */
 | 
						|
static inline bool wb_tryget(struct bdi_writeback *wb)
 | 
						|
{
 | 
						|
	if (wb != &wb->bdi->wb)
 | 
						|
		return percpu_ref_tryget(&wb->refcnt);
 | 
						|
	return true;
 | 
						|
}
 | 
						|
 | 
						|
/**
 | 
						|
 * wb_get - increment a wb's refcount
 | 
						|
 * @wb: bdi_writeback to get
 | 
						|
 */
 | 
						|
static inline void wb_get(struct bdi_writeback *wb)
 | 
						|
{
 | 
						|
	if (wb != &wb->bdi->wb)
 | 
						|
		percpu_ref_get(&wb->refcnt);
 | 
						|
}
 | 
						|
 | 
						|
/**
 | 
						|
 * wb_put - decrement a wb's refcount
 | 
						|
 * @wb: bdi_writeback to put
 | 
						|
 */
 | 
						|
static inline void wb_put(struct bdi_writeback *wb)
 | 
						|
{
 | 
						|
	if (wb != &wb->bdi->wb)
 | 
						|
		percpu_ref_put(&wb->refcnt);
 | 
						|
}
 | 
						|
 | 
						|
/**
 | 
						|
 * wb_dying - is a wb dying?
 | 
						|
 * @wb: bdi_writeback of interest
 | 
						|
 *
 | 
						|
 * Returns whether @wb is unlinked and being drained.
 | 
						|
 */
 | 
						|
static inline bool wb_dying(struct bdi_writeback *wb)
 | 
						|
{
 | 
						|
	return percpu_ref_is_dying(&wb->refcnt);
 | 
						|
}
 | 
						|
 | 
						|
#else	/* CONFIG_CGROUP_WRITEBACK */
 | 
						|
 | 
						|
static inline bool wb_tryget(struct bdi_writeback *wb)
 | 
						|
{
 | 
						|
	return true;
 | 
						|
}
 | 
						|
 | 
						|
static inline void wb_get(struct bdi_writeback *wb)
 | 
						|
{
 | 
						|
}
 | 
						|
 | 
						|
static inline void wb_put(struct bdi_writeback *wb)
 | 
						|
{
 | 
						|
}
 | 
						|
 | 
						|
static inline bool wb_dying(struct bdi_writeback *wb)
 | 
						|
{
 | 
						|
	return false;
 | 
						|
}
 | 
						|
 | 
						|
#endif	/* CONFIG_CGROUP_WRITEBACK */
 | 
						|
 | 
						|
#endif	/* __LINUX_BACKING_DEV_DEFS_H */
 |