3
0
Fork 0
forked from mirrors/linux
kernel/drivers/net/can/spi
Marc Kleine-Budde 84f5eb833f can: mcp251xfd: mcp251xfd_remove(): fix order of unregistration calls
If a driver is removed, the driver framework invokes the driver's
remove callback. A CAN driver's remove function calls
unregister_candev(), which calls net_device_ops::ndo_stop further down
in the call stack for interfaces which are in the "up" state.

With the mcp251xfd driver the removal of the module causes the
following warning:

| WARNING: CPU: 0 PID: 352 at net/core/dev.c:7342 __netif_napi_del_locked+0xc8/0xd8

as can_rx_offload_del() deletes the NAPI, while it is still active,
because the interface is still up.

To fix the warning, first unregister the network interface, which
calls net_device_ops::ndo_stop, which disables the NAPI, and then call
can_rx_offload_del().

Fixes: 55e5b97f00 ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN")
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20250502-can-rx-offload-del-v1-1-59a9b131589d@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
2025-05-06 15:45:46 +02:00
..
mcp251xfd can: mcp251xfd: mcp251xfd_remove(): fix order of unregistration calls 2025-05-06 15:45:46 +02:00
hi311x.c can: hi311x: hi3110_can_ist(): fix {rx,tx}_errors statistics 2024-11-26 10:50:48 +01:00
Kconfig
Makefile
mcp251x.c can: mcp251x: fix deadlock if an interrupt occurs during mcp251x_open 2024-08-22 09:47:09 +02:00