forked from mirrors/linux
310ae9eb26
netdev netlink is the only reader of netdev_{,rx_}queue->napi,
and it already holds netdev->lock. Switch protection of
the writes to netdev->lock to "ops protected".
The expectation will be now that accessing queue->napi
will require netdev->lock for "ops locked" drivers, and
rtnl_lock for all other drivers.
Current "ops locked" drivers don't require any changes.
gve and netdevsim use _locked() helpers right next to
netif_queue_set_napi() so they must be holding the instance
lock. iavf doesn't call it. bnxt is a bit messy but all paths
seem locked.
Acked-by: Stanislav Fomichev <sdf@fomichev.me>
Link: https://patch.msgid.link/20250324224537.248800-7-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
61 lines
1.5 KiB
C
61 lines
1.5 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _LINUX_NETDEV_RX_QUEUE_H
|
|
#define _LINUX_NETDEV_RX_QUEUE_H
|
|
|
|
#include <linux/kobject.h>
|
|
#include <linux/netdevice.h>
|
|
#include <linux/sysfs.h>
|
|
#include <net/xdp.h>
|
|
#include <net/page_pool/types.h>
|
|
|
|
/* This structure contains an instance of an RX queue. */
|
|
struct netdev_rx_queue {
|
|
struct xdp_rxq_info xdp_rxq;
|
|
#ifdef CONFIG_RPS
|
|
struct rps_map __rcu *rps_map;
|
|
struct rps_dev_flow_table __rcu *rps_flow_table;
|
|
#endif
|
|
struct kobject kobj;
|
|
const struct attribute_group **groups;
|
|
struct net_device *dev;
|
|
netdevice_tracker dev_tracker;
|
|
|
|
#ifdef CONFIG_XDP_SOCKETS
|
|
struct xsk_buff_pool *pool;
|
|
#endif
|
|
/* NAPI instance for the queue
|
|
* "ops protected", see comment about net_device::lock
|
|
*/
|
|
struct napi_struct *napi;
|
|
struct pp_memory_provider_params mp_params;
|
|
} ____cacheline_aligned_in_smp;
|
|
|
|
/*
|
|
* RX queue sysfs structures and functions.
|
|
*/
|
|
struct rx_queue_attribute {
|
|
struct attribute attr;
|
|
ssize_t (*show)(struct netdev_rx_queue *queue, char *buf);
|
|
ssize_t (*store)(struct netdev_rx_queue *queue,
|
|
const char *buf, size_t len);
|
|
};
|
|
|
|
static inline struct netdev_rx_queue *
|
|
__netif_get_rx_queue(struct net_device *dev, unsigned int rxq)
|
|
{
|
|
return dev->_rx + rxq;
|
|
}
|
|
|
|
static inline unsigned int
|
|
get_netdev_rx_queue_index(struct netdev_rx_queue *queue)
|
|
{
|
|
struct net_device *dev = queue->dev;
|
|
int index = queue - dev->_rx;
|
|
|
|
BUG_ON(index >= dev->num_rx_queues);
|
|
return index;
|
|
}
|
|
|
|
int netdev_rx_queue_restart(struct net_device *dev, unsigned int rxq);
|
|
|
|
#endif
|