forked from mirrors/linux
		
	 6fdfdef7fd
			
		
	
	
		6fdfdef7fd
		
	
	
	
	
		
			
			'&asoc->ulpq' passed to sctp_ulpq_init() as the first argument, then sctp_qlpq_init() initializes it and eventually returns the address of the struct member back. Therefore, in this case, the return pointer cannot be NULL. Moreover, it seems sctp_ulpq_init() has always been used only in sctp_association_init(), so there's really no need to return ulpq anymore. Detected using the static analysis tool - Svace. Signed-off-by: Alexey Kodanev <aleksei.kodanev@bell-sw.com> Reviewed-by: Xin Long <lucien.xin@gmail.com> Link: https://lore.kernel.org/r/20221019180735.161388-1-aleksei.kodanev@bell-sw.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
		
			
				
	
	
		
			68 lines
		
	
	
	
		
			2.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			68 lines
		
	
	
	
		
			2.2 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /* SPDX-License-Identifier: GPL-2.0-or-later */
 | |
| /* SCTP kernel implementation
 | |
|  * (C) Copyright IBM Corp. 2001, 2004
 | |
|  * Copyright (c) 1999-2000 Cisco, Inc.
 | |
|  * Copyright (c) 1999-2001 Motorola, Inc.
 | |
|  * Copyright (c) 2001 Intel Corp.
 | |
|  * Copyright (c) 2001 Nokia, Inc.
 | |
|  * Copyright (c) 2001 La Monte H.P. Yarroll
 | |
|  *
 | |
|  * These are the definitions needed for the sctp_ulpq type.  The
 | |
|  * sctp_ulpq is the interface between the Upper Layer Protocol, or ULP,
 | |
|  * and the core SCTP state machine.  This is the component which handles
 | |
|  * reassembly and ordering.
 | |
|  *
 | |
|  * Please send any bug reports or fixes you make to the
 | |
|  * email addresses:
 | |
|  *    lksctp developers <linux-sctp@vger.kernel.org>
 | |
|  *
 | |
|  * Written or modified by:
 | |
|  *   Jon Grimm             <jgrimm@us.ibm.com>
 | |
|  *   La Monte H.P. Yarroll <piggy@acm.org>
 | |
|  *   Sridhar Samudrala     <sri@us.ibm.com>
 | |
|  */
 | |
| 
 | |
| #ifndef __sctp_ulpqueue_h__
 | |
| #define __sctp_ulpqueue_h__
 | |
| 
 | |
| /* A structure to carry information to the ULP (e.g. Sockets API) */
 | |
| struct sctp_ulpq {
 | |
| 	char pd_mode;
 | |
| 	struct sctp_association *asoc;
 | |
| 	struct sk_buff_head reasm;
 | |
| 	struct sk_buff_head reasm_uo;
 | |
| 	struct sk_buff_head lobby;
 | |
| };
 | |
| 
 | |
| /* Prototypes. */
 | |
| void sctp_ulpq_init(struct sctp_ulpq *ulpq, struct sctp_association *asoc);
 | |
| void sctp_ulpq_flush(struct sctp_ulpq *ulpq);
 | |
| void sctp_ulpq_free(struct sctp_ulpq *);
 | |
| 
 | |
| /* Add a new DATA chunk for processing. */
 | |
| int sctp_ulpq_tail_data(struct sctp_ulpq *, struct sctp_chunk *, gfp_t);
 | |
| 
 | |
| /* Add a new event for propagation to the ULP. */
 | |
| int sctp_ulpq_tail_event(struct sctp_ulpq *, struct sk_buff_head *skb_list);
 | |
| 
 | |
| /* Renege previously received chunks.  */
 | |
| void sctp_ulpq_renege(struct sctp_ulpq *, struct sctp_chunk *, gfp_t);
 | |
| 
 | |
| /* Perform partial delivery. */
 | |
| void sctp_ulpq_partial_delivery(struct sctp_ulpq *, gfp_t);
 | |
| 
 | |
| /* Abort the partial delivery. */
 | |
| void sctp_ulpq_abort_pd(struct sctp_ulpq *, gfp_t);
 | |
| 
 | |
| /* Clear the partial data delivery condition on this socket. */
 | |
| int sctp_clear_pd(struct sock *sk, struct sctp_association *asoc);
 | |
| 
 | |
| /* Skip over an SSN. */
 | |
| void sctp_ulpq_skip(struct sctp_ulpq *ulpq, __u16 sid, __u16 ssn);
 | |
| 
 | |
| void sctp_ulpq_reasm_flushtsn(struct sctp_ulpq *, __u32);
 | |
| 
 | |
| __u16 sctp_ulpq_renege_list(struct sctp_ulpq *ulpq,
 | |
| 			    struct sk_buff_head *list, __u16 needed);
 | |
| 
 | |
| #endif /* __sctp_ulpqueue_h__ */
 |