forked from mirrors/linux
ea4452de2a
When we specify __GFP_NOWARN, we only expect that no warnings will be
issued for current caller. But in the __should_failslab() and
__should_fail_alloc_page(), the local GFP flags alter the global
{failslab|fail_page_alloc}.attr, which is persistent and shared by all
tasks. This is not what we expected, let's fix it.
[akpm@linux-foundation.org: unexport should_fail_ex()]
Link: https://lkml.kernel.org/r/20221118100011.2634-1-zhengqi.arch@bytedance.com
Fixes: 3f913fc5f9 ("mm: fix missing handler for __GFP_NOWARN")
Signed-off-by: Qi Zheng <zhengqi.arch@bytedance.com>
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Reviewed-by: Akinobu Mita <akinobu.mita@gmail.com>
Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Cc: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
84 lines
2.1 KiB
C
84 lines
2.1 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _LINUX_FAULT_INJECT_H
|
|
#define _LINUX_FAULT_INJECT_H
|
|
|
|
#ifdef CONFIG_FAULT_INJECTION
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/debugfs.h>
|
|
#include <linux/ratelimit.h>
|
|
#include <linux/atomic.h>
|
|
|
|
/*
|
|
* For explanation of the elements of this struct, see
|
|
* Documentation/fault-injection/fault-injection.rst
|
|
*/
|
|
struct fault_attr {
|
|
unsigned long probability;
|
|
unsigned long interval;
|
|
atomic_t times;
|
|
atomic_t space;
|
|
unsigned long verbose;
|
|
bool task_filter;
|
|
unsigned long stacktrace_depth;
|
|
unsigned long require_start;
|
|
unsigned long require_end;
|
|
unsigned long reject_start;
|
|
unsigned long reject_end;
|
|
|
|
unsigned long count;
|
|
struct ratelimit_state ratelimit_state;
|
|
struct dentry *dname;
|
|
};
|
|
|
|
enum fault_flags {
|
|
FAULT_NOWARN = 1 << 0,
|
|
};
|
|
|
|
#define FAULT_ATTR_INITIALIZER { \
|
|
.interval = 1, \
|
|
.times = ATOMIC_INIT(1), \
|
|
.require_end = ULONG_MAX, \
|
|
.stacktrace_depth = 32, \
|
|
.ratelimit_state = RATELIMIT_STATE_INIT_DISABLED, \
|
|
.verbose = 2, \
|
|
.dname = NULL, \
|
|
}
|
|
|
|
#define DECLARE_FAULT_ATTR(name) struct fault_attr name = FAULT_ATTR_INITIALIZER
|
|
int setup_fault_attr(struct fault_attr *attr, char *str);
|
|
bool should_fail_ex(struct fault_attr *attr, ssize_t size, int flags);
|
|
bool should_fail(struct fault_attr *attr, ssize_t size);
|
|
|
|
#ifdef CONFIG_FAULT_INJECTION_DEBUG_FS
|
|
|
|
struct dentry *fault_create_debugfs_attr(const char *name,
|
|
struct dentry *parent, struct fault_attr *attr);
|
|
|
|
#else /* CONFIG_FAULT_INJECTION_DEBUG_FS */
|
|
|
|
static inline struct dentry *fault_create_debugfs_attr(const char *name,
|
|
struct dentry *parent, struct fault_attr *attr)
|
|
{
|
|
return ERR_PTR(-ENODEV);
|
|
}
|
|
|
|
#endif /* CONFIG_FAULT_INJECTION_DEBUG_FS */
|
|
|
|
#endif /* CONFIG_FAULT_INJECTION */
|
|
|
|
struct kmem_cache;
|
|
|
|
bool should_fail_alloc_page(gfp_t gfp_mask, unsigned int order);
|
|
|
|
int should_failslab(struct kmem_cache *s, gfp_t gfpflags);
|
|
#ifdef CONFIG_FAILSLAB
|
|
extern bool __should_failslab(struct kmem_cache *s, gfp_t gfpflags);
|
|
#else
|
|
static inline bool __should_failslab(struct kmem_cache *s, gfp_t gfpflags)
|
|
{
|
|
return false;
|
|
}
|
|
#endif /* CONFIG_FAILSLAB */
|
|
|
|
#endif /* _LINUX_FAULT_INJECT_H */
|