forked from mirrors/linux
		
	 44ac441a51
			
		
	
	
		44ac441a51
		
	
	
	
	
		
			
			We want to kfree(table) if @table has been kmalloced,
ie for non initial network namespace.
Fixes: 849d5aa3a1 ("af_unix: Do not call kmemdup() for init_net's sysctl table.")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Kuniyuki Iwashima <kuniyu@amazon.com>
Cc: Eric W. Biederman <ebiederm@xmission.com>
Acked-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
		
	
			
		
			
				
	
	
		
			60 lines
		
	
	
	
		
			1.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			60 lines
		
	
	
	
		
			1.1 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| // SPDX-License-Identifier: GPL-2.0-or-later
 | |
| /*
 | |
|  * NET4:	Sysctl interface to net af_unix subsystem.
 | |
|  *
 | |
|  * Authors:	Mike Shaver.
 | |
|  */
 | |
| 
 | |
| #include <linux/mm.h>
 | |
| #include <linux/slab.h>
 | |
| #include <linux/sysctl.h>
 | |
| 
 | |
| #include <net/af_unix.h>
 | |
| 
 | |
| static struct ctl_table unix_table[] = {
 | |
| 	{
 | |
| 		.procname	= "max_dgram_qlen",
 | |
| 		.data		= &init_net.unx.sysctl_max_dgram_qlen,
 | |
| 		.maxlen		= sizeof(int),
 | |
| 		.mode		= 0644,
 | |
| 		.proc_handler	= proc_dointvec
 | |
| 	},
 | |
| 	{ }
 | |
| };
 | |
| 
 | |
| int __net_init unix_sysctl_register(struct net *net)
 | |
| {
 | |
| 	struct ctl_table *table;
 | |
| 
 | |
| 	if (net_eq(net, &init_net)) {
 | |
| 		table = unix_table;
 | |
| 	} else {
 | |
| 		table = kmemdup(unix_table, sizeof(unix_table), GFP_KERNEL);
 | |
| 		if (!table)
 | |
| 			goto err_alloc;
 | |
| 
 | |
| 		table[0].data = &net->unx.sysctl_max_dgram_qlen;
 | |
| 	}
 | |
| 
 | |
| 	net->unx.ctl = register_net_sysctl(net, "net/unix", table);
 | |
| 	if (net->unx.ctl == NULL)
 | |
| 		goto err_reg;
 | |
| 
 | |
| 	return 0;
 | |
| 
 | |
| err_reg:
 | |
| 	if (!net_eq(net, &init_net))
 | |
| 		kfree(table);
 | |
| err_alloc:
 | |
| 	return -ENOMEM;
 | |
| }
 | |
| 
 | |
| void unix_sysctl_unregister(struct net *net)
 | |
| {
 | |
| 	struct ctl_table *table;
 | |
| 
 | |
| 	table = net->unx.ctl->ctl_table_arg;
 | |
| 	unregister_net_sysctl_table(net->unx.ctl);
 | |
| 	if (!net_eq(net, &init_net))
 | |
| 		kfree(table);
 | |
| }
 |