forked from mirrors/linux
		
	 5fdc66e046
			
		
	
	
		5fdc66e046
		
	
	
	
	
		
			
			Commitdb8466c581("MIPS: IRQ Stack: Unwind IRQ stack onto task stack") erroneously set the initial stack pointer of the IRQ stack to a value with a 4 byte alignment. The MIPS32 ABI requires that the minimum stack alignment is 8 byte, and the MIPS64 ABIs(n32/n64) require 16 byte minimum alignment. Fix IRQ_STACK_START such that it leaves space for the dummy stack frame (containing interrupted task kernel stack pointer) while also meeting minimum alignment requirements. Fixes:db8466c581("MIPS: IRQ Stack: Unwind IRQ stack onto task stack") Reported-by: Darius Ivanauskas <dasilt@yahoo.com> Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com> Cc: Chris Metcalf <cmetcalf@mellanox.com> Cc: Petr Mladek <pmladek@suse.com> Cc: Aaron Tomlin <atomlin@redhat.com> Cc: Jason A. Donenfeld <jason@zx2c4.com> Cc: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org Patchwork: https://patchwork.linux-mips.org/patch/16760/ Signed-off-by: Ralf Baechle <ralf@linux-mips.org>
		
			
				
	
	
		
			85 lines
		
	
	
	
		
			2.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			85 lines
		
	
	
	
		
			2.3 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  * This file is subject to the terms and conditions of the GNU General Public
 | |
|  * License.  See the file "COPYING" in the main directory of this archive
 | |
|  * for more details.
 | |
|  *
 | |
|  * Copyright (C) 1994 by Waldorf GMBH, written by Ralf Baechle
 | |
|  * Copyright (C) 1995, 96, 97, 98, 99, 2000, 01, 02, 03 by Ralf Baechle
 | |
|  */
 | |
| #ifndef _ASM_IRQ_H
 | |
| #define _ASM_IRQ_H
 | |
| 
 | |
| #include <linux/linkage.h>
 | |
| #include <linux/smp.h>
 | |
| #include <linux/irqdomain.h>
 | |
| 
 | |
| #include <asm/mipsmtregs.h>
 | |
| 
 | |
| #include <irq.h>
 | |
| 
 | |
| #define IRQ_STACK_SIZE			THREAD_SIZE
 | |
| #define IRQ_STACK_START			(IRQ_STACK_SIZE - 16)
 | |
| 
 | |
| extern void *irq_stack[NR_CPUS];
 | |
| 
 | |
| /*
 | |
|  * The highest address on the IRQ stack contains a dummy frame put down in
 | |
|  * genex.S (handle_int & except_vec_vi_handler) which is structured as follows:
 | |
|  *
 | |
|  *   top ------------
 | |
|  *       | task sp  | <- irq_stack[cpu] + IRQ_STACK_START
 | |
|  *       ------------
 | |
|  *       |          | <- First frame of IRQ context
 | |
|  *       ------------
 | |
|  *
 | |
|  * task sp holds a copy of the task stack pointer where the struct pt_regs
 | |
|  * from exception entry can be found.
 | |
|  */
 | |
| 
 | |
| static inline bool on_irq_stack(int cpu, unsigned long sp)
 | |
| {
 | |
| 	unsigned long low = (unsigned long)irq_stack[cpu];
 | |
| 	unsigned long high = low + IRQ_STACK_SIZE;
 | |
| 
 | |
| 	return (low <= sp && sp <= high);
 | |
| }
 | |
| 
 | |
| #ifdef CONFIG_I8259
 | |
| static inline int irq_canonicalize(int irq)
 | |
| {
 | |
| 	return ((irq == I8259A_IRQ_BASE + 2) ? I8259A_IRQ_BASE + 9 : irq);
 | |
| }
 | |
| #else
 | |
| #define irq_canonicalize(irq) (irq)	/* Sane hardware, sane code ... */
 | |
| #endif
 | |
| 
 | |
| asmlinkage void plat_irq_dispatch(void);
 | |
| 
 | |
| extern void do_IRQ(unsigned int irq);
 | |
| 
 | |
| extern void arch_init_irq(void);
 | |
| extern void spurious_interrupt(void);
 | |
| 
 | |
| extern int allocate_irqno(void);
 | |
| extern void alloc_legacy_irqno(void);
 | |
| extern void free_irqno(unsigned int irq);
 | |
| 
 | |
| /*
 | |
|  * Before R2 the timer and performance counter interrupts were both fixed to
 | |
|  * IE7.	 Since R2 their number has to be read from the c0_intctl register.
 | |
|  */
 | |
| #define CP0_LEGACY_COMPARE_IRQ 7
 | |
| #define CP0_LEGACY_PERFCNT_IRQ 7
 | |
| 
 | |
| extern int cp0_compare_irq;
 | |
| extern int cp0_compare_irq_shift;
 | |
| extern int cp0_perfcount_irq;
 | |
| extern int cp0_fdc_irq;
 | |
| 
 | |
| extern int get_c0_fdc_int(void);
 | |
| 
 | |
| void arch_trigger_cpumask_backtrace(const struct cpumask *mask,
 | |
| 				    bool exclude_self);
 | |
| #define arch_trigger_cpumask_backtrace arch_trigger_cpumask_backtrace
 | |
| 
 | |
| #endif /* _ASM_IRQ_H */
 |