forked from mirrors/linux
		
	 c5bf68fe0c
			
		
	
	
		c5bf68fe0c
		
	
	
	
	
		
			
			Using scripts/coccinelle/api/stream_open.cocci added in10dce8af34("fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock"), search and convert to stream_open all in-kernel nonseekable_open users for which read and write actually do not depend on ppos and where there is no other methods in file_operations which assume @offset access. I've verified each generated change manually - that it is correct to convert - and each other nonseekable_open instance left - that it is either not correct to convert there, or that it is not converted due to current stream_open.cocci limitations. The script also does not convert files that should be valid to convert, but that currently have .llseek = noop_llseek or generic_file_llseek for unknown reason despite file being opened with nonseekable_open (e.g. drivers/input/mousedev.c) Among cases converted 14 were potentially vulnerable to read vs write deadlock (see details in10dce8af34): drivers/char/pcmcia/cm4000_cs.c:1685:7-23: ERROR: cm4000_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/gnss/core.c:45:1-17: ERROR: gnss_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/hid/uhid.c:635:1-17: ERROR: uhid_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/infiniband/core/user_mad.c:988:1-17: ERROR: umad_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/input/evdev.c:527:1-17: ERROR: evdev_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/input/misc/uinput.c:401:1-17: ERROR: uinput_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/isdn/capi/capi.c:963:8-24: ERROR: capi_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/leds/uleds.c:77:1-17: ERROR: uleds_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/media/rc/lirc_dev.c:198:1-17: ERROR: lirc_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/s390/char/fs3270.c:488:1-17: ERROR: fs3270_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/usb/misc/ldusb.c:310:1-17: ERROR: ld_usb_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/xen/evtchn.c:667:8-24: ERROR: evtchn_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. net/batman-adv/icmp_socket.c:80:1-17: ERROR: batadv_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. net/rfkill/core.c:1146:8-24: ERROR: rfkill_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. and the rest were just safe to convert to stream_open because their read and write do not use ppos at all and corresponding file_operations do not have methods that assume @offset file access(*): arch/powerpc/platforms/52xx/mpc52xx_gpt.c:631:8-24: WARNING: mpc52xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_ibox_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_ibox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_mbox_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_mbox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_wbox_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_wbox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/um/drivers/harddog_kern.c:88:8-24: WARNING: harddog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. arch/x86/kernel/cpu/microcode/core.c:430:33-49: WARNING: microcode_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/ds1620.c:215:8-24: WARNING: ds1620_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/dtlk.c:301:1-17: WARNING: dtlk_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/ipmi/ipmi_watchdog.c:840:9-25: WARNING: ipmi_wdog_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/pcmcia/scr24x_cs.c:95:8-24: WARNING: scr24x_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/tb0219.c:246:9-25: WARNING: tb0219_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/firewire/nosy.c:306:8-24: WARNING: nosy_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/hwmon/fschmd.c:840:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/hwmon/w83793.c:1344:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/infiniband/core/ucma.c:1747:8-24: WARNING: ucma_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/infiniband/core/ucm.c:1178:8-24: WARNING: ucm_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/infiniband/core/uverbs_main.c:1086:8-24: WARNING: uverbs_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/input/joydev.c:282:1-17: WARNING: joydev_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/pci/switch/switchtec.c:393:1-17: WARNING: switchtec_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/platform/chrome/cros_ec_debugfs.c:135:8-24: WARNING: cros_ec_console_log_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/rtc/rtc-ds1374.c:470:9-25: WARNING: ds1374_wdt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/rtc/rtc-m41t80.c:805:9-25: WARNING: wdt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/s390/char/tape_char.c:293:2-18: WARNING: tape_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/s390/char/zcore.c:194:8-24: WARNING: zcore_reipl_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/s390/crypto/zcrypt_api.c:528:8-24: WARNING: zcrypt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/spi/spidev.c:594:1-17: WARNING: spidev_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/staging/pi433/pi433_if.c:974:1-17: WARNING: pi433_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/acquirewdt.c:203:8-24: WARNING: acq_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/advantechwdt.c:202:8-24: WARNING: advwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/alim1535_wdt.c:252:8-24: WARNING: ali_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/alim7101_wdt.c:217:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ar7_wdt.c:166:8-24: WARNING: ar7_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/at91rm9200_wdt.c:113:8-24: WARNING: at91wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ath79_wdt.c:135:8-24: WARNING: ath79_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/bcm63xx_wdt.c:119:8-24: WARNING: bcm63xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/cpu5wdt.c:143:8-24: WARNING: cpu5wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/cpwd.c:397:8-24: WARNING: cpwd_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/eurotechwdt.c:319:8-24: WARNING: eurwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/f71808e_wdt.c:528:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/gef_wdt.c:232:8-24: WARNING: gef_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/geodewdt.c:95:8-24: WARNING: geodewdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ib700wdt.c:241:8-24: WARNING: ibwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ibmasr.c:326:8-24: WARNING: asr_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/indydog.c:80:8-24: WARNING: indydog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/intel_scu_watchdog.c:307:8-24: WARNING: intel_scu_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/iop_wdt.c:104:8-24: WARNING: iop_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/it8712f_wdt.c:330:8-24: WARNING: it8712f_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ixp4xx_wdt.c:68:8-24: WARNING: ixp4xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ks8695_wdt.c:145:8-24: WARNING: ks8695wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/m54xx_wdt.c:88:8-24: WARNING: m54xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/machzwd.c:336:8-24: WARNING: zf_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/mixcomwd.c:153:8-24: WARNING: mixcomwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/mtx-1_wdt.c:121:8-24: WARNING: mtx1_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/mv64x60_wdt.c:136:8-24: WARNING: mv64x60_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/nuc900_wdt.c:134:8-24: WARNING: nuc900wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/nv_tco.c:164:8-24: WARNING: nv_tco_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pc87413_wdt.c:289:8-24: WARNING: pc87413_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd.c:698:8-24: WARNING: pcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd.c:737:8-24: WARNING: pcwd_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_pci.c:581:8-24: WARNING: pcipcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_pci.c:623:8-24: WARNING: pcipcwd_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_usb.c:488:8-24: WARNING: usb_pcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_usb.c:527:8-24: WARNING: usb_pcwd_temperature_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pika_wdt.c:121:8-24: WARNING: pikawdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pnx833x_wdt.c:119:8-24: WARNING: pnx833x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/rc32434_wdt.c:153:8-24: WARNING: rc32434_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/rdc321x_wdt.c:145:8-24: WARNING: rdc321x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/riowd.c:79:1-17: WARNING: riowd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sa1100_wdt.c:62:8-24: WARNING: sa1100dog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc60xxwdt.c:211:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc7240_wdt.c:139:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc8360.c:274:8-24: WARNING: sbc8360_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc_epx_c3.c:81:8-24: WARNING: epx_c3_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc_fitpc2_wdt.c:78:8-24: WARNING: fitpc2_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sb_wdog.c:108:1-17: WARNING: sbwdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sc1200wdt.c:181:8-24: WARNING: sc1200wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sc520_wdt.c:261:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sch311x_wdt.c:319:8-24: WARNING: sch311x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/scx200_wdt.c:105:8-24: WARNING: scx200_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/smsc37b787_wdt.c:369:8-24: WARNING: wb_smsc_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/w83877f_wdt.c:227:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/w83977f_wdt.c:301:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wafer5823wdt.c:200:8-24: WARNING: wafwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/watchdog_dev.c:828:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdrtas.c:379:8-24: WARNING: wdrtas_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdrtas.c:445:8-24: WARNING: wdrtas_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt285.c:104:1-17: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt977.c:276:8-24: WARNING: wdt977_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt.c:424:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt.c:484:8-24: WARNING: wdt_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt_pci.c:464:8-24: WARNING: wdtpci_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt_pci.c:527:8-24: WARNING: wdtpci_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. net/batman-adv/log.c:105:1-17: WARNING: batadv_log_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. sound/core/control.c:57:7-23: WARNING: snd_ctl_f_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. sound/core/rawmidi.c:385:7-23: WARNING: snd_rawmidi_f_ops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. sound/core/seq/seq_clientmgr.c:310:7-23: WARNING: snd_seq_f_ops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. sound/core/timer.c:1428:7-23: WARNING: snd_timer_f_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. One can also recheck/review the patch via generating it with explanation comments included via $ make coccicheck MODE=patch COCCI=scripts/coccinelle/api/stream_open.cocci SPFLAGS="-D explain" (*) This second group also contains cases with read/write deadlocks that stream_open.cocci don't yet detect, but which are still valid to convert to stream_open since ppos is not used. For example drivers/pci/switch/switchtec.c calls wait_for_completion_interruptible() in its .read, but stream_open.cocci currently detects only "wait_event*" as blocking. Cc: Michael Kerrisk <mtk.manpages@gmail.com> Cc: Yongzhi Pan <panyongzhi@gmail.com> Cc: Jonathan Corbet <corbet@lwn.net> Cc: David Vrabel <david.vrabel@citrix.com> Cc: Juergen Gross <jgross@suse.com> Cc: Miklos Szeredi <miklos@szeredi.hu> Cc: Tejun Heo <tj@kernel.org> Cc: Kirill Tkhai <ktkhai@virtuozzo.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Christoph Hellwig <hch@lst.de> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Nikolaus Rath <Nikolaus@rath.org> Cc: Han-Wen Nienhuys <hanwen@google.com> Cc: Anatolij Gustschin <agust@denx.de> Cc: Jeff Dike <jdike@addtoit.com> Cc: Richard Weinberger <richard@nod.at> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: "James R. Van Zandt" <jrv@vanzandt.mv.com> Cc: Corey Minyard <minyard@acm.org> Cc: Harald Welte <laforge@gnumonks.org> Acked-by: Lubomir Rintel <lkundrak@v3.sk> [scr24x_cs] Cc: Stefan Richter <stefanr@s5r6.in-berlin.de> Cc: Johan Hovold <johan@kernel.org> Cc: David Herrmann <dh.herrmann@googlemail.com> Cc: Jiri Kosina <jikos@kernel.org> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cc: Jean Delvare <jdelvare@suse.com> Acked-by: Guenter Roeck <linux@roeck-us.net> [watchdog/* hwmon/*] Cc: Rudolf Marek <r.marek@assembler.cz> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Karsten Keil <isdn@linux-pingi.de> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> Cc: Pavel Machek <pavel@ucw.cz> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Kurt Schwemmer <kurt.schwemmer@microsemi.com> Acked-by: Logan Gunthorpe <logang@deltatee.com> [drivers/pci/switch/switchtec] Acked-by: Bjorn Helgaas <bhelgaas@google.com> [drivers/pci/switch/switchtec] Cc: Benson Leung <bleung@chromium.org> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> [platform/chrome] Cc: Alessandro Zummo <a.zummo@towertech.it> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> [rtc/*] Cc: Mark Brown <broonie@kernel.org> Cc: Wim Van Sebroeck <wim@linux-watchdog.org> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: Wan ZongShun <mcuos.com@gmail.com> Cc: Zwane Mwaikambo <zwanem@gmail.com> Cc: Marek Lindner <mareklindner@neomailbox.ch> Cc: Simon Wunderlich <sw@simonwunderlich.de> Cc: Antonio Quartulli <a@unstable.cc> Cc: "David S. Miller" <davem@davemloft.net> Cc: Johannes Berg <johannes@sipsolutions.net> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Signed-off-by: Kirill Smelkov <kirr@nexedi.com>
		
			
				
	
	
		
			314 lines
		
	
	
	
		
			6.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			314 lines
		
	
	
	
		
			6.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| // SPDX-License-Identifier: GPL-2.0+
 | |
| /*
 | |
|  *  Broadcom BCM63xx SoC watchdog driver
 | |
|  *
 | |
|  *  Copyright (C) 2007, Miguel Gaio <miguel.gaio@efixo.com>
 | |
|  *  Copyright (C) 2008, Florian Fainelli <florian@openwrt.org>
 | |
|  *
 | |
|  */
 | |
| 
 | |
| #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 | |
| 
 | |
| #include <linux/bitops.h>
 | |
| #include <linux/errno.h>
 | |
| #include <linux/fs.h>
 | |
| #include <linux/io.h>
 | |
| #include <linux/kernel.h>
 | |
| #include <linux/miscdevice.h>
 | |
| #include <linux/module.h>
 | |
| #include <linux/moduleparam.h>
 | |
| #include <linux/types.h>
 | |
| #include <linux/uaccess.h>
 | |
| #include <linux/watchdog.h>
 | |
| #include <linux/timer.h>
 | |
| #include <linux/jiffies.h>
 | |
| #include <linux/interrupt.h>
 | |
| #include <linux/ptrace.h>
 | |
| #include <linux/resource.h>
 | |
| #include <linux/platform_device.h>
 | |
| 
 | |
| #include <bcm63xx_cpu.h>
 | |
| #include <bcm63xx_io.h>
 | |
| #include <bcm63xx_regs.h>
 | |
| #include <bcm63xx_timer.h>
 | |
| 
 | |
| #define PFX KBUILD_MODNAME
 | |
| 
 | |
| #define WDT_HZ		50000000 /* Fclk */
 | |
| #define WDT_DEFAULT_TIME	30      /* seconds */
 | |
| #define WDT_MAX_TIME		256     /* seconds */
 | |
| 
 | |
| static struct {
 | |
| 	void __iomem *regs;
 | |
| 	struct timer_list timer;
 | |
| 	unsigned long inuse;
 | |
| 	atomic_t ticks;
 | |
| } bcm63xx_wdt_device;
 | |
| 
 | |
| static int expect_close;
 | |
| 
 | |
| static int wdt_time = WDT_DEFAULT_TIME;
 | |
| static bool nowayout = WATCHDOG_NOWAYOUT;
 | |
| module_param(nowayout, bool, 0);
 | |
| MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started (default="
 | |
| 	__MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
 | |
| 
 | |
| /* HW functions */
 | |
| static void bcm63xx_wdt_hw_start(void)
 | |
| {
 | |
| 	bcm_writel(0xfffffffe, bcm63xx_wdt_device.regs + WDT_DEFVAL_REG);
 | |
| 	bcm_writel(WDT_START_1, bcm63xx_wdt_device.regs + WDT_CTL_REG);
 | |
| 	bcm_writel(WDT_START_2, bcm63xx_wdt_device.regs + WDT_CTL_REG);
 | |
| }
 | |
| 
 | |
| static void bcm63xx_wdt_hw_stop(void)
 | |
| {
 | |
| 	bcm_writel(WDT_STOP_1, bcm63xx_wdt_device.regs + WDT_CTL_REG);
 | |
| 	bcm_writel(WDT_STOP_2, bcm63xx_wdt_device.regs + WDT_CTL_REG);
 | |
| }
 | |
| 
 | |
| static void bcm63xx_wdt_isr(void *data)
 | |
| {
 | |
| 	struct pt_regs *regs = get_irq_regs();
 | |
| 
 | |
| 	die(PFX " fire", regs);
 | |
| }
 | |
| 
 | |
| static void bcm63xx_timer_tick(struct timer_list *unused)
 | |
| {
 | |
| 	if (!atomic_dec_and_test(&bcm63xx_wdt_device.ticks)) {
 | |
| 		bcm63xx_wdt_hw_start();
 | |
| 		mod_timer(&bcm63xx_wdt_device.timer, jiffies + HZ);
 | |
| 	} else
 | |
| 		pr_crit("watchdog will restart system\n");
 | |
| }
 | |
| 
 | |
| static void bcm63xx_wdt_pet(void)
 | |
| {
 | |
| 	atomic_set(&bcm63xx_wdt_device.ticks, wdt_time);
 | |
| }
 | |
| 
 | |
| static void bcm63xx_wdt_start(void)
 | |
| {
 | |
| 	bcm63xx_wdt_pet();
 | |
| 	bcm63xx_timer_tick(0);
 | |
| }
 | |
| 
 | |
| static void bcm63xx_wdt_pause(void)
 | |
| {
 | |
| 	del_timer_sync(&bcm63xx_wdt_device.timer);
 | |
| 	bcm63xx_wdt_hw_stop();
 | |
| }
 | |
| 
 | |
| static int bcm63xx_wdt_settimeout(int new_time)
 | |
| {
 | |
| 	if ((new_time <= 0) || (new_time > WDT_MAX_TIME))
 | |
| 		return -EINVAL;
 | |
| 
 | |
| 	wdt_time = new_time;
 | |
| 
 | |
| 	return 0;
 | |
| }
 | |
| 
 | |
| static int bcm63xx_wdt_open(struct inode *inode, struct file *file)
 | |
| {
 | |
| 	if (test_and_set_bit(0, &bcm63xx_wdt_device.inuse))
 | |
| 		return -EBUSY;
 | |
| 
 | |
| 	bcm63xx_wdt_start();
 | |
| 	return stream_open(inode, file);
 | |
| }
 | |
| 
 | |
| static int bcm63xx_wdt_release(struct inode *inode, struct file *file)
 | |
| {
 | |
| 	if (expect_close == 42)
 | |
| 		bcm63xx_wdt_pause();
 | |
| 	else {
 | |
| 		pr_crit("Unexpected close, not stopping watchdog!\n");
 | |
| 		bcm63xx_wdt_start();
 | |
| 	}
 | |
| 	clear_bit(0, &bcm63xx_wdt_device.inuse);
 | |
| 	expect_close = 0;
 | |
| 	return 0;
 | |
| }
 | |
| 
 | |
| static ssize_t bcm63xx_wdt_write(struct file *file, const char *data,
 | |
| 				size_t len, loff_t *ppos)
 | |
| {
 | |
| 	if (len) {
 | |
| 		if (!nowayout) {
 | |
| 			size_t i;
 | |
| 
 | |
| 			/* In case it was set long ago */
 | |
| 			expect_close = 0;
 | |
| 
 | |
| 			for (i = 0; i != len; i++) {
 | |
| 				char c;
 | |
| 				if (get_user(c, data + i))
 | |
| 					return -EFAULT;
 | |
| 				if (c == 'V')
 | |
| 					expect_close = 42;
 | |
| 			}
 | |
| 		}
 | |
| 		bcm63xx_wdt_pet();
 | |
| 	}
 | |
| 	return len;
 | |
| }
 | |
| 
 | |
| static struct watchdog_info bcm63xx_wdt_info = {
 | |
| 	.identity       = PFX,
 | |
| 	.options        = WDIOF_SETTIMEOUT |
 | |
| 				WDIOF_KEEPALIVEPING |
 | |
| 				WDIOF_MAGICCLOSE,
 | |
| };
 | |
| 
 | |
| 
 | |
| static long bcm63xx_wdt_ioctl(struct file *file, unsigned int cmd,
 | |
| 				unsigned long arg)
 | |
| {
 | |
| 	void __user *argp = (void __user *)arg;
 | |
| 	int __user *p = argp;
 | |
| 	int new_value, retval = -EINVAL;
 | |
| 
 | |
| 	switch (cmd) {
 | |
| 	case WDIOC_GETSUPPORT:
 | |
| 		return copy_to_user(argp, &bcm63xx_wdt_info,
 | |
| 			sizeof(bcm63xx_wdt_info)) ? -EFAULT : 0;
 | |
| 
 | |
| 	case WDIOC_GETSTATUS:
 | |
| 	case WDIOC_GETBOOTSTATUS:
 | |
| 		return put_user(0, p);
 | |
| 
 | |
| 	case WDIOC_SETOPTIONS:
 | |
| 		if (get_user(new_value, p))
 | |
| 			return -EFAULT;
 | |
| 
 | |
| 		if (new_value & WDIOS_DISABLECARD) {
 | |
| 			bcm63xx_wdt_pause();
 | |
| 			retval = 0;
 | |
| 		}
 | |
| 		if (new_value & WDIOS_ENABLECARD) {
 | |
| 			bcm63xx_wdt_start();
 | |
| 			retval = 0;
 | |
| 		}
 | |
| 
 | |
| 		return retval;
 | |
| 
 | |
| 	case WDIOC_KEEPALIVE:
 | |
| 		bcm63xx_wdt_pet();
 | |
| 		return 0;
 | |
| 
 | |
| 	case WDIOC_SETTIMEOUT:
 | |
| 		if (get_user(new_value, p))
 | |
| 			return -EFAULT;
 | |
| 
 | |
| 		if (bcm63xx_wdt_settimeout(new_value))
 | |
| 			return -EINVAL;
 | |
| 
 | |
| 		bcm63xx_wdt_pet();
 | |
| 
 | |
| 	case WDIOC_GETTIMEOUT:
 | |
| 		return put_user(wdt_time, p);
 | |
| 
 | |
| 	default:
 | |
| 		return -ENOTTY;
 | |
| 
 | |
| 	}
 | |
| }
 | |
| 
 | |
| static const struct file_operations bcm63xx_wdt_fops = {
 | |
| 	.owner		= THIS_MODULE,
 | |
| 	.llseek		= no_llseek,
 | |
| 	.write		= bcm63xx_wdt_write,
 | |
| 	.unlocked_ioctl	= bcm63xx_wdt_ioctl,
 | |
| 	.open		= bcm63xx_wdt_open,
 | |
| 	.release	= bcm63xx_wdt_release,
 | |
| };
 | |
| 
 | |
| static struct miscdevice bcm63xx_wdt_miscdev = {
 | |
| 	.minor	= WATCHDOG_MINOR,
 | |
| 	.name	= "watchdog",
 | |
| 	.fops	= &bcm63xx_wdt_fops,
 | |
| };
 | |
| 
 | |
| 
 | |
| static int bcm63xx_wdt_probe(struct platform_device *pdev)
 | |
| {
 | |
| 	int ret;
 | |
| 	struct resource *r;
 | |
| 
 | |
| 	timer_setup(&bcm63xx_wdt_device.timer, bcm63xx_timer_tick, 0);
 | |
| 
 | |
| 	r = platform_get_resource(pdev, IORESOURCE_MEM, 0);
 | |
| 	if (!r) {
 | |
| 		dev_err(&pdev->dev, "failed to get resources\n");
 | |
| 		return -ENODEV;
 | |
| 	}
 | |
| 
 | |
| 	bcm63xx_wdt_device.regs = devm_ioremap_nocache(&pdev->dev, r->start,
 | |
| 							resource_size(r));
 | |
| 	if (!bcm63xx_wdt_device.regs) {
 | |
| 		dev_err(&pdev->dev, "failed to remap I/O resources\n");
 | |
| 		return -ENXIO;
 | |
| 	}
 | |
| 
 | |
| 	ret = bcm63xx_timer_register(TIMER_WDT_ID, bcm63xx_wdt_isr, NULL);
 | |
| 	if (ret < 0) {
 | |
| 		dev_err(&pdev->dev, "failed to register wdt timer isr\n");
 | |
| 		return ret;
 | |
| 	}
 | |
| 
 | |
| 	if (bcm63xx_wdt_settimeout(wdt_time)) {
 | |
| 		bcm63xx_wdt_settimeout(WDT_DEFAULT_TIME);
 | |
| 		dev_info(&pdev->dev,
 | |
| 			": wdt_time value must be 1 <= wdt_time <= 256, using %d\n",
 | |
| 			wdt_time);
 | |
| 	}
 | |
| 
 | |
| 	ret = misc_register(&bcm63xx_wdt_miscdev);
 | |
| 	if (ret < 0) {
 | |
| 		dev_err(&pdev->dev, "failed to register watchdog device\n");
 | |
| 		goto unregister_timer;
 | |
| 	}
 | |
| 
 | |
| 	dev_info(&pdev->dev, " started, timer margin: %d sec\n",
 | |
| 						WDT_DEFAULT_TIME);
 | |
| 
 | |
| 	return 0;
 | |
| 
 | |
| unregister_timer:
 | |
| 	bcm63xx_timer_unregister(TIMER_WDT_ID);
 | |
| 	return ret;
 | |
| }
 | |
| 
 | |
| static int bcm63xx_wdt_remove(struct platform_device *pdev)
 | |
| {
 | |
| 	if (!nowayout)
 | |
| 		bcm63xx_wdt_pause();
 | |
| 
 | |
| 	misc_deregister(&bcm63xx_wdt_miscdev);
 | |
| 	bcm63xx_timer_unregister(TIMER_WDT_ID);
 | |
| 	return 0;
 | |
| }
 | |
| 
 | |
| static void bcm63xx_wdt_shutdown(struct platform_device *pdev)
 | |
| {
 | |
| 	bcm63xx_wdt_pause();
 | |
| }
 | |
| 
 | |
| static struct platform_driver bcm63xx_wdt_driver = {
 | |
| 	.probe	= bcm63xx_wdt_probe,
 | |
| 	.remove = bcm63xx_wdt_remove,
 | |
| 	.shutdown = bcm63xx_wdt_shutdown,
 | |
| 	.driver = {
 | |
| 		.name = "bcm63xx-wdt",
 | |
| 	}
 | |
| };
 | |
| 
 | |
| module_platform_driver(bcm63xx_wdt_driver);
 | |
| 
 | |
| MODULE_AUTHOR("Miguel Gaio <miguel.gaio@efixo.com>");
 | |
| MODULE_AUTHOR("Florian Fainelli <florian@openwrt.org>");
 | |
| MODULE_DESCRIPTION("Driver for the Broadcom BCM63xx SoC watchdog");
 | |
| MODULE_LICENSE("GPL");
 | |
| MODULE_ALIAS("platform:bcm63xx-wdt");
 |