forked from mirrors/linux
		
	 c5bf68fe0c
			
		
	
	
		c5bf68fe0c
		
	
	
	
	
		
			
			Using scripts/coccinelle/api/stream_open.cocci added in10dce8af34("fs: stream_open - opener for stream-like files so that read and write can run simultaneously without deadlock"), search and convert to stream_open all in-kernel nonseekable_open users for which read and write actually do not depend on ppos and where there is no other methods in file_operations which assume @offset access. I've verified each generated change manually - that it is correct to convert - and each other nonseekable_open instance left - that it is either not correct to convert there, or that it is not converted due to current stream_open.cocci limitations. The script also does not convert files that should be valid to convert, but that currently have .llseek = noop_llseek or generic_file_llseek for unknown reason despite file being opened with nonseekable_open (e.g. drivers/input/mousedev.c) Among cases converted 14 were potentially vulnerable to read vs write deadlock (see details in10dce8af34): drivers/char/pcmcia/cm4000_cs.c:1685:7-23: ERROR: cm4000_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/gnss/core.c:45:1-17: ERROR: gnss_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/hid/uhid.c:635:1-17: ERROR: uhid_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/infiniband/core/user_mad.c:988:1-17: ERROR: umad_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/input/evdev.c:527:1-17: ERROR: evdev_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/input/misc/uinput.c:401:1-17: ERROR: uinput_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/isdn/capi/capi.c:963:8-24: ERROR: capi_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/leds/uleds.c:77:1-17: ERROR: uleds_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/media/rc/lirc_dev.c:198:1-17: ERROR: lirc_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/s390/char/fs3270.c:488:1-17: ERROR: fs3270_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/usb/misc/ldusb.c:310:1-17: ERROR: ld_usb_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. drivers/xen/evtchn.c:667:8-24: ERROR: evtchn_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. net/batman-adv/icmp_socket.c:80:1-17: ERROR: batadv_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. net/rfkill/core.c:1146:8-24: ERROR: rfkill_fops: .read() can deadlock .write(); change nonseekable_open -> stream_open to fix. and the rest were just safe to convert to stream_open because their read and write do not use ppos at all and corresponding file_operations do not have methods that assume @offset file access(*): arch/powerpc/platforms/52xx/mpc52xx_gpt.c:631:8-24: WARNING: mpc52xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_ibox_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_ibox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_mbox_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_mbox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_wbox_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. arch/powerpc/platforms/cell/spufs/file.c:591:8-24: WARNING: spufs_wbox_stat_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. arch/um/drivers/harddog_kern.c:88:8-24: WARNING: harddog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. arch/x86/kernel/cpu/microcode/core.c:430:33-49: WARNING: microcode_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/ds1620.c:215:8-24: WARNING: ds1620_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/dtlk.c:301:1-17: WARNING: dtlk_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/ipmi/ipmi_watchdog.c:840:9-25: WARNING: ipmi_wdog_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/pcmcia/scr24x_cs.c:95:8-24: WARNING: scr24x_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/char/tb0219.c:246:9-25: WARNING: tb0219_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/firewire/nosy.c:306:8-24: WARNING: nosy_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/hwmon/fschmd.c:840:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/hwmon/w83793.c:1344:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/infiniband/core/ucma.c:1747:8-24: WARNING: ucma_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/infiniband/core/ucm.c:1178:8-24: WARNING: ucm_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/infiniband/core/uverbs_main.c:1086:8-24: WARNING: uverbs_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/input/joydev.c:282:1-17: WARNING: joydev_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/pci/switch/switchtec.c:393:1-17: WARNING: switchtec_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/platform/chrome/cros_ec_debugfs.c:135:8-24: WARNING: cros_ec_console_log_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/rtc/rtc-ds1374.c:470:9-25: WARNING: ds1374_wdt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/rtc/rtc-m41t80.c:805:9-25: WARNING: wdt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/s390/char/tape_char.c:293:2-18: WARNING: tape_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/s390/char/zcore.c:194:8-24: WARNING: zcore_reipl_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/s390/crypto/zcrypt_api.c:528:8-24: WARNING: zcrypt_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/spi/spidev.c:594:1-17: WARNING: spidev_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/staging/pi433/pi433_if.c:974:1-17: WARNING: pi433_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/acquirewdt.c:203:8-24: WARNING: acq_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/advantechwdt.c:202:8-24: WARNING: advwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/alim1535_wdt.c:252:8-24: WARNING: ali_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/alim7101_wdt.c:217:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ar7_wdt.c:166:8-24: WARNING: ar7_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/at91rm9200_wdt.c:113:8-24: WARNING: at91wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ath79_wdt.c:135:8-24: WARNING: ath79_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/bcm63xx_wdt.c:119:8-24: WARNING: bcm63xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/cpu5wdt.c:143:8-24: WARNING: cpu5wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/cpwd.c:397:8-24: WARNING: cpwd_fops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/eurotechwdt.c:319:8-24: WARNING: eurwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/f71808e_wdt.c:528:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/gef_wdt.c:232:8-24: WARNING: gef_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/geodewdt.c:95:8-24: WARNING: geodewdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ib700wdt.c:241:8-24: WARNING: ibwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ibmasr.c:326:8-24: WARNING: asr_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/indydog.c:80:8-24: WARNING: indydog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/intel_scu_watchdog.c:307:8-24: WARNING: intel_scu_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/iop_wdt.c:104:8-24: WARNING: iop_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/it8712f_wdt.c:330:8-24: WARNING: it8712f_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ixp4xx_wdt.c:68:8-24: WARNING: ixp4xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/ks8695_wdt.c:145:8-24: WARNING: ks8695wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/m54xx_wdt.c:88:8-24: WARNING: m54xx_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/machzwd.c:336:8-24: WARNING: zf_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/mixcomwd.c:153:8-24: WARNING: mixcomwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/mtx-1_wdt.c:121:8-24: WARNING: mtx1_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/mv64x60_wdt.c:136:8-24: WARNING: mv64x60_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/nuc900_wdt.c:134:8-24: WARNING: nuc900wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/nv_tco.c:164:8-24: WARNING: nv_tco_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pc87413_wdt.c:289:8-24: WARNING: pc87413_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd.c:698:8-24: WARNING: pcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd.c:737:8-24: WARNING: pcwd_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_pci.c:581:8-24: WARNING: pcipcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_pci.c:623:8-24: WARNING: pcipcwd_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_usb.c:488:8-24: WARNING: usb_pcwd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pcwd_usb.c:527:8-24: WARNING: usb_pcwd_temperature_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pika_wdt.c:121:8-24: WARNING: pikawdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/pnx833x_wdt.c:119:8-24: WARNING: pnx833x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/rc32434_wdt.c:153:8-24: WARNING: rc32434_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/rdc321x_wdt.c:145:8-24: WARNING: rdc321x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/riowd.c:79:1-17: WARNING: riowd_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sa1100_wdt.c:62:8-24: WARNING: sa1100dog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc60xxwdt.c:211:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc7240_wdt.c:139:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc8360.c:274:8-24: WARNING: sbc8360_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc_epx_c3.c:81:8-24: WARNING: epx_c3_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sbc_fitpc2_wdt.c:78:8-24: WARNING: fitpc2_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sb_wdog.c:108:1-17: WARNING: sbwdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sc1200wdt.c:181:8-24: WARNING: sc1200wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sc520_wdt.c:261:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/sch311x_wdt.c:319:8-24: WARNING: sch311x_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/scx200_wdt.c:105:8-24: WARNING: scx200_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/smsc37b787_wdt.c:369:8-24: WARNING: wb_smsc_wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/w83877f_wdt.c:227:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/w83977f_wdt.c:301:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wafer5823wdt.c:200:8-24: WARNING: wafwdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/watchdog_dev.c:828:8-24: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdrtas.c:379:8-24: WARNING: wdrtas_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdrtas.c:445:8-24: WARNING: wdrtas_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt285.c:104:1-17: WARNING: watchdog_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt977.c:276:8-24: WARNING: wdt977_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt.c:424:8-24: WARNING: wdt_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt.c:484:8-24: WARNING: wdt_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt_pci.c:464:8-24: WARNING: wdtpci_fops: .write() has stream semantic; safe to change nonseekable_open -> stream_open. drivers/watchdog/wdt_pci.c:527:8-24: WARNING: wdtpci_temp_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. net/batman-adv/log.c:105:1-17: WARNING: batadv_log_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. sound/core/control.c:57:7-23: WARNING: snd_ctl_f_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. sound/core/rawmidi.c:385:7-23: WARNING: snd_rawmidi_f_ops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. sound/core/seq/seq_clientmgr.c:310:7-23: WARNING: snd_seq_f_ops: .read() and .write() have stream semantic; safe to change nonseekable_open -> stream_open. sound/core/timer.c:1428:7-23: WARNING: snd_timer_f_ops: .read() has stream semantic; safe to change nonseekable_open -> stream_open. One can also recheck/review the patch via generating it with explanation comments included via $ make coccicheck MODE=patch COCCI=scripts/coccinelle/api/stream_open.cocci SPFLAGS="-D explain" (*) This second group also contains cases with read/write deadlocks that stream_open.cocci don't yet detect, but which are still valid to convert to stream_open since ppos is not used. For example drivers/pci/switch/switchtec.c calls wait_for_completion_interruptible() in its .read, but stream_open.cocci currently detects only "wait_event*" as blocking. Cc: Michael Kerrisk <mtk.manpages@gmail.com> Cc: Yongzhi Pan <panyongzhi@gmail.com> Cc: Jonathan Corbet <corbet@lwn.net> Cc: David Vrabel <david.vrabel@citrix.com> Cc: Juergen Gross <jgross@suse.com> Cc: Miklos Szeredi <miklos@szeredi.hu> Cc: Tejun Heo <tj@kernel.org> Cc: Kirill Tkhai <ktkhai@virtuozzo.com> Cc: Arnd Bergmann <arnd@arndb.de> Cc: Christoph Hellwig <hch@lst.de> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Julia Lawall <Julia.Lawall@lip6.fr> Cc: Nikolaus Rath <Nikolaus@rath.org> Cc: Han-Wen Nienhuys <hanwen@google.com> Cc: Anatolij Gustschin <agust@denx.de> Cc: Jeff Dike <jdike@addtoit.com> Cc: Richard Weinberger <richard@nod.at> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@redhat.com> Cc: "James R. Van Zandt" <jrv@vanzandt.mv.com> Cc: Corey Minyard <minyard@acm.org> Cc: Harald Welte <laforge@gnumonks.org> Acked-by: Lubomir Rintel <lkundrak@v3.sk> [scr24x_cs] Cc: Stefan Richter <stefanr@s5r6.in-berlin.de> Cc: Johan Hovold <johan@kernel.org> Cc: David Herrmann <dh.herrmann@googlemail.com> Cc: Jiri Kosina <jikos@kernel.org> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cc: Jean Delvare <jdelvare@suse.com> Acked-by: Guenter Roeck <linux@roeck-us.net> [watchdog/* hwmon/*] Cc: Rudolf Marek <r.marek@assembler.cz> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com> Cc: Karsten Keil <isdn@linux-pingi.de> Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com> Cc: Pavel Machek <pavel@ucw.cz> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Cc: Kurt Schwemmer <kurt.schwemmer@microsemi.com> Acked-by: Logan Gunthorpe <logang@deltatee.com> [drivers/pci/switch/switchtec] Acked-by: Bjorn Helgaas <bhelgaas@google.com> [drivers/pci/switch/switchtec] Cc: Benson Leung <bleung@chromium.org> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> [platform/chrome] Cc: Alessandro Zummo <a.zummo@towertech.it> Acked-by: Alexandre Belloni <alexandre.belloni@bootlin.com> [rtc/*] Cc: Mark Brown <broonie@kernel.org> Cc: Wim Van Sebroeck <wim@linux-watchdog.org> Cc: Florian Fainelli <f.fainelli@gmail.com> Cc: bcm-kernel-feedback-list@broadcom.com Cc: Wan ZongShun <mcuos.com@gmail.com> Cc: Zwane Mwaikambo <zwanem@gmail.com> Cc: Marek Lindner <mareklindner@neomailbox.ch> Cc: Simon Wunderlich <sw@simonwunderlich.de> Cc: Antonio Quartulli <a@unstable.cc> Cc: "David S. Miller" <davem@davemloft.net> Cc: Johannes Berg <johannes@sipsolutions.net> Cc: Jaroslav Kysela <perex@perex.cz> Cc: Takashi Iwai <tiwai@suse.com> Signed-off-by: Kirill Smelkov <kirr@nexedi.com>
		
			
				
	
	
		
			479 lines
		
	
	
	
		
			11 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			479 lines
		
	
	
	
		
			11 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
| /*
 | |
|  *	Eurotech CPU-1220/1410/1420 on board WDT driver
 | |
|  *
 | |
|  *	(c) Copyright 2001 Ascensit <support@ascensit.com>
 | |
|  *	(c) Copyright 2001 Rodolfo Giometti <giometti@ascensit.com>
 | |
|  *	(c) Copyright 2002 Rob Radez <rob@osinvestor.com>
 | |
|  *
 | |
|  *	Based on wdt.c.
 | |
|  *	Original copyright messages:
 | |
|  *
 | |
|  *	(c) Copyright 1996-1997 Alan Cox <alan@lxorguk.ukuu.org.uk>,
 | |
|  *						All Rights Reserved.
 | |
|  *
 | |
|  *	This program is free software; you can redistribute it and/or
 | |
|  *	modify it under the terms of the GNU General Public License
 | |
|  *	as published by the Free Software Foundation; either version
 | |
|  *	2 of the License, or (at your option) any later version.
 | |
|  *
 | |
|  *	Neither Alan Cox nor CymruNet Ltd. admit liability nor provide
 | |
|  *	warranty for any of this software. This material is provided
 | |
|  *	"AS-IS" and at no charge.
 | |
|  *
 | |
|  *	(c) Copyright 1995    Alan Cox <alan@lxorguk.ukuu.org.uk>*
 | |
|  */
 | |
| 
 | |
| /* Changelog:
 | |
|  *
 | |
|  * 2001 - Rodolfo Giometti
 | |
|  *	Initial release
 | |
|  *
 | |
|  * 2002/04/25 - Rob Radez
 | |
|  *	clean up #includes
 | |
|  *	clean up locking
 | |
|  *	make __setup param unique
 | |
|  *	proper options in watchdog_info
 | |
|  *	add WDIOC_GETSTATUS and WDIOC_SETOPTIONS ioctls
 | |
|  *	add expect_close support
 | |
|  *
 | |
|  * 2002.05.30 - Joel Becker <joel.becker@oracle.com>
 | |
|  *	Added Matt Domsch's nowayout module option.
 | |
|  */
 | |
| 
 | |
| /*
 | |
|  *	The eurotech CPU-1220/1410/1420's watchdog is a part
 | |
|  *	of the on-board SUPER I/O device SMSC FDC 37B782.
 | |
|  */
 | |
| 
 | |
| #define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
 | |
| 
 | |
| #include <linux/interrupt.h>
 | |
| #include <linux/module.h>
 | |
| #include <linux/moduleparam.h>
 | |
| #include <linux/types.h>
 | |
| #include <linux/miscdevice.h>
 | |
| #include <linux/watchdog.h>
 | |
| #include <linux/fs.h>
 | |
| #include <linux/ioport.h>
 | |
| #include <linux/notifier.h>
 | |
| #include <linux/reboot.h>
 | |
| #include <linux/init.h>
 | |
| #include <linux/io.h>
 | |
| #include <linux/uaccess.h>
 | |
| 
 | |
| 
 | |
| static unsigned long eurwdt_is_open;
 | |
| static int eurwdt_timeout;
 | |
| static char eur_expect_close;
 | |
| static DEFINE_SPINLOCK(eurwdt_lock);
 | |
| 
 | |
| /*
 | |
|  * You must set these - there is no sane way to probe for this board.
 | |
|  */
 | |
| 
 | |
| static int io = 0x3f0;
 | |
| static int irq = 10;
 | |
| static char *ev = "int";
 | |
| 
 | |
| #define WDT_TIMEOUT		60                /* 1 minute */
 | |
| 
 | |
| static bool nowayout = WATCHDOG_NOWAYOUT;
 | |
| module_param(nowayout, bool, 0);
 | |
| MODULE_PARM_DESC(nowayout,
 | |
| 		"Watchdog cannot be stopped once started (default="
 | |
| 				__MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
 | |
| 
 | |
| /*
 | |
|  * Some symbolic names
 | |
|  */
 | |
| 
 | |
| #define WDT_CTRL_REG		0x30
 | |
| #define WDT_OUTPIN_CFG		0xe2
 | |
| #define WDT_EVENT_INT		0x00
 | |
| #define WDT_EVENT_REBOOT	0x08
 | |
| #define WDT_UNIT_SEL		0xf1
 | |
| #define WDT_UNIT_SECS		0x80
 | |
| #define WDT_TIMEOUT_VAL		0xf2
 | |
| #define WDT_TIMER_CFG		0xf3
 | |
| 
 | |
| 
 | |
| module_param_hw(io, int, ioport, 0);
 | |
| MODULE_PARM_DESC(io, "Eurotech WDT io port (default=0x3f0)");
 | |
| module_param_hw(irq, int, irq, 0);
 | |
| MODULE_PARM_DESC(irq, "Eurotech WDT irq (default=10)");
 | |
| module_param(ev, charp, 0);
 | |
| MODULE_PARM_DESC(ev, "Eurotech WDT event type (default is `int')");
 | |
| 
 | |
| 
 | |
| /*
 | |
|  * Programming support
 | |
|  */
 | |
| 
 | |
| static inline void eurwdt_write_reg(u8 index, u8 data)
 | |
| {
 | |
| 	outb(index, io);
 | |
| 	outb(data, io+1);
 | |
| }
 | |
| 
 | |
| static inline void eurwdt_lock_chip(void)
 | |
| {
 | |
| 	outb(0xaa, io);
 | |
| }
 | |
| 
 | |
| static inline void eurwdt_unlock_chip(void)
 | |
| {
 | |
| 	outb(0x55, io);
 | |
| 	eurwdt_write_reg(0x07, 0x08);	/* set the logical device */
 | |
| }
 | |
| 
 | |
| static inline void eurwdt_set_timeout(int timeout)
 | |
| {
 | |
| 	eurwdt_write_reg(WDT_TIMEOUT_VAL, (u8) timeout);
 | |
| }
 | |
| 
 | |
| static inline void eurwdt_disable_timer(void)
 | |
| {
 | |
| 	eurwdt_set_timeout(0);
 | |
| }
 | |
| 
 | |
| static void eurwdt_activate_timer(void)
 | |
| {
 | |
| 	eurwdt_disable_timer();
 | |
| 	eurwdt_write_reg(WDT_CTRL_REG, 0x01);	/* activate the WDT */
 | |
| 	eurwdt_write_reg(WDT_OUTPIN_CFG,
 | |
| 		!strcmp("int", ev) ? WDT_EVENT_INT : WDT_EVENT_REBOOT);
 | |
| 
 | |
| 	/* Setting interrupt line */
 | |
| 	if (irq == 2 || irq > 15 || irq < 0) {
 | |
| 		pr_err("invalid irq number\n");
 | |
| 		irq = 0;	/* if invalid we disable interrupt */
 | |
| 	}
 | |
| 	if (irq == 0)
 | |
| 		pr_info("interrupt disabled\n");
 | |
| 
 | |
| 	eurwdt_write_reg(WDT_TIMER_CFG, irq << 4);
 | |
| 
 | |
| 	eurwdt_write_reg(WDT_UNIT_SEL, WDT_UNIT_SECS);	/* we use seconds */
 | |
| 	eurwdt_set_timeout(0);	/* the default timeout */
 | |
| }
 | |
| 
 | |
| 
 | |
| /*
 | |
|  * Kernel methods.
 | |
|  */
 | |
| 
 | |
| static irqreturn_t eurwdt_interrupt(int irq, void *dev_id)
 | |
| {
 | |
| 	pr_crit("timeout WDT timeout\n");
 | |
| 
 | |
| #ifdef ONLY_TESTING
 | |
| 	pr_crit("Would Reboot\n");
 | |
| #else
 | |
| 	pr_crit("Initiating system reboot\n");
 | |
| 	emergency_restart();
 | |
| #endif
 | |
| 	return IRQ_HANDLED;
 | |
| }
 | |
| 
 | |
| 
 | |
| /**
 | |
|  * eurwdt_ping:
 | |
|  *
 | |
|  * Reload counter one with the watchdog timeout.
 | |
|  */
 | |
| 
 | |
| static void eurwdt_ping(void)
 | |
| {
 | |
| 	/* Write the watchdog default value */
 | |
| 	eurwdt_set_timeout(eurwdt_timeout);
 | |
| }
 | |
| 
 | |
| /**
 | |
|  * eurwdt_write:
 | |
|  * @file: file handle to the watchdog
 | |
|  * @buf: buffer to write (unused as data does not matter here
 | |
|  * @count: count of bytes
 | |
|  * @ppos: pointer to the position to write. No seeks allowed
 | |
|  *
 | |
|  * A write to a watchdog device is defined as a keepalive signal. Any
 | |
|  * write of data will do, as we we don't define content meaning.
 | |
|  */
 | |
| 
 | |
| static ssize_t eurwdt_write(struct file *file, const char __user *buf,
 | |
| size_t count, loff_t *ppos)
 | |
| {
 | |
| 	if (count) {
 | |
| 		if (!nowayout) {
 | |
| 			size_t i;
 | |
| 
 | |
| 			eur_expect_close = 0;
 | |
| 
 | |
| 			for (i = 0; i != count; i++) {
 | |
| 				char c;
 | |
| 				if (get_user(c, buf + i))
 | |
| 					return -EFAULT;
 | |
| 				if (c == 'V')
 | |
| 					eur_expect_close = 42;
 | |
| 			}
 | |
| 		}
 | |
| 		spin_lock(&eurwdt_lock);
 | |
| 		eurwdt_ping();	/* the default timeout */
 | |
| 		spin_unlock(&eurwdt_lock);
 | |
| 	}
 | |
| 	return count;
 | |
| }
 | |
| 
 | |
| /**
 | |
|  * eurwdt_ioctl:
 | |
|  * @file: file handle to the device
 | |
|  * @cmd: watchdog command
 | |
|  * @arg: argument pointer
 | |
|  *
 | |
|  * The watchdog API defines a common set of functions for all watchdogs
 | |
|  * according to their available features.
 | |
|  */
 | |
| 
 | |
| static long eurwdt_ioctl(struct file *file,
 | |
| 					unsigned int cmd, unsigned long arg)
 | |
| {
 | |
| 	void __user *argp = (void __user *)arg;
 | |
| 	int __user *p = argp;
 | |
| 	static const struct watchdog_info ident = {
 | |
| 		.options	  = WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT
 | |
| 							| WDIOF_MAGICCLOSE,
 | |
| 		.firmware_version = 1,
 | |
| 		.identity	  = "WDT Eurotech CPU-1220/1410",
 | |
| 	};
 | |
| 
 | |
| 	int time;
 | |
| 	int options, retval = -EINVAL;
 | |
| 
 | |
| 	switch (cmd) {
 | |
| 	case WDIOC_GETSUPPORT:
 | |
| 		return copy_to_user(argp, &ident, sizeof(ident)) ? -EFAULT : 0;
 | |
| 
 | |
| 	case WDIOC_GETSTATUS:
 | |
| 	case WDIOC_GETBOOTSTATUS:
 | |
| 		return put_user(0, p);
 | |
| 
 | |
| 	case WDIOC_SETOPTIONS:
 | |
| 		if (get_user(options, p))
 | |
| 			return -EFAULT;
 | |
| 		spin_lock(&eurwdt_lock);
 | |
| 		if (options & WDIOS_DISABLECARD) {
 | |
| 			eurwdt_disable_timer();
 | |
| 			retval = 0;
 | |
| 		}
 | |
| 		if (options & WDIOS_ENABLECARD) {
 | |
| 			eurwdt_activate_timer();
 | |
| 			eurwdt_ping();
 | |
| 			retval = 0;
 | |
| 		}
 | |
| 		spin_unlock(&eurwdt_lock);
 | |
| 		return retval;
 | |
| 
 | |
| 	case WDIOC_KEEPALIVE:
 | |
| 		spin_lock(&eurwdt_lock);
 | |
| 		eurwdt_ping();
 | |
| 		spin_unlock(&eurwdt_lock);
 | |
| 		return 0;
 | |
| 
 | |
| 	case WDIOC_SETTIMEOUT:
 | |
| 		if (copy_from_user(&time, p, sizeof(int)))
 | |
| 			return -EFAULT;
 | |
| 
 | |
| 		/* Sanity check */
 | |
| 		if (time < 0 || time > 255)
 | |
| 			return -EINVAL;
 | |
| 
 | |
| 		spin_lock(&eurwdt_lock);
 | |
| 		eurwdt_timeout = time;
 | |
| 		eurwdt_set_timeout(time);
 | |
| 		spin_unlock(&eurwdt_lock);
 | |
| 		/* fall through */
 | |
| 
 | |
| 	case WDIOC_GETTIMEOUT:
 | |
| 		return put_user(eurwdt_timeout, p);
 | |
| 
 | |
| 	default:
 | |
| 		return -ENOTTY;
 | |
| 	}
 | |
| }
 | |
| 
 | |
| /**
 | |
|  * eurwdt_open:
 | |
|  * @inode: inode of device
 | |
|  * @file: file handle to device
 | |
|  *
 | |
|  * The misc device has been opened. The watchdog device is single
 | |
|  * open and on opening we load the counter.
 | |
|  */
 | |
| 
 | |
| static int eurwdt_open(struct inode *inode, struct file *file)
 | |
| {
 | |
| 	if (test_and_set_bit(0, &eurwdt_is_open))
 | |
| 		return -EBUSY;
 | |
| 	eurwdt_timeout = WDT_TIMEOUT;	/* initial timeout */
 | |
| 	/* Activate the WDT */
 | |
| 	eurwdt_activate_timer();
 | |
| 	return stream_open(inode, file);
 | |
| }
 | |
| 
 | |
| /**
 | |
|  * eurwdt_release:
 | |
|  * @inode: inode to board
 | |
|  * @file: file handle to board
 | |
|  *
 | |
|  * The watchdog has a configurable API. There is a religious dispute
 | |
|  * between people who want their watchdog to be able to shut down and
 | |
|  * those who want to be sure if the watchdog manager dies the machine
 | |
|  * reboots. In the former case we disable the counters, in the latter
 | |
|  * case you have to open it again very soon.
 | |
|  */
 | |
| 
 | |
| static int eurwdt_release(struct inode *inode, struct file *file)
 | |
| {
 | |
| 	if (eur_expect_close == 42)
 | |
| 		eurwdt_disable_timer();
 | |
| 	else {
 | |
| 		pr_crit("Unexpected close, not stopping watchdog!\n");
 | |
| 		eurwdt_ping();
 | |
| 	}
 | |
| 	clear_bit(0, &eurwdt_is_open);
 | |
| 	eur_expect_close = 0;
 | |
| 	return 0;
 | |
| }
 | |
| 
 | |
| /**
 | |
|  * eurwdt_notify_sys:
 | |
|  * @this: our notifier block
 | |
|  * @code: the event being reported
 | |
|  * @unused: unused
 | |
|  *
 | |
|  * Our notifier is called on system shutdowns. We want to turn the card
 | |
|  * off at reboot otherwise the machine will reboot again during memory
 | |
|  * test or worse yet during the following fsck. This would suck, in fact
 | |
|  * trust me - if it happens it does suck.
 | |
|  */
 | |
| 
 | |
| static int eurwdt_notify_sys(struct notifier_block *this, unsigned long code,
 | |
| 	void *unused)
 | |
| {
 | |
| 	if (code == SYS_DOWN || code == SYS_HALT)
 | |
| 		eurwdt_disable_timer();	/* Turn the card off */
 | |
| 
 | |
| 	return NOTIFY_DONE;
 | |
| }
 | |
| 
 | |
| /*
 | |
|  * Kernel Interfaces
 | |
|  */
 | |
| 
 | |
| 
 | |
| static const struct file_operations eurwdt_fops = {
 | |
| 	.owner		= THIS_MODULE,
 | |
| 	.llseek		= no_llseek,
 | |
| 	.write		= eurwdt_write,
 | |
| 	.unlocked_ioctl	= eurwdt_ioctl,
 | |
| 	.open		= eurwdt_open,
 | |
| 	.release	= eurwdt_release,
 | |
| };
 | |
| 
 | |
| static struct miscdevice eurwdt_miscdev = {
 | |
| 	.minor	= WATCHDOG_MINOR,
 | |
| 	.name	= "watchdog",
 | |
| 	.fops	= &eurwdt_fops,
 | |
| };
 | |
| 
 | |
| /*
 | |
|  * The WDT card needs to learn about soft shutdowns in order to
 | |
|  * turn the timebomb registers off.
 | |
|  */
 | |
| 
 | |
| static struct notifier_block eurwdt_notifier = {
 | |
| 	.notifier_call = eurwdt_notify_sys,
 | |
| };
 | |
| 
 | |
| /**
 | |
|  * cleanup_module:
 | |
|  *
 | |
|  * Unload the watchdog. You cannot do this with any file handles open.
 | |
|  * If your watchdog is set to continue ticking on close and you unload
 | |
|  * it, well it keeps ticking. We won't get the interrupt but the board
 | |
|  * will not touch PC memory so all is fine. You just have to load a new
 | |
|  * module in 60 seconds or reboot.
 | |
|  */
 | |
| 
 | |
| static void __exit eurwdt_exit(void)
 | |
| {
 | |
| 	eurwdt_lock_chip();
 | |
| 
 | |
| 	misc_deregister(&eurwdt_miscdev);
 | |
| 
 | |
| 	unregister_reboot_notifier(&eurwdt_notifier);
 | |
| 	release_region(io, 2);
 | |
| 	free_irq(irq, NULL);
 | |
| }
 | |
| 
 | |
| /**
 | |
|  * eurwdt_init:
 | |
|  *
 | |
|  * Set up the WDT watchdog board. After grabbing the resources
 | |
|  * we require we need also to unlock the device.
 | |
|  * The open() function will actually kick the board off.
 | |
|  */
 | |
| 
 | |
| static int __init eurwdt_init(void)
 | |
| {
 | |
| 	int ret;
 | |
| 
 | |
| 	ret = request_irq(irq, eurwdt_interrupt, 0, "eurwdt", NULL);
 | |
| 	if (ret) {
 | |
| 		pr_err("IRQ %d is not free\n", irq);
 | |
| 		goto out;
 | |
| 	}
 | |
| 
 | |
| 	if (!request_region(io, 2, "eurwdt")) {
 | |
| 		pr_err("IO %X is not free\n", io);
 | |
| 		ret = -EBUSY;
 | |
| 		goto outirq;
 | |
| 	}
 | |
| 
 | |
| 	ret = register_reboot_notifier(&eurwdt_notifier);
 | |
| 	if (ret) {
 | |
| 		pr_err("can't register reboot notifier (err=%d)\n", ret);
 | |
| 		goto outreg;
 | |
| 	}
 | |
| 
 | |
| 	ret = misc_register(&eurwdt_miscdev);
 | |
| 	if (ret) {
 | |
| 		pr_err("can't misc_register on minor=%d\n", WATCHDOG_MINOR);
 | |
| 		goto outreboot;
 | |
| 	}
 | |
| 
 | |
| 	eurwdt_unlock_chip();
 | |
| 
 | |
| 	ret = 0;
 | |
| 	pr_info("Eurotech WDT driver 0.01 at %X (Interrupt %d) - timeout event: %s\n",
 | |
| 		io, irq, (!strcmp("int", ev) ? "int" : "reboot"));
 | |
| 
 | |
| out:
 | |
| 	return ret;
 | |
| 
 | |
| outreboot:
 | |
| 	unregister_reboot_notifier(&eurwdt_notifier);
 | |
| 
 | |
| outreg:
 | |
| 	release_region(io, 2);
 | |
| 
 | |
| outirq:
 | |
| 	free_irq(irq, NULL);
 | |
| 	goto out;
 | |
| }
 | |
| 
 | |
| module_init(eurwdt_init);
 | |
| module_exit(eurwdt_exit);
 | |
| 
 | |
| MODULE_AUTHOR("Rodolfo Giometti");
 | |
| MODULE_DESCRIPTION("Driver for Eurotech CPU-1220/1410 on board watchdog");
 | |
| MODULE_LICENSE("GPL");
 |