nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity

Bug 1519636 - Reformat recent changes to the Google coding style r=andi

Browse source 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D85678
This commit is contained in:
Sylvestre Ledru 2020-08-02 15:29:15 +00:00
parent 964bac7f10
commit 843f943758
72 changed files with 145 additions and 156 deletions
repo.diff.show_diff_stats Download patch file Download diff file Expand all files Collapse all files

1
devtools/shared/heapsnapshot/AutoMemMap.h
View file

@ -33,7 +33,6 @@ namespace devtools {
// }
// // The memory is automatically unmapped when the AutoMemMap leaves scope.
class MOZ_RAII AutoMemMap {
PRFileInfo64 fileInfo;
PRFileDesc* fd;
PRFileMap* fileMap;

1
docshell/base/timeline/AutoGlobalTimelineMarker.h
View file

@ -27,7 +27,6 @@ namespace mozilla {
// ...
// }
class MOZ_RAII AutoGlobalTimelineMarker {
// The name of the marker we are adding.
const char* mName;
// Whether to capture the JS stack or not.

1
docshell/base/timeline/AutoRestyleTimelineMarker.h
View file

@ -14,7 +14,6 @@ class nsIDocShell;
namespace mozilla {
class MOZ_RAII AutoRestyleTimelineMarker {
RefPtr<nsIDocShell> mDocShell;
bool mIsAnimationOnly;

1
docshell/base/timeline/AutoTimelineMarker.h
View file

@ -27,7 +27,6 @@ namespace mozilla {
// ...
// }
class MOZ_RAII AutoTimelineMarker {
// The name of the marker we are adding.
const char* mName;

1
docshell/shistory/nsSHistory.h
View file

@ -231,7 +231,6 @@ class nsSHistory : public mozilla::LinkedListElement<nsSHistory>,
nsISHEntry* aNewEntry);
protected:
bool mHasOngoingUpdate;
bool mIsRemote;
nsTArray<nsCOMPtr<nsISHEntry>> mEntries; // entries are never null

1
dom/base/Selection.h
View file

@ -917,6 +917,7 @@ class MOZ_STACK_CLASS SelectionBatcher final {
class MOZ_RAII AutoHideSelectionChanges final {
private:
RefPtr<Selection> mSelection;
public:
explicit AutoHideSelectionChanges(const nsFrameSelection* aFrame);

1
dom/base/nsGlobalWindowOuter.h
View file

@ -397,7 +397,6 @@ class nsGlobalWindowOuter final : public mozilla::dom::EventTarget,
~TemporarilyDisableDialogs();
private:
// Always an inner window; this is the window whose dialog state we messed
// with. We just want to keep it alive, because we plan to poke at its
// members in our destructor.

4
dom/base/nsImageLoadingContent.cpp
View file

@ -976,8 +976,8 @@ nsImageLoadingContent::LoadImageWithChannel(nsIChannel* aChannel,
// Do the load.
RefPtr<imgRequestProxy>& req = PrepareNextRequest(eImageLoadType_Normal);
nsresult rv = loader->LoadImageWithChannel(aChannel, this, doc,
aListener, getter_AddRefs(req));
nsresult rv = loader->LoadImageWithChannel(aChannel, this, doc, aListener,
getter_AddRefs(req));
if (NS_SUCCEEDED(rv)) {
CloneScriptedRequests(req);
TrackImage(req);

6
dom/bindings/TypedArray.h
View file

@ -12,9 +12,9 @@
#include "js/ArrayBuffer.h"
#include "js/ArrayBufferMaybeShared.h"
#include "js/experimental/TypedData.h" // js::Unwrap(Ui|I)nt(8|16|32)Array, js::Get(Ui|I)nt(8|16|32)ArrayLengthAndData, js::UnwrapUint8ClampedArray, js::GetUint8ClampedArrayLengthAndData, js::UnwrapFloat(32|64)Array, js::GetFloat(32|64)ArrayLengthAndData, JS_GetArrayBufferViewType
#include "js/GCAPI.h" // JS::AutoCheckCannotGC
#include "js/RootingAPI.h" // JS::Rooted
#include "js/ScalarType.h" // js::Scalar::Type
#include "js/GCAPI.h" // JS::AutoCheckCannotGC
#include "js/RootingAPI.h" // JS::Rooted
#include "js/ScalarType.h" // js::Scalar::Type
#include "js/SharedArrayBuffer.h"
#include "mozilla/Attributes.h"
#include "mozilla/dom/BindingDeclarations.h"

1
dom/canvas/WebGLChild.h
View file

@ -37,6 +37,7 @@ class WebGLChild final : public PWebGLChild, public SupportsWeakPtr {
webgl::RaiiShmem mPendingCmdsShmem;
size_t mPendingCmdsPos = 0;
FlushedCmdInfo mFlushedCmdInfo;
public:
NS_INLINE_DECL_THREADSAFE_REFCOUNTING(WebGLChild, override);
using OtherSideActor = WebGLParent;

3
dom/canvas/WebGLIpdl.h
View file

@ -12,7 +12,8 @@
namespace mozilla {
namespace webgl {
// TODO: This should probably replace Shmem, or at least this should move to ipc/glue.
// TODO: This should probably replace Shmem, or at least this should move to
// ipc/glue.
class RaiiShmem final {
RefPtr<mozilla::ipc::ActorLifecycleProxy> mWeakRef;
mozilla::ipc::Shmem mShmem = {};

2
dom/canvas/WebGLParent.h
View file

@ -18,7 +18,7 @@ class HostWebGLContext;
namespace layers {
class SharedSurfaceTextureClient;
class SurfaceDescriptor;
}
} // namespace layers
namespace dom {

16
dom/gamepad/GamepadRemapping.cpp
View file

@ -342,12 +342,14 @@ class StadiaControllerRemapper final : public GamepadRemapper {
break;
case 4: {
const double value = AxisToButtonValue(aValue);
service->NewButtonEvent(aIndex, BUTTON_INDEX_LEFT_TRIGGER, value > BUTTON_THRESHOLD_VALUE, value);
service->NewButtonEvent(aIndex, BUTTON_INDEX_LEFT_TRIGGER,
value > BUTTON_THRESHOLD_VALUE, value);
break;
}
case 5: {
const double value = AxisToButtonValue(aValue);
service->NewButtonEvent(aIndex, BUTTON_INDEX_RIGHT_TRIGGER, value > BUTTON_THRESHOLD_VALUE, value);
service->NewButtonEvent(aIndex, BUTTON_INDEX_RIGHT_TRIGGER,
value > BUTTON_THRESHOLD_VALUE, value);
break;
}
default:
@ -420,7 +422,8 @@ class Playstation3Remapper final : public GamepadRemapper {
default:
NS_WARNING(
nsPrintfCString(
"Axis idx '%d' doesn't support in Playstation3Remapper().", aAxis)
"Axis idx '%d' doesn't support in Playstation3Remapper().",
aAxis)
.get());
break;
}
@ -594,13 +597,13 @@ class Dualshock4Remapper final : public GamepadRemapper {
const double value = AxisToButtonValue(aValue);
service->NewButtonEvent(aIndex, BUTTON_INDEX_LEFT_TRIGGER,
value > BUTTON_THRESHOLD_VALUE, value);
break;
break;
}
case 4: {
const double value = AxisToButtonValue(aValue);
service->NewButtonEvent(aIndex, BUTTON_INDEX_RIGHT_TRIGGER,
value > BUTTON_THRESHOLD_VALUE, value);
break;
break;
}
case 5:
service->NewAxisMoveEvent(aIndex, AXIS_INDEX_RIGHT_STICK_Y, aValue);
@ -1723,7 +1726,8 @@ already_AddRefed<GamepadRemapper> GetGamepadRemapper(const uint16_t aVendorId,
{GamepadId::kPadixProduct2060, new IBuffaloRemapper()},
{GamepadId::kPlayComProduct0005, new XSkillsRemapper()},
{GamepadId::kPrototypeVendorProduct0667, new BoomN64PsxRemapper()},
{GamepadId::kPrototypeVendorProduct9401, new StadiaControllerOldFirmwareRemapper()},
{GamepadId::kPrototypeVendorProduct9401,
new StadiaControllerOldFirmwareRemapper()},
{GamepadId::kRazer1532Product0900, new RazerServalRemapper()},
{GamepadId::kSonyProduct0268, new Playstation3Remapper()},
{GamepadId::kSonyProduct05c4, new Dualshock4Remapper()},

6
dom/html/HTMLImageElement.cpp
View file

@ -751,9 +751,9 @@ nsresult HTMLImageElement::CopyInnerTo(HTMLImageElement* aDest) {
// initaiated by a user interaction.
mUseUrgentStartForChannel = UserActivation::IsHandlingUserInput();
nsContentUtils::AddScriptRunner(NewRunnableMethod<bool>(
"dom::HTMLImageElement::MaybeLoadImage", aDest,
&HTMLImageElement::MaybeLoadImage, false));
nsContentUtils::AddScriptRunner(
NewRunnableMethod<bool>("dom::HTMLImageElement::MaybeLoadImage", aDest,
&HTMLImageElement::MaybeLoadImage, false));
}
return NS_OK;

4
dom/media/VideoUtils.cpp
View file

@ -290,8 +290,8 @@ bool ExtractVPXCodecDetails(const nsAString& aCodec, uint8_t& aProfile,
// No more than 8 fields are expected.
return false;
}
*(fields[fieldsCount]) = static_cast<uint8_t>(
(*fieldsItr).ToInteger(&rv, 10));
*(fields[fieldsCount]) =
static_cast<uint8_t>((*fieldsItr).ToInteger(&rv, 10));
// We got invalid field value, parsing error.
NS_ENSURE_SUCCESS(rv, false);
}

2
dom/media/webaudio/AudioBuffer.cpp
View file

@ -7,7 +7,7 @@
#include "AudioBuffer.h"
#include "mozilla/dom/AudioBufferBinding.h"
#include "jsfriendapi.h"
#include "js/ArrayBuffer.h" // JS::StealArrayBufferContents
#include "js/ArrayBuffer.h" // JS::StealArrayBufferContents
#include "js/experimental/TypedData.h" // JS_NewFloat32Array, JS_GetFloat32ArrayData, JS_GetTypedArrayLength, JS_GetArrayBufferViewBuffer
#include "mozilla/ErrorResult.h"
#include "AudioSegment.h"

2
dom/script/ScriptSettings.cpp
View file

@ -708,7 +708,6 @@ AutoJSContext::AutoJSContext() : mCx(nullptr) {
MOZ_ASSERT(!mCx, "mCx should not be initialized!");
MOZ_ASSERT(NS_IsMainThread());
if (dom::IsJSAPIActive()) {
mCx = dom::danger::GetJSContext();
} else {
@ -722,7 +721,6 @@ AutoJSContext::operator JSContext*() const { return mCx; }
AutoSafeJSContext::AutoSafeJSContext() : AutoJSAPI() {
MOZ_ASSERT(NS_IsMainThread());
DebugOnly<bool> ok = Init(xpc::UnprivilegedJunkScope());
MOZ_ASSERT(ok,
"This is quite odd. We should have crashed in the "

4
dom/simpledb/SDBConnection.cpp
View file

@ -9,8 +9,8 @@
#include "ActorsChild.h"
#include "js/ArrayBuffer.h" // JS::{GetObjectAsArrayBuffer,IsArrayBufferObject}
#include "js/experimental/TypedData.h" // JS_IsArrayBufferViewObject, JS_GetObjectAsArrayBufferView
#include "js/RootingAPI.h" // JS::{Handle,Rooted}
#include "js/Value.h" // JS::Value
#include "js/RootingAPI.h" // JS::{Handle,Rooted}
#include "js/Value.h" // JS::Value
#include "mozilla/ipc/BackgroundChild.h"
#include "mozilla/ipc/BackgroundParent.h"
#include "mozilla/ipc/BackgroundUtils.h"

1
editor/libeditor/HTMLEditSubActionHandler.cpp
View file

@ -101,7 +101,6 @@ static bool IsStyleCachePreservingSubAction(EditSubAction aEditSubAction) {
}
class MOZ_RAII AutoSetTemporaryAncestorLimiter final {
public:
explicit AutoSetTemporaryAncestorLimiter(HTMLEditor& aHTMLEditor,
Selection& aSelection,

2
gfx/config/gfxConfigManager.cpp
View file

@ -271,7 +271,7 @@ void gfxConfigManager::ConfigureWebRender() {
if (mXRenderEnabled) {
// XRender and WebRender don't play well together. XRender is disabled by
// default. If the user opts into it don't enable webrender.
mFeatureWr->ForceDisable(FeatureStatus::Blocked,"XRender is enabled",
mFeatureWr->ForceDisable(FeatureStatus::Blocked, "XRender is enabled",
"FEATURE_FAILURE_XRENDER"_ns);
}

1
gfx/layers/client/TextureClient.h
View file

@ -784,7 +784,6 @@ class TextureClientReleaseTask : public Runnable {
// Automatically lock and unlock a texture. Since texture locking is fallible,
// Succeeded() must be checked on the guard object before proceeding.
class MOZ_RAII TextureClientAutoLock {
public:
TextureClientAutoLock(TextureClient* aTexture, OpenMode aMode)
: mTexture(aTexture), mSucceeded(false) {

2
gfx/layers/wr/OMTASampler.h
View file

@ -10,7 +10,7 @@
#include <unordered_map>
#include <queue>
#include "base/platform_thread.h" // for PlatformThreadId
#include "base/platform_thread.h" // for PlatformThreadId
#include "mozilla/layers/OMTAController.h" // for OMTAController
#include "mozilla/Maybe.h"
#include "mozilla/StaticMutex.h"

1
gfx/tests/gtest/TestConfigManager.cpp
View file

@ -711,4 +711,3 @@ TEST_F(GfxConfigManager, WebRenderWhenXRenderEnabled) {
EXPECT_TRUE(mFeatures.mGPUProcess.IsEnabled());
EXPECT_TRUE(mFeatures.mD3D11HwAngle.IsEnabled());
}

3
image/imgRequestProxy.cpp
View file

@ -1069,7 +1069,8 @@ imgRequestProxy::GetStaticRequest(imgIRequest** aReturn) {
already_AddRefed<imgRequestProxy> imgRequestProxy::GetStaticRequest(
Document* aLoadingDocument) {
MOZ_DIAGNOSTIC_ASSERT(!aLoadingDocument || aLoadingDocument->IsStaticDocument());
MOZ_DIAGNOSTIC_ASSERT(!aLoadingDocument ||
aLoadingDocument->IsStaticDocument());
RefPtr<Image> image = GetImage();
bool animated;

3
image/imgRequestProxy.h
View file

@ -123,7 +123,8 @@ class imgRequestProxy : public mozilla::PreloaderBase,
Document* aLoadingDocument, imgRequestProxy** aClone);
nsresult Clone(imgINotificationObserver* aObserver,
Document* aLoadingDocument, imgRequestProxy** aClone);
already_AddRefed<imgRequestProxy> GetStaticRequest(Document* aLoadingDocument);
already_AddRefed<imgRequestProxy> GetStaticRequest(
Document* aLoadingDocument);
imgRequest* GetOwner() const;

12
ipc/glue/BackgroundChildImpl.cpp
View file

@ -139,12 +139,12 @@ void BackgroundChildImpl::ProcessingError(Result aCode, const char* aReason) {
abortMessage.AssignLiteral(#_result); \
break
HANDLE_CASE(MsgNotKnown);
HANDLE_CASE(MsgNotAllowed);
HANDLE_CASE(MsgPayloadError);
HANDLE_CASE(MsgProcessingError);
HANDLE_CASE(MsgRouteError);
HANDLE_CASE(MsgValueError);
HANDLE_CASE(MsgNotKnown);
HANDLE_CASE(MsgNotAllowed);
HANDLE_CASE(MsgPayloadError);
HANDLE_CASE(MsgProcessingError);
HANDLE_CASE(MsgRouteError);
HANDLE_CASE(MsgValueError);
#undef HANDLE_CASE

1
ipc/glue/Neutering.h
View file

@ -7,7 +7,6 @@
#ifndef mozilla_ipc_Neutering_h
#define mozilla_ipc_Neutering_h
/**
* This header declares RAII wrappers for Window neutering. See
* WindowsMessageLoop.cpp for more details.

1
js/src/builtin/FinalizationRegistryObject.h
View file

@ -187,6 +187,7 @@ class FinalizationRegistryObject : public NativeObject {
static bool cleanupQueuedRecords(JSContext* cx,
HandleFinalizationRegistryObject registry,
HandleObject callback = nullptr);
private:
static const JSClassOps classOps_;
static const ClassSpec classSpec_;

2
js/src/builtin/TestingFunctions.cpp
View file

@ -57,7 +57,7 @@
#include "js/Debug.h"
#include "js/experimental/TypedData.h" // JS_GetObjectAsUint8Array
#include "js/friend/DumpFunctions.h" // js::Dump{Backtrace,Heap,Object}, JS::FormatStackDump, js::IgnoreNurseryObjects
#include "js/friend/WindowProxy.h" // js::ToWindowProxyIfWindow
#include "js/friend/WindowProxy.h" // js::ToWindowProxyIfWindow
#include "js/HashTable.h"
#include "js/LocaleSensitive.h"
#include "js/PropertySpec.h"

4
js/src/builtin/streams/StreamAPI.cpp
View file

@ -11,9 +11,9 @@
#include <stdint.h> // uint32_t, uintptr_t
#include "jsapi.h" // js::AssertHeapIsIdle, JS_ReportErrorNumberASCII
#include "jsapi.h" // js::AssertHeapIsIdle, JS_ReportErrorNumberASCII
#include "jsfriendapi.h" // js::GetErrorMessage, js::IsObjectInContextCompartment, JSMSG_*
#include "jstypes.h" // JS_{FRIEND,PUBLIC}_API
#include "jstypes.h" // JS_{FRIEND,PUBLIC}_API
#include "builtin/Stream.h" // js::ReadableByteStreamController{,Close}, js::ReadableStreamDefaultController{,Close}, js::StreamController
#include "builtin/streams/ReadableStream.h" // js::ReadableStream

3
js/src/debugger/Debugger.cpp
View file

@ -2961,7 +2961,6 @@ class MOZ_RAII ExecutionObservableRealms
// don't match.
return iter.hasUsableAbstractFramePtr() && realms_.has(iter.realm());
}
};
// Given a particular AbstractFramePtr F that has become observable, this
@ -3025,7 +3024,6 @@ class MOZ_RAII ExecutionObservableFrame
return iter.hasUsableAbstractFramePtr() &&
iter.abstractFramePtr() == frame_;
}
};
class MOZ_RAII ExecutionObservableScript
@ -3057,7 +3055,6 @@ class MOZ_RAII ExecutionObservableScript
return iter.hasUsableAbstractFramePtr() && !iter.isWasm() &&
iter.abstractFramePtr().script() == script_;
}
};
/* static */

14
js/src/debugger/NoExecute.cpp
View file

@ -13,14 +13,14 @@
#include "jsapi.h" // for Handle
#include "jsfriendapi.h" // for DumpBacktrace, GetErrorMessage
#include "debugger/Debugger.h" // for Debugger
#include "gc/Barrier.h" // for GCPtrNativeObject
#include "debugger/Debugger.h" // for Debugger
#include "gc/Barrier.h" // for GCPtrNativeObject
#include "js/friend/DumpFunctions.h" // for DumpBacktrace
#include "js/Promise.h" // for AutoDebuggerJobQueueInterruption
#include "vm/JSContext.h" // for ProtectedDataContextArg, JSContext
#include "vm/JSScript.h" // for JSScript
#include "vm/Realm.h" // for AutoRealm, Realm
#include "vm/Warnings.h" // for WarnNumberLatin1
#include "js/Promise.h" // for AutoDebuggerJobQueueInterruption
#include "vm/JSContext.h" // for ProtectedDataContextArg, JSContext
#include "vm/JSScript.h" // for JSScript
#include "vm/Realm.h" // for AutoRealm, Realm
#include "vm/Warnings.h" // for WarnNumberLatin1
#include "vm/Realm-inl.h" // for AutoRealm::AutoRealm

72
js/src/debugger/Object.cpp
View file

@ -31,42 +31,42 @@
#include "gc/Tracer.h" // for TraceManuallyBarrieredCrossCompartmentEdge
#include "js/CompilationAndEvaluation.h" // for Compile
#include "js/Conversions.h" // for ToObject
#include "js/friend/WindowProxy.h" // for IsWindow, IsWindowProxy, ToWindowIfWindowProxy
#include "js/HeapAPI.h" // for IsInsideNursery
#include "js/Promise.h" // for PromiseState
#include "js/Proxy.h" // for PropertyDescriptor
#include "js/StableStringChars.h" // for AutoStableStringChars
#include "proxy/ScriptedProxyHandler.h" // for ScriptedProxyHandler
#include "vm/ArgumentsObject.h" // for ARGS_LENGTH_MAX
#include "vm/ArrayObject.h" // for ArrayObject
#include "vm/AsyncFunction.h" // for AsyncGeneratorObject
#include "vm/AsyncIteration.h" // for AsyncFunctionGeneratorObject
#include "vm/BytecodeUtil.h" // for JSDVG_SEARCH_STACK
#include "vm/Compartment.h" // for Compartment
#include "vm/EnvironmentObject.h" // for GetDebugEnvironmentForFunction
#include "vm/ErrorObject.h" // for JSObject::is, ErrorObject
#include "vm/GeneratorObject.h" // for AbstractGeneratorObject
#include "vm/GlobalObject.h" // for JSObject::is, GlobalObject
#include "vm/Instrumentation.h" // for RealmInstrumentation
#include "vm/Interpreter.h" // for Call
#include "vm/JSAtom.h" // for Atomize, js_apply_str
#include "vm/JSContext.h" // for JSContext, ReportValueError
#include "vm/JSFunction.h" // for JSFunction
#include "vm/JSScript.h" // for JSScript
#include "vm/NativeObject.h" // for NativeObject, JSObject::is
#include "vm/ObjectGroup.h" // for GenericObject, NewObjectKind
#include "vm/ObjectOperations.h" // for DefineProperty
#include "vm/PlainObject.h" // for js::PlainObject
#include "vm/PromiseObject.h" // for js::PromiseObject
#include "vm/Realm.h" // for AutoRealm, ErrorCopier, Realm
#include "vm/Runtime.h" // for JSAtomState
#include "vm/SavedFrame.h" // for SavedFrame
#include "vm/Scope.h" // for PositionalFormalParameterIter
#include "vm/SelfHosting.h" // for GetClonedSelfHostedFunctionName
#include "vm/Shape.h" // for Shape
#include "vm/Stack.h" // for InvokeArgs
#include "vm/StringType.h" // for JSAtom, PropertyName
#include "vm/WrapperObject.h" // for JSObject::is, WrapperObject
#include "js/friend/WindowProxy.h" // for IsWindow, IsWindowProxy, ToWindowIfWindowProxy
#include "js/HeapAPI.h" // for IsInsideNursery
#include "js/Promise.h" // for PromiseState
#include "js/Proxy.h" // for PropertyDescriptor
#include "js/StableStringChars.h" // for AutoStableStringChars
#include "proxy/ScriptedProxyHandler.h" // for ScriptedProxyHandler
#include "vm/ArgumentsObject.h" // for ARGS_LENGTH_MAX
#include "vm/ArrayObject.h" // for ArrayObject
#include "vm/AsyncFunction.h" // for AsyncGeneratorObject
#include "vm/AsyncIteration.h" // for AsyncFunctionGeneratorObject
#include "vm/BytecodeUtil.h" // for JSDVG_SEARCH_STACK
#include "vm/Compartment.h" // for Compartment
#include "vm/EnvironmentObject.h" // for GetDebugEnvironmentForFunction
#include "vm/ErrorObject.h" // for JSObject::is, ErrorObject
#include "vm/GeneratorObject.h" // for AbstractGeneratorObject
#include "vm/GlobalObject.h" // for JSObject::is, GlobalObject
#include "vm/Instrumentation.h" // for RealmInstrumentation
#include "vm/Interpreter.h" // for Call
#include "vm/JSAtom.h" // for Atomize, js_apply_str
#include "vm/JSContext.h" // for JSContext, ReportValueError
#include "vm/JSFunction.h" // for JSFunction
#include "vm/JSScript.h" // for JSScript
#include "vm/NativeObject.h" // for NativeObject, JSObject::is
#include "vm/ObjectGroup.h" // for GenericObject, NewObjectKind
#include "vm/ObjectOperations.h" // for DefineProperty
#include "vm/PlainObject.h" // for js::PlainObject
#include "vm/PromiseObject.h" // for js::PromiseObject
#include "vm/Realm.h" // for AutoRealm, ErrorCopier, Realm
#include "vm/Runtime.h" // for JSAtomState
#include "vm/SavedFrame.h" // for SavedFrame
#include "vm/Scope.h" // for PositionalFormalParameterIter
#include "vm/SelfHosting.h" // for GetClonedSelfHostedFunctionName
#include "vm/Shape.h" // for Shape
#include "vm/Stack.h" // for InvokeArgs
#include "vm/StringType.h" // for JSAtom, PropertyName
#include "vm/WrapperObject.h" // for JSObject::is, WrapperObject
#include "vm/Compartment-inl.h" // for Compartment::wrap
#include "vm/JSObject-inl.h" // for GetObjectClassName, InitClass, NewObjectWithGivenProtoAndKind, ToPropertyKey

2
js/src/debugger/Source.cpp
View file

@ -14,7 +14,7 @@
#include <string.h> // for memcpy
#include <utility> // for move
#include "jsapi.h" // for JS_ReportErrorNumberASCII, JS_CopyStringCharsZ
#include "jsapi.h" // for JS_ReportErrorNumberASCII, JS_CopyStringCharsZ
#include "debugger/Debugger.h" // for DebuggerSourceReferent, Debugger
#include "debugger/Script.h" // for DebuggerScript

3
js/src/gc/Marking.cpp
View file

@ -834,8 +834,7 @@ void GCMarker::severWeakDelegate(JSObject* key, JSObject* delegate) {
// 'delegate' is now the delegate of 'key'. Update weakmap marking state.
void GCMarker::restoreWeakDelegate(JSObject* key, JSObject* delegate) {
if (!key->zone()->needsIncrementalBarrier() ||
!delegate->zone()->needsIncrementalBarrier())
{
!delegate->zone()->needsIncrementalBarrier()) {
MOZ_ASSERT(!key->zone()->gcWeakKeys(key).get(key),
"non-collecting zone should not have populated gcWeakKeys");
return;

2
js/src/gc/Zone.cpp
View file

@ -485,7 +485,7 @@ void Zone::discardJitCode(JSFreeOp* fop,
}
void JS::Zone::beforeClearDelegateInternal(JSObject* wrapper,
JSObject* delegate) {
JSObject* delegate) {
MOZ_ASSERT(js::gc::detail::GetDelegate(wrapper) == delegate);
MOZ_ASSERT(needsIncrementalBarrier());
GCMarker::fromTracer(barrierTracer())->severWeakDelegate(wrapper, delegate);

2
js/src/jit/CacheIR.cpp
View file

@ -18,7 +18,7 @@
#include "jit/InlinableNatives.h"
#include "jit/Ion.h" // IsIonEnabled
#include "js/friend/WindowProxy.h" // js::IsWindow, js::IsWindowProxy, js::ToWindowIfWindowProxy
#include "js/ScalarType.h" // js::Scalar::Type
#include "js/ScalarType.h" // js::Scalar::Type
#include "util/Unicode.h"
#include "vm/PlainObject.h" // js::PlainObject
#include "vm/SelfHosting.h"

1
js/src/jit/Ion.h
View file

@ -120,7 +120,6 @@ class MOZ_RAII AutoEnterIonBackend {
jcx->leaveIonBackend();
}
#endif
};
bool OffThreadCompilationAvailable(JSContext* cx);

2
js/src/jsapi-tests/testArrayBufferView.cpp
View file

@ -4,7 +4,7 @@
#include "jsfriendapi.h"
#include "js/ArrayBuffer.h" // JS::NewArrayBuffer
#include "js/ArrayBuffer.h" // JS::NewArrayBuffer
#include "js/experimental/TypedData.h" // JS_GetArrayBufferView{Type,ByteLength,Data}, JS_GetObjectAsArrayBufferView, JS_GetObjectAs{{Ui,I}nt{8,16,32},Float{32,64}}Array, JS_IsArrayBufferViewObject, JS_NewDataView, JS_New{{Ui,I}nt{8,16,32},Float{32,64},Uint8Clamped}Array
#include "js/ScalarType.h" // js::Scalar::Type
#include "jsapi-tests/tests.h"

2
js/src/jsapi.h
View file

@ -419,7 +419,6 @@ class MOZ_RAII JS_PUBLIC_API JSAutoRealm {
JSAutoRealm(JSContext* cx, JSObject* target);
JSAutoRealm(JSContext* cx, JSScript* target);
~JSAutoRealm();
};
class MOZ_RAII JS_PUBLIC_API JSAutoNullableRealm {
@ -429,7 +428,6 @@ class MOZ_RAII JS_PUBLIC_API JSAutoNullableRealm {
public:
explicit JSAutoNullableRealm(JSContext* cx, JSObject* targetOrNull);
~JSAutoNullableRealm();
};
namespace JS {

4
js/src/jsexn.cpp
View file

@ -28,8 +28,8 @@
#include "js/CharacterEncoding.h"
#include "js/Class.h"
#include "js/Conversions.h"
#include "js/ErrorReport.h" // JS::PrintError
#include "js/Exception.h" // JS::ExceptionStack
#include "js/ErrorReport.h" // JS::PrintError
#include "js/Exception.h" // JS::ExceptionStack
#include "js/experimental/TypedData.h" // JS_IsArrayBufferViewObject
#include "js/SavedFrameAPI.h"
#include "js/UniquePtr.h"

2
js/src/shell/js.cpp
View file

@ -109,7 +109,7 @@
#include "js/friend/DumpFunctions.h" // JS::FormatStackDump
#include "js/friend/StackLimits.h" // js::CheckRecursionLimitConservative
#include "js/friend/WindowProxy.h" // js::IsWindowProxy, js::SetWindowProxyClass, js::ToWindowProxyIfWindow, js::ToWindowIfWindowProxy
#include "js/GCAPI.h" // JS::AutoCheckCannotGC
#include "js/GCAPI.h" // JS::AutoCheckCannotGC
#include "js/GCVector.h"
#include "js/Initialization.h"
#include "js/JSON.h"

6
js/src/shell/jsrtfuzzing/jsrtfuzzing.cpp
View file

@ -21,9 +21,9 @@
#include "js/ErrorReport.h" // JS::PrintError
#include "js/Exception.h" // JS::StealPendingExceptionStack
#include "js/experimental/TypedData.h" // JS_GetUint8ClampedArrayData, JS_NewUint8ClampedArray
#include "js/RootingAPI.h" // JS::Rooted
#include "js/SourceText.h" // JS::Source{Ownership,Text}
#include "js/Value.h" // JS::Value
#include "js/RootingAPI.h" // JS::Rooted
#include "js/SourceText.h" // JS::Source{Ownership,Text}
#include "js/Value.h" // JS::Value
#include "shell/jsshell.h" // js::shell::{reportWarnings,PrintStackTrace,sArg{c,v}}
#include "vm/Interpreter.h"
#include "vm/TypedArrayObject.h"

1
js/src/vm/EnvironmentObject.h
View file

@ -787,7 +787,6 @@ class MOZ_RAII EnvironmentIter {
}
AbstractFramePtr maybeInitialFrame() const { return frame_; }
};
// The key in MissingEnvironmentMap. For live frames, maps live frames to

2
js/src/vm/HelperThreads.cpp
View file

@ -16,7 +16,7 @@
#include "frontend/BytecodeCompilation.h"
#include "jit/IonCompileTask.h"
#include "js/ContextOptions.h" // JS::ContextOptions
#include "js/ContextOptions.h" // JS::ContextOptions
#include "js/friend/StackLimits.h" // js::ReportOverRecursed
#include "js/SourceText.h"
#include "js/UniquePtr.h"

2
js/src/vm/HelperThreads.h
View file

@ -670,7 +670,6 @@ void RunPendingSourceCompressions(JSRuntime* runtime);
class MOZ_RAII AutoLockHelperThreadState : public LockGuard<Mutex> {
using Base = LockGuard<Mutex>;
public:
explicit AutoLockHelperThreadState() : Base(HelperThreadState().helperLock) {}
};
@ -678,7 +677,6 @@ class MOZ_RAII AutoLockHelperThreadState : public LockGuard<Mutex> {
class MOZ_RAII AutoUnlockHelperThreadState : public UnlockGuard<Mutex> {
using Base = UnlockGuard<Mutex>;
public:
explicit AutoUnlockHelperThreadState(AutoLockHelperThreadState& locked)
: Base(locked) {}

2
js/src/vm/JSContext.cpp
View file

@ -41,7 +41,7 @@
#include "jit/Ion.h"
#include "jit/PcScriptCache.h"
#include "js/CharacterEncoding.h"
#include "js/ContextOptions.h" // JS::ContextOptions
#include "js/ContextOptions.h" // JS::ContextOptions
#include "js/friend/StackLimits.h" // js::ReportOverRecursed
#include "js/Printf.h"
#ifdef JS_SIMULATOR_ARM

1
js/src/vm/JSContext.h
View file

@ -1144,7 +1144,6 @@ class MOZ_RAII AutoLockScriptData {
#endif
}
}
};
// A token used to prove you can safely access the atoms zone. This zone is

2
js/src/vm/JSObject.cpp
View file

@ -37,7 +37,7 @@
#include "jit/BaselineJIT.h"
#include "js/CharacterEncoding.h"
#include "js/friend/DumpFunctions.h" // js::DumpObject
#include "js/friend/WindowProxy.h" // js::IsWindow, js::ToWindowProxyIfWindow
#include "js/friend/WindowProxy.h" // js::IsWindow, js::ToWindowProxyIfWindow
#include "js/MemoryMetrics.h"
#include "js/PropertyDescriptor.h" // JS::FromPropertyDescriptor
#include "js/PropertySpec.h" // JSPropertySpec

1
js/src/vm/Realm.h
View file

@ -192,7 +192,6 @@ using NewObjectMetadataState =
mozilla::Variant<ImmediateMetadata, DelayMetadata, PendingMetadata>;
class MOZ_RAII AutoSetNewObjectMetadata {
JSContext* cx_;
Rooted<NewObjectMetadataState> prevState_;

2
js/src/vm/SelfHosting.cpp
View file

@ -52,7 +52,7 @@
#include "js/ErrorReport.h" // JS::PrintError
#include "js/Exception.h"
#include "js/experimental/TypedData.h" // JS_GetArrayBufferViewType
#include "js/Modules.h" // JS::GetModulePrivate
#include "js/Modules.h" // JS::GetModulePrivate
#include "js/PropertySpec.h"
#include "js/ScalarType.h" // js::Scalar::Type
#include "js/SourceText.h" // JS::SourceText

12
js/src/vm/ToSource.cpp
View file

@ -14,13 +14,13 @@
#include "jsfriendapi.h" // CheckRecursionLimit, GetBuiltinClass
#include "builtin/Array.h" // ArrayToSource
#include "builtin/Boolean.h" // BooleanToString
#include "builtin/Object.h" // ObjectToSource
#include "gc/Allocator.h" // CanGC
#include "js/Class.h" // ESClass
#include "builtin/Array.h" // ArrayToSource
#include "builtin/Boolean.h" // BooleanToString
#include "builtin/Object.h" // ObjectToSource
#include "gc/Allocator.h" // CanGC
#include "js/Class.h" // ESClass
#include "js/friend/StackLimits.h" // js::CheckRecursionLimit
#include "js/Symbol.h" // SymbolCode, JS::WellKnownSymbolLimit
#include "js/Symbol.h" // SymbolCode, JS::WellKnownSymbolLimit
#include "js/TypeDecls.h" // Rooted{Function, Object, String, Value}, HandleValue, Latin1Char
#include "js/Utility.h" // UniqueChars
#include "js/Value.h" // JS::Value

2
js/src/wasm/WasmModule.cpp
View file

@ -23,7 +23,7 @@
#include "builtin/TypedObject.h"
#include "jit/JitOptions.h"
#include "js/BuildId.h" // JS::BuildIdCharVector
#include "js/BuildId.h" // JS::BuildIdCharVector
#include "js/experimental/TypedData.h" // JS_NewUint8Array
#include "threading/LockGuard.h"
#include "vm/PlainObject.h" // js::PlainObject

2
js/xpconnect/src/XPCJSRuntime.cpp
View file

@ -54,7 +54,7 @@
#include "js/UbiNode.h"
#include "js/UbiNodeUtils.h"
#include "js/friend/UsageStatistics.h" // JS_TELEMETRY_*, JS_SetAccumulateTelemetryCallback
#include "js/friend/WindowProxy.h" // js::SetWindowProxyClass
#include "js/friend/WindowProxy.h" // js::SetWindowProxyClass
#include "mozilla/dom/GeneratedAtomList.h"
#include "mozilla/dom/BindingUtils.h"
#include "mozilla/dom/Element.h"

2
js/xpconnect/src/XPCWrappedNative.cpp
View file

@ -9,7 +9,7 @@
#include "xpcprivate.h"
#include "nsWrapperCacheInlines.h"
#include "XPCLog.h"
#include "js/Array.h" // JS::GetArrayLength, JS::IsArrayObject
#include "js/Array.h" // JS::GetArrayLength, JS::IsArrayObject
#include "js/experimental/TypedData.h" // JS_GetTypedArrayLength, JS_IsTypedArrayObject
#include "js/MemoryFunctions.h"
#include "js/Printf.h"

2
js/xpconnect/wrappers/XrayWrapper.cpp
View file

@ -20,7 +20,7 @@
#include "jsapi.h"
#include "js/experimental/TypedData.h" // JS_GetTypedArrayLength
#include "js/friend/WindowProxy.h" // js::IsWindowProxy
#include "js/friend/WindowProxy.h" // js::IsWindowProxy
#include "js/PropertySpec.h"
#include "nsJSUtils.h"
#include "nsPrintfCString.h"

8
layout/base/ScrollStyles.cpp
View file

@ -12,7 +12,8 @@ namespace mozilla {
// https://drafts.csswg.org/css-overflow/#overflow-propagation
// "If `visible` is applied to the viewport, it must be interpreted as `auto`.
// If `clip` is applied to the viewport, it must be interpreted as `hidden`."
static StyleOverflow MapOverflowValueForViewportPropagation(StyleOverflow aOverflow) {
static StyleOverflow MapOverflowValueForViewportPropagation(
StyleOverflow aOverflow) {
switch (aOverflow) {
case StyleOverflow::Visible:
return StyleOverflow::Auto;
@ -35,8 +36,9 @@ ScrollStyles::ScrollStyles(StyleOverflow aH, StyleOverflow aV)
ScrollStyles::ScrollStyles(const nsStyleDisplay& aDisplay,
MapOverflowToValidScrollStyleTag)
: ScrollStyles(MapOverflowValueForViewportPropagation(aDisplay.mOverflowX),
MapOverflowValueForViewportPropagation(aDisplay.mOverflowY)) {}
: ScrollStyles(
MapOverflowValueForViewportPropagation(aDisplay.mOverflowX),
MapOverflowValueForViewportPropagation(aDisplay.mOverflowY)) {}
bool ScrollStyles::IsHiddenInBothDirections() const {
return mHorizontal == StyleOverflow::Hidden &&

3
layout/base/nsPresContext.cpp
View file

@ -1090,7 +1090,8 @@ static bool CheckOverflow(const ComputedStyle* aComputedStyle,
return false;
}
*aStyles = ScrollStyles(*display, ScrollStyles::MapOverflowToValidScrollStyle);
*aStyles =
ScrollStyles(*display, ScrollStyles::MapOverflowToValidScrollStyle);
return true;
}

6
layout/generic/nsIFrame.cpp
View file

@ -2664,7 +2664,7 @@ static void ApplyOverflowClipping(
// comboboxes which make their display text (an inline frame) have clipping.
MOZ_ASSERT(aClipAxes != nsIFrame::PhysicalAxes::None);
MOZ_ASSERT(aFrame->ShouldApplyOverflowClipping(aFrame->StyleDisplay()) ==
aClipAxes);
aClipAxes);
nsRect clipRect;
bool haveRadii = false;
@ -11105,10 +11105,10 @@ nsIFrame::PhysicalAxes nsIFrame::ShouldApplyOverflowClipping(
!PresContext()->ElementWouldPropagateScrollStyles(*element)) {
uint8_t axes = uint8_t(PhysicalAxes::None);
if (aDisp->mOverflowX == mozilla::StyleOverflow::Clip) {
axes |= uint8_t(PhysicalAxes::Horizontal);
axes |= uint8_t(PhysicalAxes::Horizontal);
}
if (aDisp->mOverflowY == mozilla::StyleOverflow::Clip) {
axes |= uint8_t(PhysicalAxes::Vertical);
axes |= uint8_t(PhysicalAxes::Vertical);
}
return PhysicalAxes(axes);
}

2
layout/printing/nsPrintJob.h
View file

@ -12,7 +12,7 @@
#include "nsCOMPtr.h"
#include "nsHashKeys.h"
#include "nsIFrame.h" // For WeakFrame
#include "nsIFrame.h" // For WeakFrame
#include "nsSize.h"
#include "nsTHashtable.h"
#include "nsWeakReference.h"

3
layout/style/ImageLoader.cpp
View file

@ -405,8 +405,7 @@ already_AddRefed<imgRequestProxy> ImageLoader::LoadImage(
RefPtr<imgRequestProxy> request;
nsresult rv = nsContentUtils::LoadImage(
uri, &aDocument, &aDocument, data.Principal(), 0, data.ReferrerInfo(),
sImageObserver, loadFlags, u"css"_ns,
getter_AddRefs(request));
sImageObserver, loadFlags, u"css"_ns, getter_AddRefs(request));
if (NS_FAILED(rv) || !request) {
return nullptr;

3
layout/style/SharedStyleSheetCache.h
View file

@ -129,7 +129,8 @@ class SharedStyleSheetCache final : public nsIMemoryReporter {
//
// Note that we hold on to all sheet loads, even if in the end they happen not
// to be cacheable.
nsDataHashtable<SheetLoadDataHashKey, WeakPtr<css::SheetLoadData>> mLoadingDatas;
nsDataHashtable<SheetLoadDataHashKey, WeakPtr<css::SheetLoadData>>
mLoadingDatas;
// An origin-to-number-of-registered-documents count, in order to manage cache
// eviction as described in RegisterLoader / UnregisterLoader.

3
media/webrtc/signaling/src/peerconnection/RTCDTMFSender.cpp
View file

@ -32,7 +32,8 @@ LazyLogModule gDtmfLog("RTCDTMFSender");
RTCDTMFSender::RTCDTMFSender(nsPIDOMWindowInner* aWindow,
TransceiverImpl* aTransceiver,
AudioSessionConduit* aConduit)
: DOMEventTargetHelper(aWindow), mTransceiver(aTransceiver),
: DOMEventTargetHelper(aWindow),
mTransceiver(aTransceiver),
mConduit(aConduit) {}
JSObject* RTCDTMFSender::WrapObject(JSContext* aCx,

4
mfbt/WeakPtr.h
View file

@ -192,9 +192,7 @@ class SupportsWeakPtr {
using WeakReference = detail::WeakReference;
protected:
~SupportsWeakPtr() {
DetachWeakPtr();
}
~SupportsWeakPtr() { DetachWeakPtr(); }
protected:
void DetachWeakPtr() {

2
mozglue/baseprofiler/public/BaseProfiler.h
View file

@ -634,7 +634,6 @@ class MOZ_RAII AutoProfilerStats {
~AutoProfilerStats() { mStats.AddDurationFrom(mStart); }
private:
StaticBaseProfilerStats& mStats;
TimeStamp mStart;
};
@ -1006,7 +1005,6 @@ class MOZ_RAII AutoProfilerLabel {
MFBT_API static ProfilingStack* GetProfilingStack();
private:
// We save a ProfilingStack pointer in the ctor so we don't have to redo the
// TLS lookup in the dtor.
ProfilingStack* mProfilingStack;

1
netwerk/base/TRRLoadInfo.cpp
View file

@ -305,7 +305,6 @@ TRRLoadInfo::GetInnerWindowID(uint64_t* aResult) {
return NS_ERROR_NOT_IMPLEMENTED;
}
NS_IMETHODIMP
TRRLoadInfo::GetBrowsingContextID(uint64_t* aResult) {
return NS_ERROR_NOT_IMPLEMENTED;

3
netwerk/protocol/http/Http3Session.cpp
View file

@ -181,8 +181,7 @@ void Http3Session::Shutdown() {
Http3Session::~Http3Session() {
LOG3(("Http3Session::~Http3Session %p", this));
Telemetry::Accumulate(Telemetry::HTTP3_REQUEST_PER_CONN,
mTransactionCount);
Telemetry::Accumulate(Telemetry::HTTP3_REQUEST_PER_CONN, mTransactionCount);
Shutdown();
}

4
toolkit/components/reputationservice/ApplicationReputation.cpp
View file

@ -197,8 +197,8 @@ const char* const ApplicationReputationService::kBinaryFileExtensions[] = {
".caction", // Automator action
".cdr", // Mac disk image
//".cer", exec // Signed certificate file
".cfg", // Windows
".chi", // Windows Help
".cfg", // Windows
".chi", // Windows Help
//".chm", exec // Windows Help
".class", // Java
//".cmd", exec // Windows executable

4
toolkit/crashreporter/test/nsTestCrasher.cpp
View file

@ -222,13 +222,13 @@ extern "C" NS_EXPORT void Crash(int16_t how) {
// Since we need to call the real HeapFree() we get its pointer directly.
HMODULE kernel32 = LoadLibraryW(L"Kernel32.dll");
if (kernel32) {
typedef BOOL(*HeapFreeT)(HANDLE, DWORD, LPVOID);
typedef BOOL (*HeapFreeT)(HANDLE, DWORD, LPVOID);
HeapFreeT heapFree = (HeapFreeT)GetProcAddress(kernel32, "HeapFree");
if (heapFree) {
HANDLE heap = GetProcessHeap();
LPVOID badPointer = (LPVOID)3;
heapFree(heap, 0, badPointer);
break; // This should be unreachable
break; // This should be unreachable
}
}
}

1
tools/profiler/public/GeckoProfiler.h
View file

@ -1216,7 +1216,6 @@ class MOZ_RAII AutoProfilerLabel {
}
private:
// We save a ProfilingStack pointer in the ctor so we don't have to redo the
// TLS lookup in the dtor.
ProfilingStack* mProfilingStack;

15
widget/cocoa/nsDeviceContextSpecX.mm
View file

@ -270,9 +270,11 @@ NS_IMETHODIMP nsDeviceContextSpecX::Init(nsIWidget* aWidget, nsIPrintSettings* a
mPrintViaSkPDF = true;
} else if (destination == kPMDestinationFile) {
AutoCFRelease<CFURLRef> destURL(nullptr);
status = ::PMSessionCopyDestinationLocation(mPrintSession, mPrintSettings, destURL.receive());
status =
::PMSessionCopyDestinationLocation(mPrintSession, mPrintSettings, destURL.receive());
if (status == noErr) {
AutoCFRelease<CFStringRef> destPathRef = CFURLCopyFileSystemPath(destURL, kCFURLPOSIXPathStyle);
AutoCFRelease<CFStringRef> destPathRef =
CFURLCopyFileSystemPath(destURL, kCFURLPOSIXPathStyle);
NSString* destPath = (NSString*)CFStringRef(destPathRef);
NSString* destPathExt = [destPath pathExtension];
if ([destPathExt isEqualToString:@"pdf"]) {
@ -367,12 +369,15 @@ NS_IMETHODIMP nsDeviceContextSpecX::EndDocument() {
}
case kPMDestinationFile: {
AutoCFRelease<CFURLRef> destURL(nullptr);
status = ::PMSessionCopyDestinationLocation(mPrintSession, mPrintSettings, destURL.receive());
status =
::PMSessionCopyDestinationLocation(mPrintSession, mPrintSettings, destURL.receive());
if (status == noErr) {
AutoCFRelease<CFStringRef> sourcePathRef = CFURLCopyFileSystemPath(pdfURL, kCFURLPOSIXPathStyle);
AutoCFRelease<CFStringRef> sourcePathRef =
CFURLCopyFileSystemPath(pdfURL, kCFURLPOSIXPathStyle);
NSString* sourcePath = (NSString*)CFStringRef(sourcePathRef);
# ifdef DEBUG
AutoCFRelease<CFStringRef> destPathRef = CFURLCopyFileSystemPath(destURL, kCFURLPOSIXPathStyle);
AutoCFRelease<CFStringRef> destPathRef =
CFURLCopyFileSystemPath(destURL, kCFURLPOSIXPathStyle);
NSString* destPath = (NSString*)CFStringRef(destPathRef);
NSString* destPathExt = [destPath pathExtension];
MOZ_ASSERT([destPathExt isEqualToString:@"pdf"],

1
xpcom/base/AutoRestore.h
View file

@ -30,6 +30,7 @@ class MOZ_RAII AutoRestore {
private:
T& mLocation;
T mValue;
public:
explicit AutoRestore(T& aValue) : mLocation(aValue), mValue(aValue) {}
~AutoRestore() { mLocation = mValue; }