The SetAudioOutputDevice() implementation required a subsequent
AddAudioOutput() call, so there is no need to have separate methods.
Differential Revision: https://phabricator.services.mozilla.com/D158310
Previously, SetAudioOutputDevice() already depended on RemoveAudioOutput()
having already been called to remove the output from the track or
CrossGraphPort when switching from or to the default device, but
CrossGraphPorts were not removed.
Differential Revision: https://phabricator.services.mozilla.com/D158307
This is done using the gtest framework, and adds a new protocol which has its
messages counted. As the IPDLUnitTest process doesn't count IPC messages with
glean, this only counts messages on the parent process side.
This test also checks that we don't count this information outside of nightly,
and that it isn't counted for messages sent within the same process.
Differential Revision: https://phabricator.services.mozilla.com/D158275
This will provide us with more information with which to discover what
IPC messages are being sent extremely frequently, especially from
background processes, and what we can do to avoid unnecessary wakeups.
This is intended for power usage work, and is being tracked in a similar
way to the thread wakeups work, based on process types, such that the
data can be compared between the two.
Differential Revision: https://phabricator.services.mozilla.com/D157855
This reduces the number of times we re-parse the same glean file, and means we
only use 2 GeneratedFiles directives to generate the relevant files for Glean.
This will also make errors generated by the validator only print once.
The problem in the original patch appears to be caused by the use of the rust
file ('api/src/metrics.rs'), as the first argument to the GeneratedFile. This
messed with the location of things like generated deps files for the build
script, and the path of the stub file, which were placed alongside the
`metrics.rs` file, and not in the directory the build system was expecting.
This issue appears to be fixed if the arguments are re-ordered, such that a
header file appears first instead.
Differential Revision: https://phabricator.services.mozilla.com/D158273
Remove all the thread names only used in tests from ThreadAllows.txt.
Instead, list the test files that create them in ThreadFileAllows.txt.
Differential Revision: https://phabricator.services.mozilla.com/D157762
Filenames alone do not uniquely identify files in the Mozilla codebase.
Allow specification of path-elements alongside filenames.
Differential Revision: https://phabricator.services.mozilla.com/D157761
Expand the processor for ThreadAllows.txt and ThreadFileAllows.txt to
also recognize and permit comments prefixed by `#`.
Differential Revision: https://phabricator.services.mozilla.com/D157760
XUL honored the flex over explicit width. We need to set the width in
dialog code to properly keep the preferred width behavior.
Looking at min-width isn't needed for this patch but will be needed for
the next patch to preserve behavior.
Differential Revision: https://phabricator.services.mozilla.com/D158283
After bug 1665476, it's pretty much a regular XUL box with a couple
special-cases that we can use IsRootElementStyle for. Do that, and allow
using nsFlexContainerFrame when using flexbox emulation.
Differential Revision: https://phabricator.services.mozilla.com/D158288
This shouldn't have any behavior change, other than avoiding XUL / CSS
interaction issues.
I had to tweak a bit a few of the webconsole split styles to preserve
behavior (even though without the styles it ends up working out because
the collapsed console would be out of view anyways).
The reason for the changes are:
* visibility: collapse doesn't prevent min-height from applying on
modern flexbox. So just collapse it using height properly. We need to
use !important, at least on height, to override the style attribute
set by the splitter.
* Tweak the splitting setup of the console a bit more to match legacy
behavior.
* I need to contain: size on some scrollers and replaced elements so
that they flex properly rather than taking as much space as they need
(this kinda sucks but oh well). We could set min-width/height: 0
instead if you think it's easier to understand but contain is more
robust.
I needed to adjust the test since the fractional part of the container
wasn't getting rounded on my machine, but that's a pre-existing issue
that happens with my DPI settings both before and after the patch.
Differential Revision: https://phabricator.services.mozilla.com/D158183
