nagai/fune
3
0
Fork 0
forked from mirrors/gecko-dev
Code Pull requests Activity
849020 commits 1 branch 98 tags 6.4 GiB
Commit graph

60 commits

Author SHA1 Message Date
Norisz Fay
9de8b59a54 Backed out changeset cbf5ea1b17d2 (bug 1811129) for causing failures on modal-dialog-backdrop-opacity.html CLOSED TREE 2023-07-06 20:28:17 +03:00
Sean Feng
185848e40b Bug 1811129 - Implement the new dialog initial focus algorithm r=emilio 
The main changes of the new algorithm are

* Make the dialog focusing steps look at sequentially focusable elements instead of any focusable element.
* Make the dialog element itself get focus if it has the autofocus attribute set.
* Make the dialog element itself get focus as a fallback instead of focus being "reset" to the body element.

Spec PR (merged): https://github.com/whatwg/html/pull/8199

Differential Revision: https://phabricator.services.mozilla.com/D181263
 2023-07-06 15:33:33 +00:00
Ziran Sun
96a16d3cad Bug 1835464 - Check dialog is modal flag instead of open attribute in 'check popover validity' algorithm. r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D181089
 2023-06-20 08:49:32 +00:00
Cathie Chen
fa7b94707d Bug 1836057 - Popover: Use dialog initial focus for dialog popovers, r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D179580
 2023-06-01 18:16:53 +00:00
Ziran Sun
791826bf87 Bug 1834519 - Don't throw when popovers/dialogs are in requested state. r=emilio 
Update to be in line with spec discussions at
https://github.com/whatwg/html/pull/9142

Differential Revision: https://phabricator.services.mozilla.com/D178782
 2023-05-25 08:35:29 +00:00
Ziran Sun
7fd8c1eea1 Bug 1831057 - Handle conflict interactions between popover, modal dialog and fullscreen. r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D177003
 2023-05-17 18:49:45 +00:00
Stanca Serban
23eceacb05 Backed out changeset e1a398764f9e (bug 1831057) for causing wpt failures in popover-top-layer-combinations.html. 2023-05-12 15:39:38 +03:00
Ziran Sun
ed290a4a58 Bug 1831057 - Handle conflict interactions between popover, modal dialog and fullscreen. r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D177003
 2023-05-12 08:00:26 +00:00
Ziran Sun
c4aad864d0 Bug 1829318 - Throw exception when calling dialog.show() on an open popover. r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D176141
 2023-04-28 14:17:51 +00:00
Cathie Chen
a551a009d3 Bug 1823897 - Implement popover focusing steps, r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D173714
 2023-03-28 16:01:25 +00:00
Sean Feng
ce074323cc Bug 1809561 - Check IsInProcess() before calling SameOriginWithTop() for <dialog> r=smaug 
Looks like in an edge case, this method could be called on a
out-of-process browsing context.

Differential Revision: https://phabricator.services.mozilla.com/D171766
 2023-03-07 14:26:14 +00:00
Sean Feng
c6d5b35934 Bug 1741936 - Implement focus delegate algorithm r=emilio 
Spec: https://html.spec.whatwg.org/multipage/interaction.html#focus-delegate

Differential Revision: https://phabricator.services.mozilla.com/D153689
 2022-10-14 01:20:08 +00:00
Emilio Cobos Álvarez
a7e9f1597b Bug 1771150 - Make fullscreen modal. r=smaug 
As per https://github.com/w3c/csswg-drafts/issues/7311.

Differential Revision: https://phabricator.services.mozilla.com/D150335
 2022-07-06 00:16:28 +00:00
Noemi Erli
5003eb07b7 Backed out changeset 8a9bae22cf24 (bug 1771150) for causing failures in browser_fullscreen_warning.js and test_pointerlock-api.html CLOSED TREE 2022-06-27 17:27:11 +03:00
Emilio Cobos Álvarez
016a64f777 Bug 1771150 - Make fullscreen modal. r=smaug 
As per https://github.com/w3c/csswg-drafts/issues/7311.

Differential Revision: https://phabricator.services.mozilla.com/D150335
 2022-06-27 10:57:34 +00:00
Emilio Cobos Álvarez
255763ef57 Bug 1773070 - Unify Gecko and Servo EventState/ElementState bits. r=smaug 
Add a dom/base/rust crate called just "dom" where we can share these.

Most of the changes are automatic:

  s/mozilla::EventStates/mozilla::dom::ElementState/
  s/EventStates/ElementState/
  s/NS_EVENT_STATE_/ElementState::/
  s/NS_DOCUMENT_STATE_/DocumentState::/

And so on. This requires a new cbindgen version to avoid ugly casts for
large shifts.

Differential Revision: https://phabricator.services.mozilla.com/D148537
 2022-06-07 23:09:52 +00:00
Masayuki Nakano
728f08af35 Bug 1680611 - part 8: Mark nsFocusManager::Blur and its callers in nsFocusManager as MOZ_CAN_RUN_SCRIPT r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D147067
 2022-05-26 04:37:20 +00:00
Emilio Cobos Álvarez
31e7dd1820 Bug 1771137 - Cleanup a bit top layer code. r=edgar 
Differential Revision: https://phabricator.services.mozilla.com/D147282
 2022-05-25 13:07:19 +00:00
Emilio Cobos Álvarez
535e775ae4 Bug 1743082 - Only clear focus for modal dialog. r=sefeng 
Differential Revision: https://phabricator.services.mozilla.com/D134964
 2022-01-03 19:31:57 +00:00
Olli Pettay
553c13cf24 Bug 1740971, use a raw pointer for fast iteration, r=sefeng 
Differential Revision: https://phabricator.services.mozilla.com/D131085
 2021-11-15 13:13:47 +00:00
Sean Feng
4c04bd745b Bug 1709233 - Fix a null pointer crash in HTMLDialogElement::StorePreviouslyFocusedElement r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D114256
 2021-05-04 18:39:04 +00:00
Sean Feng
11571dd0b7 Bug 1660271 - Move the focus to the previously focused element when <dialog> is closed r=smaug 
This change is based on the latest changes for the <dialog> element in
https://github.com/whatwg/html/pull/6531, such that closing
<dialog> should move the focus to the previously focused element.

Differential Revision: https://phabricator.services.mozilla.com/D109726
 2021-04-29 19:35:23 +00:00
Emilio Cobos Álvarez
2b65233acf Bug 1699402 - Minor cleanup in HTMLDialogElement focusing steps. r=sefeng 
This shouldn't change behavior, but I wrote this while looking at
bug 1699259 (which didn't use this code after all) and I think it's ok.

Differential Revision: https://phabricator.services.mozilla.com/D108927
 2021-03-18 15:14:13 +00:00
Razvan Maries
4b5dec5070 Backed out changeset 0c3bb21d00d4 (bug 1675857) for multiple wpt perma failures at HTMLDialogElement. CLOSED TREE 2020-12-09 01:25:42 +02:00
Sean Feng
335e125bcb Bug 1675857 - Update <dialog> internal styles for spec alignment r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D99146
 2020-12-08 22:29:44 +00:00
Simon Giesecke
971b645fe3 Bug 1660470 - Add missing include directives/forward declarations. r=nika 
Differential Revision: https://phabricator.services.mozilla.com/D87865
 2020-11-23 16:21:38 +00:00
Sylvestre Ledru
fde06f6d21 Bug 1674637 - Use nested namespaces in dom/ r=sg,andi 
Also add some missing namespace qualifications

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Differential Revision: https://phabricator.services.mozilla.com/D95456
 2020-11-04 17:04:01 +00:00
Butkovits Atila
964cca3198 Backed out changeset c0adbf7522dc (bug 1674637) for bustage on GMPParent.cpp. CLOSED TREE 2020-11-04 10:54:36 +02:00
Sylvestre Ledru
5f29324f60 Bug 1674637 - Use nested namespaces in dom/ r=sg,andi 
Also add some missing namespace qualifications

Done with:
./mach static-analysis check --checks="-*,modernize-concat-nested-namespaces" --fix dom/
./mach clang-format -p $(hg status dom/|grep ^M|awk '{print $2}')

Differential Revision: https://phabricator.services.mozilla.com/D95456
 2020-11-04 08:29:00 +00:00
Andi-Bogdan Postelnicu
6381129ef6 Bug 1671641 - Make dom/html buildable outside of unified-build environment. r=sg 
Differential Revision: https://phabricator.services.mozilla.com/D94945
 2020-10-28 12:24:01 +00:00
Edgar Chen
3af8ce6d7a Bug 1667081 - Part 1: Replace usage of nsIFocusManager with nsFocusManager; r=hsivonen 
This patch is bascially done by:
perl -p -i -e "s/nsIFocusManager\* /nsFocusManager* /g;" $( find . -name *.cpp )
perl -p -i -e "s/nsCOMPtr<nsIFocusManager>/RefPtr<nsFocusManager>/g;" $( find . -name *.cpp )

Differential Revision: https://phabricator.services.mozilla.com/D91287
 2020-09-29 07:21:09 +00:00
Bogdan Tara
8f6c53bdf5 Backed out 9 changesets (bug 1667081) for assertion failure on nsFocusManager CLOSED TREE 
Backed out changeset 156ab3eba505 (bug 1667081)
Backed out changeset 2e37f347082c (bug 1667081)
Backed out changeset 8f59cef879ae (bug 1667081)
Backed out changeset 1298ff140218 (bug 1667081)
Backed out changeset 91342c822425 (bug 1667081)
Backed out changeset aafb1878c590 (bug 1667081)
Backed out changeset 2252e975f0d7 (bug 1667081)
Backed out changeset c3bac5f407d2 (bug 1667081)
Backed out changeset b1e6e81396ae (bug 1667081)
 2020-09-28 20:02:52 +03:00
Edgar Chen
6abd74544d Bug 1667081 - Part 1: Replace usage of nsIFocusManager with nsFocusManager; r=hsivonen 
This patch is bascially done by:
perl -p -i -e "s/nsIFocusManager\* /nsFocusManager* /g;" $( find . -name *.cpp )
perl -p -i -e "s/nsCOMPtr<nsIFocusManager>/RefPtr<nsFocusManager>/g;" $( find . -name *.cpp )

Differential Revision: https://phabricator.services.mozilla.com/D91287
 2020-09-28 14:04:12 +00:00
Sean Feng
85bfe3d376 Bug 1200896 - Make the document blocked by the topmost element in the top layer r=emilio 
Spec: https://html.spec.whatwg.org/multipage/#blocked-by-a-modal-dialog

Depends on D86392

Differential Revision: https://phabricator.services.mozilla.com/D86227
 2020-08-17 15:41:19 +00:00
Mihai Alexandru Michis
fc1c9759fc Backed out 3 changesets (Bug 1200896) for causing Bug 1659042. 
CLOSED TREE

Backed out changeset 17df14f0b129 (bug 1200896)
Backed out changeset 5d9e9bd12cd2 (bug 1200896)
Backed out changeset 7f016de8d52f (bug 1200896)
 2020-08-14 09:06:45 +03:00
Sean Feng
3f16476b10 Bug 1200896 - Make the document blocked by the topmost element in the top layer r=emilio 
Spec: https://html.spec.whatwg.org/multipage/#blocked-by-a-modal-dialog

Differential Revision: https://phabricator.services.mozilla.com/D86227
 2020-08-13 19:05:37 +00:00
Razvan Maries
0dc0ced176 Backed out 2 changesets (bug 1200896) for perma failures on browser_pioneer_ui.js. CLOSED TREE 
Backed out changeset c7ae88fd1bd7 (bug 1200896)
Backed out changeset 8b57f059e63e (bug 1200896)
 2020-08-10 23:08:04 +03:00
Sean Feng
17473c0717 Bug 1200896 - Make the document blocked by the topmost element in the top layer r=emilio 
Spec: https://html.spec.whatwg.org/multipage/#blocked-by-a-modal-dialog

Differential Revision: https://phabricator.services.mozilla.com/D86227
 2020-08-10 18:20:51 +00:00
Sean Feng
dcd8cf2781 Bug 1657163 - Enable <dialog> in chrome UI for beta/release r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D85933
 2020-08-05 14:26:29 +00:00
Simon Giesecke
da069e50be Bug 1652942 - Remove unnecessary includes from Element.h. r=smaug 
Depends on D83114

Differential Revision: https://phabricator.services.mozilla.com/D83632
 2020-07-15 14:09:01 +00:00
Simon Giesecke
cd8b8939b9 Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj 
Differential Revision: https://phabricator.services.mozilla.com/D80860
 2020-07-01 08:29:29 +00:00
Sylvestre Ledru
63be8d152d Bug 1519636 - Reformat recent changes to the Google coding style r=necko-reviewers,dragana 
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D77580
 2020-05-30 09:55:27 +00:00
sefeng
31182cf837 Bug 1640334 - Use IgnoreErrors() at where it appropriates for HTMLDialogElement r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D77137
 2020-05-28 00:19:35 +00:00
sefeng
7c966cd62c Bug 1640336 - Use descriptive error messages for dialog.showModal() r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D77126
 2020-05-27 20:35:47 +00:00
sefeng
727ca5589e Bug 1322947 - Add support of cancel dialog modal with escape key r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D74937
 2020-05-27 14:37:19 +00:00
sefeng
f2affadce6 Bug 1324958 - Implement <dialog> focusing steps r=smaug 
Spec: https://html.spec.whatwg.org/multipage/interactive-elements.html#dialog-focusing-steps

Differential Revision: https://phabricator.services.mozilla.com/D74923
 2020-05-25 14:57:25 +00:00
sefeng
67c1284c8c Bug 1637307 - Push/Pop dialog to top layer when needed r=smaug,emilio 
This patch completes the top layer requirement for showModal()
Spec: https://html.spec.whatwg.org/multipage/interactive-elements.html#dom-dialog-showmodal

Differential Revision: https://phabricator.services.mozilla.com/D74922
 2020-05-23 01:45:33 +00:00
Coroiu Cristina
a9c2a2b735 Backed out changeset bb7c330d407f (bug 1637307) for wpt failures at layout/generic/ViewportFrame.cpp on s CLOSED TREE 2020-05-20 00:01:55 +03:00
sefeng
ca6d5ba134 Bug 1637307 - Push/Pop dialog to top layer when needed r=smaug 
This patch completes the top layer requirement for showModal()
Spec: https://html.spec.whatwg.org/multipage/interactive-elements.html#dom-dialog-showmodal

Differential Revision: https://phabricator.services.mozilla.com/D74922
 2020-05-19 15:40:08 +00:00
Sean Feng
2d1f2db82e Bug 1377999 - Make HTML Element to adapt the DOMArena changes r=smaug 
Differential Revision: https://phabricator.services.mozilla.com/D57699

--HG--
extra : moz-landing-system : lando
 2020-03-17 14:53:08 +00:00