This wasn't really used anymore.
We are fetching the database from the server runtime in order to support
remote debugging correctly, where frontend CSS may be different from debuggee CSS.
Differential Revision: https://phabricator.services.mozilla.com/D187492
This shouldn't change behavior, but it packs the two arguments to
DestroyFrom into a single thing, and makes nsIFrame::Destroy not so easy
to call without a previous context.
This is a prerequisite to pass aDestroyContext to various things that
right now just mint one, which can cause badness, see bug 1851787 and
related bugs.
It's also a bit nicer to add things there if we need to in the future.
Differential Revision: https://phabricator.services.mozilla.com/D187578
Using PWindowGlobal for SetCookies calls from content to parent process means we can get
the BrowsingContext the cookies are set for. The current implementation in PCookieService
drops this relationship.
I'm leaving in the old SetCookies call for cases where the inner window is null. This
happens for some of the cookie tests.
Differential Revision: https://phabricator.services.mozilla.com/D186045
This avoids triggering bug 1851066, per the comment in the test. Bug 1851066
is a real bug, but it's quite subtle and is unrelated to what this WPT is
actually trying to test.
Differential Revision: https://phabricator.services.mozilla.com/D187241
This function had some code that we hadn't yet updated to support vertical
writing modes. This patch makes it more generic so that it can properly handle
vertical-writing-mode text nodes (so that we can e.g. properly keep the caret
scrolled into view, in a vertical-writing-mode textfield).
I'm just focusing on vertical vs. horizontal generification for now. I'm not
entirely sure if it makes sense to make it even-more-generic-still to support
reversed-inline-direction writing modes as well. I wasn't able to trigger any
issues with those in some brief testing, so I think this patch is sufficient
as-is, but I left a TODO(dholbert) code-comment to call out that ambiguity
that's still present in the code.
Differential Revision: https://phabricator.services.mozilla.com/D187160
This patch doesn't change behavior. It's just laying the groundwork for the
next patch which adds vertical-writing-mode support.
(This patch adds some documentation in terms of logical axes, though, which
will become accurate as of the next patch in this series.)
Differential Revision: https://phabricator.services.mozilla.com/D187161
Bug 311340 tried to fix a similar issue, but have to clear clipboard in nsClipboard's
destructor in order to avoid crash while calling gdk_display_close() on exit,
see bug 531580. But after bug 1626536, we are no longer calling gdk_display_close()
on exit, I don't see the same crash as bug 531580 anymore, either.
Differential Revision: https://phabricator.services.mozilla.com/D187595
This commit vendors the latest changes to the Suggest and Remote
Settings Rust components.
1. From the `application-services` source tree, I ran
`./tools/update-moz-central-vendoring.py ../m-c` to update the
revisions in the m-c source tree.
2. I added the Remote Settings component UDL file to
`toolkit/components/uniffi-bindgen-gecko-js/mach_commands.py`, and
updated `toolkit/components/uniffi-bindgen-gecko-js/config.toml` to
call the `RemoteSettings` constructor on the main thread. The
Suggest component uses the `RemoteSettingsConfig` type in its
public API, so we must generate bindings for the Remote Settings
component.
3. From the m-c source tree, I ran `./mach uniffi generate` to update
the generated UniFFI bindings.
Differential Revision: https://phabricator.services.mozilla.com/D187559
This enables addon suggestions by default (treatment B, no stars) for all
Suggest users. As discussed on Slack, I did not remove the related prefs and
Nimbus variables in case something goes wrong and we need to disable the feature
ASAP. In that case, we can ship a Nimbus rollout to re-disable it. After a
release cycle or two without any problems, we can do a follow-up that removes
them. I also left the treatment A implementation. We can remove that in a
follow-up too.
Since I did leave the prefs and variables, I only had to change their default
values to enable the feature with treatment B.
One problem is that addon suggestions should be best matches, but we don't want
to set `bestMatch.enabled` to true by default. To work around that, I set the
related best-match properties on the `UrlbarResult` inside `AddonSuggestions`
instead of delegating it to the quick suggest provider. Product has requested
that we remove the "Top pick" checkbox from about:preferences, and at that time
we should also remove the `bestMatch.enabled` pref. In the future, results
should be best matches on a case-by-case basis.
This makes a few UI changes that aren't strictly related but I wanted to fix
since more users will now see these suggestions:
* Cache the "Firefox extension" group label to prevent pop-in.
* Align the URL and row title by baseline. Right now the URL is too high above
the title.
* Set `inline-margin-end` of the icon so it's symmetrical with the starting
margin/padding. The current value of 8px is hardcoded and too small.
Differential Revision: https://phabricator.services.mozilla.com/D187640
Once per TranslationsParent Process, we will schedule
a requestIdleCallback to sync our RemoteSettings records.
This will ensure that users get updates promptly when we push
new changes to Remote Settings, or change which Remote Settings
channel we are pulling from.
Differential Revision: https://phabricator.services.mozilla.com/D187300
