We add a new connection type 'cert-error-page' and will show a warning
lock icon for it. We add a test for it and update existing tests.
Differential Revision: https://phabricator.services.mozilla.com/D45647
--HG--
extra : moz-landing-system : lando
The site identity and security sub panels now contain that much information that it warrants to make these more easily navigable for NVDA and other screen readers. The panels behave as before, but the added roles and heading levels cause NVDA and other screen readers to use their browse mode features instead of regular application interaction so blind and visually impaired users can review the information more easily.
Differential Revision: https://phabricator.services.mozilla.com/D42924
--HG--
extra : moz-landing-system : lando
This patch fixes the style issue by make the container of the permission
granted indicator to centered align its children.
Differential Revision: https://phabricator.services.mozilla.com/D42617
--HG--
extra : moz-landing-system : lando
This patch adds the permission granted indicator to the identity panel.
The granted indicator will be shown if there is any granted permission.
And it will got update if permission changes. We also update a test for
this change.
Differential Revision: https://phabricator.services.mozilla.com/D42121
--HG--
extra : moz-landing-system : lando
Note that due to bug 1572677, an additional association via aria-label is also needed for now. It uses the same string entity as the label above.
Differential Revision: https://phabricator.services.mozilla.com/D41351
--HG--
extra : moz-landing-system : lando
This patch changes the "righit='0'" to "end='0'" of the tracker conunter
box in order to show a correct alignment in RTL mode.
Differential Revision: https://phabricator.services.mozilla.com/D40863
--HG--
extra : moz-landing-system : lando
We were hiding these labels by setting the "hidden" attribute by default and then, in CSS,
negating the effect of "hidden" by using `display: unset;`. Turns out this isn't a great
idea because doing this won't remove the "hidden" attribute, which some code relies on
to figure out whether the element is hidden. Like in this case PanelMultiview:
https://searchfox.org/mozilla-central/rev/0ffa9e372df56c95547fed9c3433ddec4fbf6f11/browser/components/customizableui/PanelMultiView.jsm#1402
Here it tries to find elements to process as part of descriptionHeightWorkaround,
and that skips this technically visible element because it still has the hidden attribute.
Luckily that's easy to fix.
Differential Revision: https://phabricator.services.mozilla.com/D40552
--HG--
extra : moz-landing-system : lando
This patch makes changes to the protection setting button and the footer
section. First, it moves the protection setting button into the footer
section. Second, it updates styles of footer section. And then, it
changes the hover state of buttons.
In addition, it adds a new function in gProtectionsHandler in order to
open the 'about:protections' page when clicking the 'Show report' button.
Differential Revision: https://phabricator.services.mozilla.com/D39692
--HG--
extra : moz-landing-system : lando
This patch makes changes to the protection setting button and the footer
section. First, it moves the protection setting button into the footer
section. Second, it updates styles of footer section. And then, it
changes the hover state of buttons.
In addition, it adds a new function in gProtectionsHandler in order to
open the 'about:protections' page when clicking the 'Show report' button.
Differential Revision: https://phabricator.services.mozilla.com/D39692
--HG--
extra : moz-landing-system : lando
1. Inline "Learn more" link with the main description text.
2. Remove margin-inline-start from labels
3. Remove textbox styling of the URL
Differential Revision: https://phabricator.services.mozilla.com/D39572
--HG--
extra : moz-landing-system : lando
These should be removed anyway and I figured renaming them didn't make much sense.
Differential Revision: https://phabricator.services.mozilla.com/D38021
--HG--
extra : moz-landing-system : lando
This is a pretty big change on paper, but most of the lines are copy-pasted, with some small
adjustments to get the content blocking code comfortable in browser-siteProtections.js.
Differential Revision: https://phabricator.services.mozilla.com/D37556
--HG--
extra : moz-landing-system : lando
This is a pretty big change on paper, but most of the lines are copy-pasted, with some small
adjustments to get the content blocking code comfortable in browser-siteProtections.js.
Differential Revision: https://phabricator.services.mozilla.com/D37556
--HG--
extra : moz-landing-system : lando
This patch makes the mini panel been shown after page reload due to
switch the tracking protection state. The mini panel will be auto hidden
after certain time, which can be configured by the pref
'browser.protections_panel.mini_panel_auto_hide_timing'. The default
value is 5 seconds.
This also implements the behavior that showing the protections panel on
clicking the mini panel.
Differential Revision: https://phabricator.services.mozilla.com/D36018
--HG--
extra : moz-landing-system : lando
This patch implements the capability for opening the protections panel
as a mini panel. The mini panel is a protections panel which only displays
the header section.
Differential Revision: https://phabricator.services.mozilla.com/D36017
--HG--
extra : moz-landing-system : lando
This patch implements the toggle switch flow for the TP switch section.
It adds a strip background to the TP switch section after toggled the
switch to off. Changing the string in the TP switch section. And the
breakage link should be remained after TP switch to off from on until
the page refreshs.
Differential Revision: https://phabricator.services.mozilla.com/D36016
--HG--
extra : moz-landing-system : lando
This patch adds a protection settings section into Protection Panel.
This section consist of one button which will open a
'about:preferences#privacy' when been clicked.
Differential Revision: https://phabricator.services.mozilla.com/D34873
--HG--
extra : moz-landing-system : lando
Previously, this code cached a list of controls on first use and used that for navigation.
This refactor addresses several issues:
1. There is now a separate focus order for tab/shift+tab and down/up arrows.
This allows menulists, textboxes, etc. which use the arrow keys themselves to be focused with tab, but skipped with the arrows.
This means the user won't fall into these controls when using the up/down arrow keys and be confused by the subsequent arrowing behaviour.
2. When a menulist, textbox, etc. is focused, the arrow keys, space and enter are now passed to the control.
This is a better fix for handling of the arrow keys by menulists (bug 1522092).
It also fixes left arrow in a textarea moving to the previous view instead of moving the caret (bug 1489874).
3. This improves handling of dynamic updates to the panel.
For example, elements that are initially disabled and enabled later will be navigable.
This is because the next element is determined dynamically by the TreeWalker, rather than using a cached list.
4. The interim fix for bug 1522092 disabled PanelMultiView keyboard navigation.
This caused some regressions, including arrow keys/activation on the Site Identity Report a Problem link (bug 1539976) and some controls not being navigable if the Site Identity panel is opened using the mouse (bug 1539984).
With the above fixes, we can now re-enable PanelMultiView keyboard navigation in the Site identity panel and thus fix these regressions.
5. Previously, PanelMultiView keyboard navigation was disabled in the main toolbar overflow menu.
This is because the search box can be added to the overflow menu, which previously caused problems for the arrow keys.
With the above fixes, we can now safely enable PanelMultiView keyboard navigation in the overflow menu.
6. PanelMultiView keyboard tests have been added.
Previously, we relied on tests specific to various panels to exercise this functionality.
Differential Revision: https://phabricator.services.mozilla.com/D25905
--HG--
extra : moz-landing-system : lando
Previously, this code cached a list of controls on first use and used that for navigation.
This refactor addresses several issues:
1. There is now a separate focus order for tab/shift+tab and down/up arrows.
This allows menulists, textboxes, etc. which use the arrow keys themselves to be focused with tab, but skipped with the arrows.
This means the user won't fall into these controls when using the up/down arrow keys and be confused by the subsequent arrowing behaviour.
2. When a menulist, textbox, etc. is focused, the arrow keys, space and enter are now passed to the control.
This is a better fix for handling of the arrow keys by menulists (bug 1522092).
It also fixes left arrow in a textarea moving to the previous view instead of moving the caret (bug 1489874).
3. This improves handling of dynamic updates to the panel.
For example, elements that are initially disabled and enabled later will be navigable.
This is because the next element is determined dynamically by the TreeWalker, rather than using a cached list.
4. The interim fix for bug 1522092 disabled PanelMultiView keyboard navigation.
This caused some regressions, including arrow keys/activation on the Site Identity Report a Problem link (bug 1539976) and some controls not being navigable if the Site Identity panel is opened using the mouse (bug 1539984).
With the above fixes, we can now re-enable PanelMultiView keyboard navigation in the Site identity panel and thus fix these regressions.
5. Previously, PanelMultiView keyboard navigation was disabled in the main toolbar overflow menu.
This is because the search box can be added to the overflow menu, which previously caused problems for the arrow keys.
With the above fixes, we can now safely enable PanelMultiView keyboard navigation in the overflow menu.
6. PanelMultiView keyboard tests have been added.
Previously, we relied on tests specific to various panels to exercise this functionality.
Differential Revision: https://phabricator.services.mozilla.com/D25905
--HG--
extra : moz-landing-system : lando
PanelMultiView's keyboard navigation code currently overrides the arrow keys in menulists.
This breaks the permission selectors in the Site Identity panel.
For now, just disable this keyboard navigation code.
DOM will then handle tabbing as it normally would.
This panel is more like a dialog than a menu, so users will generally navigate it with the tab key rather than the arrow keys anyway.
Note that the code in PanelMultiView which makes controls focusable still runs even with disablekeynav set, which is what we want.
Differential Revision: https://phabricator.services.mozilla.com/D21484
--HG--
extra : moz-landing-system : lando
This is mostly a lot of boilerplate based off the trackers category/subpanels.
I would like to do some code-de-duplication, especially in browser-contentblocking,
but I figured it would be a good idea to leave that to a different bug to not obstruct
the feature from landing :)
Differential Revision: https://phabricator.services.mozilla.com/D18826
--HG--
extra : rebase_source : d0fb21c5a42cf16dfe6b185806575f09e9a9f1a5
