After the regressing bug, first-line reparenting starts off with the
to-be-reparented style, so the display value is already the expected
(grid) rather than block.
Differential Revision: https://phabricator.services.mozilla.com/D197251
-moz-window-shadow is a chrome-only property (not exposed to the web),
and chrome stylesheets only use the none value to disable the default
behavior.
Split the style property (default/none) from the actual widget behavior.
This is useful because I want to add a distinction between
natively-styled menupopups and other panels in the following commit.
While at it rename default to "auto" which is a more common name in CSS
for something like this.
We have no use case for removing the shadow of a top-level window, so
remove it to simplify the code.
Differential Revision: https://phabricator.services.mozilla.com/D197454
-moz-user-focus: none didn't do anything useful for non-XUL until
bug 1868552. It seems nonetheless some sites specify it, which can cause
compat issues.
Let's hide this property from content, to avoid breaking those sites.
Differential Revision: https://phabricator.services.mozilla.com/D197253
1.76 added a warning when comparing pointers with metadata (e.g. a size
or trait vtable), and suggests to use explicit comparisons, either
std::ptr::addr_eq to only compare the address or std::ptr::eq to compare
address + metadata.
The current semantics of Arc::ptr_eq are to compare address + metadata,
but the intended semantics are to compare the address. So we do that.
Differential Revision: https://phabricator.services.mozilla.com/D197275
-moz-user-focus: none didn't do anything useful for non-XUL until
bug 1868552. It seems nonetheless some sites specify it, which can cause
compat issues.
Let's hide this property from content, to avoid breaking those sites.
Differential Revision: https://phabricator.services.mozilla.com/D197253
This got reviewed as part of D196842 (see diff 801914), but I rebased
before landing in a tree that didn't have that change.
MANUAL PUSH: Orange fix CLOSED TREE
Make NonCustomPropertyId an u16 (because it can, and it's more compact),
and use arrays for ShorthandId::longhands and LonghandId::shorthands.
Differential Revision: https://phabricator.services.mozilla.com/D196759
By using a opaque-appearance widget (which is effectively what
appearance: -moz-dialog used to provide).
There's the question of whether we want the current vibrant titlebars,
but this restores the behavior precisely for now.
Differential Revision: https://phabricator.services.mozilla.com/D196712
This patch also updates the bug ID for a FIXME leftover from bug 1840478
to bug 1869476, since the same FIXME is added in D190758.
Co-authored-by: Frederic Wang <fred.wang@free.fr>
Depends on D191322
Differential Revision: https://phabricator.services.mozilla.com/D190758
This will make possible to animate custom properties. For now, the
animation code keeps only dealing with PropertyDeclarationId::Longhand,
so behavior is unchanged.
Co-authored-by: Frederic Wang <fred.wang@free.fr>
Depends on D195972
Differential Revision: https://phabricator.services.mozilla.com/D190816
PropertyId predates NonCustomPropertyId. Now that we have it, we can
clean up a bit the code.
The idea is to make PropertyId and AnimatedPropertyId basically the
same, so that conversions can be improved in bug 1846516.
While at it make NonCustomPropertyId a u32.
Differential Revision: https://phabricator.services.mozilla.com/D196415
Because PropertyDeclarationId and its implementation do not make use of
templating, we might as well move it out of mako.
This will be useful later when creating OwnedPropertyDeclarationId,
which can be added to the same module.
Differential Revision: https://phabricator.services.mozilla.com/D195972
This is tested via the inert tests, effectively, but I can add more
explicit tests.
Remove rules that would otherwise change behavior (the other rules in
the tree apply to XUL elements and serve a purpose).
Differential Revision: https://phabricator.services.mozilla.com/D195645
This significantly reduces the amount of revalidation selectors looked
up for elements, which was very visible in the profiles for bug 1868316.
Instead of avoiding attribute bucketing to guarantee that we look up at
the same revalidation selectors, keep around the relevant attributes and
compare them.
Differential Revision: https://phabricator.services.mozilla.com/D195561
Parsing is disabled by the layout.css.margin-rules.enabled pref.
This isn't currently testable beyond a crashtest because the DOM interface for
margin rules isn't implemented yet.
Differential Revision: https://phabricator.services.mozilla.com/D187736
If removing these were to become a compat issue in the wild, we could
alias them effortlessly. But honestly they're not even documented in MDN
so I'm pretty sure it should be safe to remove.
Differential Revision: https://phabricator.services.mozilla.com/D195643
This fixes various things, like sort arrows not working, even in regular
non-mixed-color-scheme settings, and is a lot less code.
The toolbarbutton appearance on the problematic case described in
comment 0 could get some work (the extra borders aren't exactly pretty),
but it's still a much better improvement.
Differential Revision: https://phabricator.services.mozilla.com/D195345
Mostly drive-by. Hide macOS specific colors from content, and also the native
hyperlinktext color, which isn't and shouldn't be used from CSS at all.
Differential Revision: https://phabricator.services.mozilla.com/D195296
This is not really needed.
It was never needed if you used background-color: transparent, which is what
the browser did to get sidebar vibrancy, fwiw.
Instead of applying transparency globally, opt-into it explicitly for
things that need it (the unified toolbar of the page info / library windows).
I checked the other things that were using it (wizard and updates.css)
and I don't see any rendering change with this change (tried showing the
update history from about:support, and the create profile wizard).
Depends on D195294
Differential Revision: https://phabricator.services.mozilla.com/D195295
In bug 1861954 I also removed the vibrancy of the places window.
Unlike the browser sidebar this one didn't have an explicit background
color. Add back a system color for the mac sidebar and use it in both
places. This matches the old -moz-mac-source-list color.
Differential Revision: https://phabricator.services.mozilla.com/D195294
This pseudo-class is unused other than in the ua sheet. MozBrowser is
gone (getting actively removed in bug 1770944). Let's just do this since
that is taking a bit.
Differential Revision: https://phabricator.services.mozilla.com/D195095
If the initial values of custom property registrations contain viewport
units, changing the viewport will result in recomputing the initial
values.
Differential Revision: https://phabricator.services.mozilla.com/D194668
Make sure we don't parse units whose sign is not resolvable without a
basis (i.e. percentages when they're not allowed).
Also make sure that we type check the sum so that we don't parse bogus
operations.
Make the length resolution code not crash in release builds.
Differential Revision: https://phabricator.services.mozilla.com/D194500
