Commit graph

186 commits

Author SHA1 Message Date
Brian Grinstead
abf1620630 Bug 1479125 - Migrate calls that expect an element to be returned to use element variation firstChild etc to firstElementChild etc;r=Paolo
This allows the JS to work in HTML documents, where whitespace is preserved. In XUL
documents, whitespace is ignored when parsing so text nodes are generally not returned.

The following changes were made, with manual cleanups as necessary (i.e. when firstChild actually
refers to a text node, or when firstChild is used in a loop to empty out an element):

  firstChild->firstElementChild
  lastChild->lastElementChild
  nextSibling->nextElementSibling
  previousSibling->previousElementSibling
  childNodes->children

MozReview-Commit-ID: 95NQ8syBhYw

--HG--
extra : rebase_source : 186d805f7a2a56694dda9032aceac2dfe5424753
2018-08-08 15:22:53 -07:00
Thi Huynh
a86e16661f Bug 1480982 - Replace _dwu getter with _getBoundsWithoutFlushing method in CustomizeMode.jsm. r=dao
MozReview-Commit-ID: 8NKI6aI3FY0

--HG--
extra : rebase_source : 09b5bf75b8d2fdafdc8223dadf84e04b1d2ac8a7
2018-08-05 17:23:18 +07:00
Emilio Cobos Álvarez
3deb38c4a8 Bug 1474142: Don't skip calling _onDragEnd even if the from and to target is the customizable area. r=Gijs
We may not really receive a dragend event if we're fast enough.

Calling _onDragEnd multiple times is fine (it should be idempotent).

This particular exception was added in bug 978084 along with all the _onDragEnd
calls, but I don't think it's sound over-all.

I don't really want to dig into the XUL button code to see why drag end was
consistently firing there, unless you think it's really really needed :)

Differential Revision: https://phabricator.services.mozilla.com/D2019

--HG--
extra : moz-landing-system : lando
2018-07-31 15:38:34 +00:00
Boris Zbarsky
270fa12c79 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Brian Grinstead
538e6d5d64 Bug 1476030 - Part 3 - Migrate callers from document.persist to xulStore.persist;r=Gijs
MozReview-Commit-ID: JmlIDK9A8dv

--HG--
extra : rebase_source : 5bd4129d99d7c6d24b8c4d33b1ff00be5e180628
2018-07-18 09:43:45 -07:00
Gijs Kruitbosch
b8059765de Bug 1463708 - only reset previews when leaving the panel, r=johannh
MozReview-Commit-ID: 1KVseuWlEPU

--HG--
extra : rebase_source : 5709b1e233b360977fd1a9d26f5e5f26a91e4549
2018-06-19 21:44:00 +01:00
Mark Banner
26be929b13 Bug 1453667 - Remove BrowserUITelemetry from other parts of browser/ r=Gijs
MozReview-Commit-ID: FG1PiVPBY5U

--HG--
extra : rebase_source : 4c8f4553052e00dc5632a5ec36b7d28ac216d53d
2018-06-06 19:42:19 +01:00
Kris Maglione
7b7264f453 Bug 1464548: Part 3 - Update callers to use defineLazyGlobalGetters. r=mccr8
MozReview-Commit-ID: 9APGewiDDYB

--HG--
extra : rebase_source : 2931dd0eec0e4206414b698a9700fc20d922eb3a
2018-05-25 17:02:29 -07:00
Paolo Amadini
3e7ad96d9f Bug 1450816 - Combine the "toolbarpaletteitem" bindings in the "browser" folder. r=Gijs
MozReview-Commit-ID: BW4kDvP13Tj

--HG--
extra : rebase_source : f73916fb41b13c58701be7729f241a9d985ab371
2018-05-22 14:04:45 +01:00
Tim Nguyen
92c9a958e1 Bug 1372694 - Stop making the default theme a heavyweight theme. r=kmag,aswan
MozReview-Commit-ID: 30wMauuc9oo

--HG--
rename : browser/base/content/default-theme-icon.svg => toolkit/mozapps/extensions/content/default-theme-icon.svg
extra : rebase_source : 5e4cf784135f4a8e40a2ed8357ba651e7fce9728
2018-04-01 13:53:31 +02:00
Kris Maglione
877eae8863 Bug 1454202: Part 1 - Update legacy callers to use Promise-based AddonManager APIs. r=aswan
***
Bug 1454202: Part 1a - Auto-replace uses of callback-based AddonManager APIs with Promise-based versions. r=aswan

This was done using the following script:

4cd5ae9597/processors/aom-api-generators.jsm

MozReview-Commit-ID: 8hobLz15a66
***
Bug 1454202: Part 1b - Manually fix eslint errors after auto-rewrite. r=aswan

This also deletes an obsolete test whose xpcshell variant was already deleted.

MozReview-Commit-ID: DM9W9Q2SVIE
***
Bug 1454202: Part 1c - Manually fix non-eslint issues after auto-rewrite. r=aswan

MozReview-Commit-ID: DtMscWZuExc

--HG--
extra : rebase_source : d4c2f80bdf02ec4a07e3713a9ae1823145d25942
2018-04-14 19:38:18 -07:00
Jonathan Kingston
ff73ac0338 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja

--HG--
extra : rebase_source : 29d337e111d82e9c5729b5a59e1a16d06e67774c
2018-02-21 14:28:48 +00:00
ui.manish
f5381fd55d Bug 1451242 - Use this.$ instead of this.document.getElementById in CustomizeMode.jsm r=Gijs 2018-04-05 10:48:04 +02:00
Dão Gottwald
9b050d739e Bug 1450279 - Replace CAN_DRAW_IN_TITLEBAR with a run-time check. r=Gijs
MozReview-Commit-ID: Iedpcu5K74m

--HG--
extra : rebase_source : 3114680ab149c0005d191b2da650ac287d8105af
2018-03-30 17:36:01 +02:00
Kris Maglione
99ebf2e65e Bug 1448221: Part 2 - Remove support for non-default legacy themes. r=aswan
MozReview-Commit-ID: 1v0aGG3mv3U

--HG--
extra : rebase_source : 59deb737dbb812037f4a015404bec0af6a19f9c9
2018-03-26 16:19:04 -07:00
Mark Banner
a32bc883e7 Bug 1434446 - Enable no-unused-vars for global scope on jsm files in browser/. r=mossop
MozReview-Commit-ID: ERT1Fili25d

--HG--
extra : rebase_source : c62ad4e97fc5da7c59cbb03ba08928f7bbe5be6b
2018-03-01 20:06:06 +00:00
Mike Conley
4e9c3d2fe2 Bug 1434376 - Switch over all uses of BrowserUtils.promiseLayoutFlushed to window.promiseDocumentFlushed. r=Paolo
window.promiseDocumentFlushed will call a callback as soon as a style or layout
flush is not required for the document (which might be immediately). This is a
new ChromeOnly API introduced in an earlier patch in this series.

This patch also removes the now-unneeded BrowserUtils.promiseLayoutFlushed and
BrowserUtils.promiseReflowed methods and infrastructure.

MozReview-Commit-ID: Jv7KoxBXhHG

--HG--
extra : rebase_source : b8c9ae40dbdd0f5587d03e8b7c0833bd94032a78
2018-02-11 20:15:11 -05:00
Andreea Pavel
1aac7df383 Backed out 3 changesets (bug 1434376)for failing browser chrome at browser/base/content/test/performance/browser_urlbar_search_reflows.js on a CLOSED TREE
Backed out changeset b636251b75ab (bug 1434376)
Backed out changeset fccbba9cb959 (bug 1434376)
Backed out changeset b5128504011c (bug 1434376)
2018-02-25 12:44:28 +02:00
Mike Conley
96fbfba56f Bug 1434376 - Switch over all uses of BrowserUtils.promiseLayoutFlushed to window.promiseDocumentFlushed. r=Paolo
window.promiseDocumentFlushed will call a callback as soon as a style or layout
flush is not required for the document (which might be immediately). This is a
new ChromeOnly API introduced in an earlier patch in this series.

This patch also removes the now-unneeded BrowserUtils.promiseLayoutFlushed and
BrowserUtils.promiseReflowed methods and infrastructure.

MozReview-Commit-ID: Jv7KoxBXhHG

--HG--
extra : rebase_source : b8c9ae40dbdd0f5587d03e8b7c0833bd94032a78
2018-02-11 20:15:11 -05:00
Florian Quèze
682b1ec3b2 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Andrew McCreight
5dec0e0beb Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG

--HG--
extra : rebase_source : d9c41878036c1ef7766ef5e91a7005025bc1d72b
2018-02-06 09:36:57 -08:00
Florian Quèze
2b1c8dccb6 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
918ed6c474 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
extra : intermediate-source : 34c999fa006bffe8705cf50c54708aa21a962e62
extra : histedit_source : b2be2c5e5d226e6c347312456a6ae339c1e634b0
2018-01-29 15:20:18 -08:00
Cosmin Sabou
9a65a40178 Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
6476f95b13 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : source : 12fc4dee861c812fd2bd032c63ef17af61800c70
2018-01-29 15:20:18 -08:00
Brindusan Cristian
af8879d1eb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
c276bb9375 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl

--HG--
extra : rebase_source : c004a023389f1f6bf3d2f3efe93c13d423b23ccd
2018-01-29 15:20:18 -08:00
Dão Gottwald
6bd33a0edd Bug 1430747 - Stop setting unused customization-lwtheme attribute and --toolbox-rect-height, --toolbox-rect-height-with-unit CSS variables. r=mikedeboer
MozReview-Commit-ID: HpdE3I7ZeDY

--HG--
extra : rebase_source : b87cd595bf2002b6fd25883beedac06835a63e0d
2018-01-16 12:38:41 +01:00
Gijs Kruitbosch
1f11d6af6f Bug 1426250 - make tests actually pass valid mouse coordinates when testing Customize Mode, r=jaws
MozReview-Commit-ID: IglKedBqrWQ

--HG--
extra : rebase_source : a388f02b8d5e00f7e670f41d049518be1de370dc
extra : histedit_source : 8f79f40d24f5456e22787a169cc9f6ae21c03c1e
2018-01-05 21:35:27 +00:00
Tim Nguyen
e1b673bf04 Bug 1428938 - Remove legacy toolbar customization code. r=Gijs
MozReview-Commit-ID: 1ppfxI7yYJW

--HG--
extra : rebase_source : b4a2c44dd5e244c81e479e6b43e9669cc031f349
2018-01-11 16:35:17 +00:00
Gijs Kruitbosch
b260c43755 Bug 1424452 - stop having 2 different values for the 'panel' area type, r=jaws
MozReview-Commit-ID: 3spDhRhlOTF

--HG--
extra : rebase_source : c3d39c18ed645c8023da4488704ed186a405ffda
2017-12-09 12:37:20 +00:00
Gijs Kruitbosch
3aefd1d81c Bug 1415056 - re-enable animations in the palette in customize mode, r=jaws
MozReview-Commit-ID: DXYBPCdXMBG

--HG--
extra : rebase_source : b19fabd92e2709909259b1517edba4b82a365f32
2017-12-04 12:15:10 +00:00
Xidorn Quan
843aaedf4d Bug 1417600 - Wait for another frame before setting animation out to ensure start of the animation. r=jaws
MozReview-Commit-ID: 96nGBDgdr05

--HG--
extra : rebase_source : a5bdf5ff0576a3d24d02e0e35effaa13c6eace43
2017-11-16 10:33:04 -08:00
Andreea Pavel
eaff9152a3 Backed out 1 changesets (bug 1417600) for failing browser/components/customizableui/test/browser_972267_customizationchange_events.js r=backout on a CLOSED TREE
Backed out changeset 04dac3301ecd (bug 1417600)
2017-11-17 12:51:12 +02:00
Xidorn Quan
948e8f416e Bug 1417600 - Wait for a style flush before setting animation out to ensure start of the animation. r=jaws
MozReview-Commit-ID: IhnmZ0L9yx

--HG--
extra : rebase_source : 013417c60cc85dbb90b8ab33afe60b55252d0b17
2017-11-16 10:33:04 -08:00
Johann Hofmann
3508660808 Bug 1362065 - Add the touchdownstartsdrag attribute to selected tabs on Windows. r=dao
This allows dragging them via touch gestures.

I'm not adding this attribute to all tabs (so that you need
to select a tab before dragging it), because the tab
strip can also be scrolled with touch gestures and
the two touch move actions would easily conflict
otherwise. It would also make it easier to accidentally
mess up your tabs when touching your window somehow.

MozReview-Commit-ID: IVWQtVGFE9j

--HG--
extra : rebase_source : b4d616f45de4362d2fd505dacbf7176d12a04e37
2017-11-10 12:06:50 +01:00
Gijs Kruitbosch
d01a2b63d7 Bug 1388029 - remove notion of 'wide' widget and panel columns from the tree, r=jaws
MozReview-Commit-ID: IrCB3zn1BIT

--HG--
extra : rebase_source : efb192e8c82a4272078bd7754ef453113166b81c
2017-11-07 12:00:18 +00:00
Jared Wein
aa66390484 Bug 1415054 - Handle RTL in empty customize mode better. r=gijs
MozReview-Commit-ID: HjqvOM1n14G

--HG--
extra : rebase_source : fb133bb320f37585f63f872ead38ba7e7f87e544
2017-11-08 15:32:21 -05:00
Johann Hofmann
93aef727a2 Bug 1299286 - Add the touchdownstartsdrag attribute to customize mode elements. r=jaws
MozReview-Commit-ID: LziDBjACA0

--HG--
extra : rebase_source : b0c08cb1ecafa6fce4b9e55ce3dae65412c5070e
2017-11-03 13:12:10 +01:00
Jared Wein
b8ffd9d167 Bug 1410666 - Remove unused PanelUI-popup code. r=mconley
Original patch authored by Tim Nguyen (:ntim).

MozReview-Commit-ID: 6qQnRMQXPTH

--HG--
extra : rebase_source : 319d160f3057173359f02adba44bdcc12a68e209
2017-10-31 14:38:15 -04:00
Coroiu Cristina
03154bfceb Backed out changeset b558ad2372bf (bug 1410666) for failing the browser-chrome on browser_all_files_referenced.js and browser_switch_to_customize_mode.js r=backout on a CLOSED TREE
Backed out changeset b558ad2372bf (bug 1410666)
2017-11-02 01:02:12 +02:00
Jared Wein
2fdc4b7cdf Bug 1410666 - Remove unused PanelUI-popup code. r=mconley
Original patch authored by Tim Nguyen (:ntim).

MozReview-Commit-ID: 6qQnRMQXPTH

--HG--
extra : rebase_source : f85e763cc130a71ba0f4bda228a874ebf65b84be
2017-10-31 14:38:15 -04:00
Jared Wein
77a52a2953 Bug 1413030 - Polish up a few conditions when the customization palette is mostly empty. r=mconley
MozReview-Commit-ID: Gr4sXTZo7pG

--HG--
extra : rebase_source : 2960fd2f09655c44692dd708767593374762eefb
extra : amend_source : 0dc4fdcda68a05851dbe61f50768d91b0683c246
2017-10-24 17:23:22 -04:00
Jared Wein
49cd682e0d Bug 1409463 - Handle customization mode when only the Spacer is left. r=mconley
mconley helped with the initial setup here and they were reviewed by myself (jaws). His changes have been folded in to this patch since they didn't work as a standalone changeset.

MozReview-Commit-ID: E7U1ZciJl4D

--HG--
extra : rebase_source : 63400055b28fe15764190127996a0420c5f1f722
2017-10-15 14:11:57 -04:00
Erica Wright
6146d651bb Bug 1407754 - exiting customize mode quickly after adding a toolbar item to toolbar properly adds it to the toolbar. r=jaws
MozReview-Commit-ID: C7uvVVWoIeB

--HG--
extra : rebase_source : 423b5a7449410a5064405fdb18a87017eb668c6c
2017-10-13 09:27:48 -04:00
Dan Banner
7caa92d5d8 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Erica Wright
4a9eee97d9 Bug 1407435 - After animating out from the toolbar, the widget no longer remains invisible. r=jaws
MozReview-Commit-ID: 5WmcIFWqBYi

--HG--
extra : rebase_source : dfd6745bf0b4b0cebf59992dfebe5cfc0c93f842
2017-10-11 15:12:21 -04:00
Erica Wright
7e91455352 Bug 1390313 - Item added to the overflow menu should scale down and fade out. ui-r=epang r=Gijs
MozReview-Commit-ID: 5PxydbSfhpz

--HG--
extra : rebase_source : 3941fa6edb5e8eb0d14d6d04ad5b0d63ef1a5b84
2017-09-18 16:15:24 -04:00
Gijs Kruitbosch
19ef18501c Bug 1405720 - ensure only 1 theme is ever shown as selected in customize mode, r=jaws,johannh
The previous code here always set the `isActive` property on all themes. When writing the
patch for bug 1402981 I ran into issues because the default theme has an `isActive` property
anyway (it's a different type of object). So I tried to avoid setting `isActive` if it was
already present. Unfortunately, the result was that `isActive` values, once set, weren't
correctly updated. Worse, these values are (and were, prior to bug 1402981) persisted in
some cases.

There's no point persisting these values, all that will happen is that they'll start
mismatching the 'real' state of the world (LightweightThemeManager.currentTheme). So instead,
let's just not set the `isActive` property at all, and rely solely on the ID of the current
theme (or the default theme's ID, now that we no longer support non-lightweight-themes) to
establish whether any of the themes should appear selected or not.

MozReview-Commit-ID: 7rajS71FoQR

--HG--
extra : rebase_source : a99e04031ea9e122efdaf0436e354abe57439783
2017-10-05 15:17:12 +01:00
Jared Wein
5fde947458 Bug 1403382 - Dragging the back button out of the toolbar in customize mode shouldn't affect the toolbar height. r=Gijs
MozReview-Commit-ID: JOsb2y2pzqz

--HG--
extra : rebase_source : d8471cdda0dfc114c2efe7e200ca3c4f25ecabb8
2017-10-02 23:30:29 -04:00