Commit graph

648 commits

Author SHA1 Message Date
Paolo Amadini
33cef824d2 Bug 1484275 - ESLint quick fix, again. r=me 2018-08-24 08:58:06 +01:00
Paolo Amadini
6ea78024ca Bug 1484275 - ESLint quick fix. r=me 2018-08-24 08:39:47 +01:00
Paolo Amadini
866357cbca Bug 1484275 - Fix opening the main menu while another popup is open on Windows. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D3979

--HG--
extra : rebase_source : 5cf5b9fe368de3c78765cb154ef6532e2340d400
2018-08-23 14:04:43 +01:00
Brian Grinstead
4995c61b0f Bug 1482667 - Migrate mochitest-browser tests in browser/ to use element variations of firstChild, etc;r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D3530

--HG--
extra : moz-landing-system : lando
2018-08-17 16:45:52 +00:00
Brian Grinstead
b0b2b901d0 Bug 1470910 - Migrate input-box and input-box-spell to a Custom Element;r=paolo
Instead of `<xul:hbox class="textbox-input-box">`, consumers now should use
`<xul:moz-input-box />`. This covers the normal case and also handles
[spellcheck=true] while sharing much of the code within one class.

MozReview-Commit-ID: DjvT8sFq3SQ

--HG--
rename : toolkit/content/widgets/textbox.xml => toolkit/content/widgets/textbox.js
2018-08-02 20:53:59 -07:00
Kris Maglione
031076f2f3 Bug 1463291: Move docShell getter from Document to Window. r=bz
DocShells are associated with outer DOM Windows, rather than Documents, so
having the getter on the document is a bit odd to begin with. But it's also
considerably less convenient, since most of the times when we want a docShell
from JS, we're dealing most directly with a window, and have to detour through
the document to get it.

MozReview-Commit-ID: LUj1H9nG3QL

--HG--
extra : source : fcfb99baa0f0fb60a7c420a712c6ae7c72576871
extra : histedit_source : 5be9b7b29a52a4b8376ee0bdfc5c08b12e3c775a
2018-05-21 16:58:23 -07:00
Narcis Beleuzu
561ccb2ceb Backed out 2 changesets (bug 1463016, bug 1463291) for geckoview failures
Backed out changeset fcfb99baa0f0 (bug 1463291)
Backed out changeset 0d69b4fb1ed4 (bug 1463016)
2018-07-29 03:55:23 +03:00
Kris Maglione
cb1ee1e34d Bug 1463291: Move docShell getter from Document to Window. r=bz
DocShells are associated with outer DOM Windows, rather than Documents, so
having the getter on the document is a bit odd to begin with. But it's also
considerably less convenient, since most of the times when we want a docShell
from JS, we're dealing most directly with a window, and have to detour through
the document to get it.

MozReview-Commit-ID: LUj1H9nG3QL

--HG--
extra : rebase_source : a13c59d1a5ed000187c7fd8e7339408ad6e2dee6
2018-05-21 16:58:23 -07:00
Paolo Amadini
f06351c23c Bug 1473748 - Part 2 - Simplify how navigable elements are initialized. r=johannh
MozReview-Commit-ID: HN2ZYXNVi6m

--HG--
extra : rebase_source : 4373f26b679296d6f2237640dd248ce5bf8dd63c
2018-07-23 11:28:23 +01:00
Boris Zbarsky
270fa12c79 Bug 1476145 part 3. Stop using getInterface(nsIDOMWindowUtils) in browser/. r=gijs 2018-07-24 19:47:41 -04:00
Brian Grinstead
96dc530924 Bug 1476333 - Refer to AppConstants.BROWSER_CHROME_URL to get the browser URL from the frontend;r=Gijs
Before this change, we accessed the browser URL in the following ways:

- "chrome://browser/content/browser.xul"
- "chrome://browser/content/" (which redirects to chrome://browser/content/browser.xul)
- Services.prefs.getCharPref("browser.chromeURL") which returns "chrome://browser/content/"
- getBrowserURL() from utilityOverlay.js

MozReview-Commit-ID: I5vtRke1x9t

--HG--
extra : rebase_source : c525350a1954740873e85b045cbb14a8b43aa89d
2018-07-24 08:12:50 -07:00
Johann Hofmann
e7b9853987 Bug 1467385 - Use PanelMultiView APIs for keyboard navigation in the identity popup. r=Paolo
PanelMultiView has its own concept of "selected", so we should use this rather than move focus
using advanceFocusIntoSubTree.

MozReview-Commit-ID: DW2JqqggLl1

--HG--
extra : rebase_source : ec7a6f83fdda176f3286cf4395dc72de6cad2466
2018-07-02 14:34:25 +02:00
Kris Maglione
c1c1de7ce8 Bug 1467695: Wait for async disable operations to finish when calling addonChanged listeners. r=aswan
MozReview-Commit-ID: 1vsevE8IgYU

--HG--
extra : source : 46e5404ad50cf39cfe8b10bbd9c45b4325d95d6e
extra : amend_source : 0bfd172b9ec37e7f169269aa37cbe547d2156c6d
extra : intermediate-source : c0ebdd0be6ba6f9748690d0ae5479977e2ea54bb
2018-06-08 13:02:43 -07:00
Joel Maher
50b91c0a14 Bug 1405428 - skip-if = verify on mochitests which do not pass test-verify. r=gbrown 2018-06-10 05:01:47 -04:00
Csoregi Natalia
d2a7e3fcd3 Merge mozilla-central to autoland. a=merge CLOSED TREE 2018-05-10 19:45:06 +03:00
Gijs Kruitbosch
f289809963 Bug 1459913 - fix removable_false test to always execute the correct drag (layout race), rs=test-only
--HG--
extra : rebase_source : 63cd78b81cccb99069a9dbfe78274040cb0ad589
2018-05-10 09:44:49 +01:00
Gijs Kruitbosch
0809c549f1 Bug 962248 - rewrite zoom test to be less terrible, r=dthayer
MozReview-Commit-ID: ByUM61fsOgh

--HG--
extra : rebase_source : e81915fbf2ecf35a90ef6a0c4be5b6fa4bf01d51
2018-05-09 09:07:37 +01:00
Tooru Fujisawa
c12bdc0642 Bug 1420574 - Add CustomizableUITestUtils.prototype.{addSearchBar,removeSearchBar} to show search bar in nav bar and verify it does not overflow. r=Paolo 2018-05-09 09:48:40 +09:00
Gijs Kruitbosch
b40ddc17c4 Bug 1438490 - move overflow/underflow event handling out of toolbar.xml, r=jaws
MozReview-Commit-ID: CwkCOIm9wNk

--HG--
extra : rebase_source : a746c9dc190e3309d9368083ce08c36f222a3407
2018-05-01 15:44:19 +01:00
Gijs Kruitbosch
9654bc99a1 Bug 1447619 - avoid reflowing when returning items to the toolbar from the overflow menu, r=florian
MozReview-Commit-ID: BFGRssWb9F

--HG--
extra : rebase_source : cf6011f2ecfe78df11a6741dfa074c7d985ec294
extra : source : 1ce48405e58a609299a84192df04d340cd90de63
2018-04-20 15:09:44 +01:00
Andreea Pavel
7abcd926f5 Backed out changeset 1ce48405e58a (bug 1447619) for creating bug 1457257 and bug 1457289 on a CLOSED TREE 2018-04-28 20:46:51 +03:00
Gijs Kruitbosch
39d0e25c38 Bug 1447619 - avoid reflowing when returning items to the toolbar from the overflow menu, r=florian
MozReview-Commit-ID: BFGRssWb9F

--HG--
extra : rebase_source : e8932810584e10a1de0c1b11c1a152d2dc0f48dd
2018-04-20 15:09:44 +01:00
Tim Nguyen
92c9a958e1 Bug 1372694 - Stop making the default theme a heavyweight theme. r=kmag,aswan
MozReview-Commit-ID: 30wMauuc9oo

--HG--
rename : browser/base/content/default-theme-icon.svg => toolkit/mozapps/extensions/content/default-theme-icon.svg
extra : rebase_source : 5e4cf784135f4a8e40a2ed8357ba651e7fce9728
2018-04-01 13:53:31 +02:00
Jonathan Kingston
fea68cb968 Bug 1453528 - Fix opening of synced tabs with correct principal. r=markh
MozReview-Commit-ID: 6MGXjsg3HmV

--HG--
extra : rebase_source : bc2782dbf14131325fd7ee4564524794350a1bc3
2018-04-12 18:06:13 +01:00
Paolo Amadini
ea3963afc9 Bug 1444392 - Part 1 - Add test-only helpers to open and close the main menu. r=Gijs
MozReview-Commit-ID: 9kvUdw2TeHB

--HG--
extra : rebase_source : 0b0a007ad517c0256fe67256391d87065bf645ef
extra : amend_source : c2c56528f12e38852e913e42e9e7f9e78e8623d9
extra : source : ec2f47133979d085739d383cc50358d6e9417979
2018-04-04 11:34:16 +01:00
Edouard Oger
9b6026748b Bug 1184265 - Make last sync date be relative. r=markh
MozReview-Commit-ID: 2hB9F7Elynh

--HG--
extra : rebase_source : dbf962b1fd3f4121f0bcc8276e932f0c49ab90b3
2018-03-20 17:08:16 -04:00
Tooru Fujisawa
1adba8c1fc Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Kris Maglione
313b707b2e Bug 1443964: Part 3 - Remove no-cpows-in-tests rule. r=mconley
The shims that this rule tests for no longer exist.

MozReview-Commit-ID: DMgP7Hczavc

--HG--
extra : rebase_source : 765ddd5c62c9449c07ed050e44d86a3bd5c0ae64
extra : amend_source : 627a7694ac07182200f876901ded7a34721cd228
2018-03-07 19:31:28 -08:00
Gijs Kruitbosch
d2ebbb38df Bug 1358815 - remove sync reflow from find bar initialization, r=jaws
This removes the sync reflow from almost all cases. The only case where we keep it is when a keypress
caught in content triggers a sync message to the parent process. We should clean this up in bug 1371523.

I've tried to fix the tests, but a lot of them seem to be disabled anyway...

MozReview-Commit-ID: 9k36p7q8MKy

--HG--
extra : rebase_source : 311ee41ba9456a5c5d58b81a0cfa999bcef0027e
2018-03-12 14:01:44 +00:00
Brindusan Cristian
4f5a76dc76 Backed out 2 changesets (bug 1358815) for bc failures on browser_pdfjs_main.js CLOSED TREE
Backed out changeset 880736d97de3 (bug 1358815)
Backed out changeset a2a0a0990e1a (bug 1358815)
2018-03-15 21:23:12 +02:00
Gijs Kruitbosch
59e21359c8 Bug 1358815 - remove sync reflow from find bar initialization, r=jaws
This removes the sync reflow from almost all cases. The only case where we keep it is when a keypress
caught in content triggers a sync message to the parent process. We should clean this up in bug 1371523.

I've tried to fix the tests, but a lot of them seem to be disabled anyway...

MozReview-Commit-ID: 9k36p7q8MKy

--HG--
extra : rebase_source : 311ee41ba9456a5c5d58b81a0cfa999bcef0027e
2018-03-12 14:01:44 +00:00
Kris Maglione
83957914cc Bug 1445551: Part 1b - Whitelist unsafe CPOW use in existing tests. r=mconley
MozReview-Commit-ID: 4ojwvjw9XGT

--HG--
extra : rebase_source : f7b79ad5998f1138266e89767ee1b434e4797b30
2018-03-14 14:35:05 -07:00
Gijs Kruitbosch
5a6fb10278 Bug 1445350 - fix browser_panelUINotifications_multiWindow.js so it doesn't fail on win10, r=dthayer
MozReview-Commit-ID: Jk3ah2Xtr58

--HG--
extra : rebase_source : 4c3bb805018df98b0755854a113433e6e9c83150
2018-03-14 13:18:35 +00:00
Edouard Oger
dd1fce1d1a Bug 1441376 - Stop the Syncing animation manually in browser_remote_tabs_button.js test. r=Paolo
The UIState.ON_UPDATE notification should be enough to reset the state of the
panel every time the test is about to be executed. Wrong.
In response to this notification, gSync.onActivityStop() is called, which disables
the syncing animation immediately ONLY if it has been running for at least 1.5sec
(which is almost never happening in tests), otherwise we get a setTimeout with
the remaining time.
When the sync animation is running, we also do not react to clicks (disabled),
hence the test failing.
We fix this by stopping the animation ourselves manually at the end of the test,
so any subsequent test will start with a correct UI state.

MozReview-Commit-ID: CrEb82Tw5SO

--HG--
extra : rebase_source : da4822c9fb6f41e6fbfeec5a63086c43aeca7944
2018-03-09 16:03:48 -05:00
Dão Gottwald
179b1e9cd5 Bug 1443360 - Fix browser_panelUINotifications_fullscreen.js intermittent failure. r=Gijs
MozReview-Commit-ID: FTP3NXqW0oy

--HG--
extra : rebase_source : a9325ed2598c04bc6214ba42b921d4dd23366465
2018-03-08 10:24:10 +01:00
Dão Gottwald
3e27baea54 Bug 1443364 - Fix browser_901207_searchbar_in_panel.js intermittent failure. r=Gijs
MozReview-Commit-ID: H0F7n3eoV3V

--HG--
extra : rebase_source : 219aeb63a4c9c5eadbabf3c97af1ec300ba09cb1
2018-03-07 18:40:55 +01:00
Edouard Oger
4aea0be2d6 Bug 1439777 p2 - Remove weave:ui:* related code. r=markh,tcsc
MozReview-Commit-ID: D1H36YeiJCS

--HG--
extra : rebase_source : 16b7f01ed6f9b03534945d718c567dad0daa4ff3
2018-02-22 16:30:39 +08:00
Narcis Beleuzu
8c7d795b53 Backed out 2 changesets (bug 1439777) for xpcshell failures on /test_errorhandler_2.js
Backed out changeset d99402ad9ecc (bug 1439777)
Backed out changeset 1af3426dc956 (bug 1439777)
2018-03-06 04:43:41 +02:00
Edouard Oger
934abf11b3 Bug 1439777 p2 - Remove weave:ui:* related code. r=markh,tcsc
MozReview-Commit-ID: D1H36YeiJCS

--HG--
extra : rebase_source : dd7218b5f0bd36dc4c71d2a7c95a92bba4da2d12
2018-02-22 16:30:39 +08:00
Csoregi Natalia
1fd0486e23 Backed out 7 changesets (bug 1193394) for browser-chrome failures on browser_ext_popup_background.js. CLOSED TREE
Backed out changeset 9683f24ff8ec (bug 1193394)
Backed out changeset 0e7140a7c841 (bug 1193394)
Backed out changeset a0e26f6b2784 (bug 1193394)
Backed out changeset 29e1fceaf48d (bug 1193394)
Backed out changeset b8632bbbd273 (bug 1193394)
Backed out changeset a54ef2d8f896 (bug 1193394)
Backed out changeset 55c94c05c57f (bug 1193394)
2018-03-01 16:29:02 +02:00
Tooru Fujisawa
8809c05b7b Bug 1193394 - Part 5: Disable some tests that relies on descriptionHeightWorkaround. r=bustage CLOSED TREE 2018-03-01 20:03:13 +09:00
Paolo Amadini
91212fa6b1 Bug 1428839 - Part 4 - Avoid re-entrancy in PanelMultiView navigation functions. r=Gijs
We now use the "active" property of views to track whether navigation is possible. This has the advantage of being already handled correctly when views are moved to a different panel, and is in line with the purpose of the "active" state. The note about using the "popupshown" event for navigation has been updated accordingly.

Keyboard navigation is also linked to the "active" property now, so there is no need to track the state of the "_transitioning" property anymore.

Since the goBack and showSubView methods can only be called when the view is active, we don't need to check for attempts to start a transition while the panel is closed anymore.

MozReview-Commit-ID: 3KT3A5EwGFy

--HG--
extra : rebase_source : c338362923a7574210c7329bb84316d549898fdc
2018-02-27 15:33:33 +00:00
Florian Quèze
c714053d73 Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Paolo Amadini
e0eef0a81d Bug 1440358 - Part 3 - Add tests for reopening a visible Library view. r=Gijs
MozReview-Commit-ID: 3sJDnzUWFbz

--HG--
extra : rebase_source : 17280de3f1733f47e3619145d8289c1e7c548937
2018-02-26 13:47:00 +00:00
Paolo Amadini
61b6cbe98e Bug 1440358 - Part 2 - Add tests for cancellation while opening a view. r=Gijs
This includes both canceling the ViewShowing event and calling the hidePopup method of PanelMultiView.

MozReview-Commit-ID: Goo45SEBC3z

--HG--
extra : rebase_source : d78376d7a69dd47157e049da1aaa19e97b9bd12c
2018-02-25 19:49:00 +00:00
Paolo Amadini
4d3254c032 Bug 1440358 - Part 1 - Add unit tests for PanelMultiView. r=Gijs
MozReview-Commit-ID: 3WM2Skrg3QV

--HG--
extra : rebase_source : 10a8080363a1c17013e249947314671389d04613
2018-02-26 13:45:09 +00:00
Paolo Amadini
53d37c96a7 Bug 1440333 - Part 3 - Raise the ViewShown event after the main view is active. r=Gijs
This also adds a new "active" property that can be used by regression tests to determine whether they should still wait for the ViewShown event.

MozReview-Commit-ID: K25F09llooj

--HG--
extra : rebase_source : 9f6dad605243fcd3633260c4fa34011f9cfab27c
extra : source : 2dad70b2a723e67b45563dd3ac254911dd193439
2018-02-26 13:18:22 +00:00
Paolo Amadini
acc856e8d4 Bug 1440333 - Part 2 - Rename the "current" attribute to "visible". r=Gijs
MozReview-Commit-ID: EazXDT6JC3M

--HG--
extra : rebase_source : ecaba689f94e26dcb20321bf51cd1b76d22ac2e8
extra : source : c705b49c2bae3301998df83dc0b883d0fb4e5219
2018-02-26 14:31:35 +00:00
Brindusan Cristian
81684073f2 Backed out 3 changesets (bug 1440333) for firefox-functional-test failures on test_no_certificate.py on a CLOSED TREE
Backed out changeset 2dad70b2a723 (bug 1440333)
Backed out changeset c705b49c2bae (bug 1440333)
Backed out changeset 9906b468eb78 (bug 1440333)
2018-02-26 16:19:18 +02:00
Paolo Amadini
885de209fb Bug 1440333 - Part 3 - Raise the ViewShown event after the main view is active. r=Gijs
This also adds a new "active" property that can be used by regression tests to determine whether they should still wait for the ViewShown event.

MozReview-Commit-ID: K25F09llooj

--HG--
extra : rebase_source : 8c9e2a86285be6453cd60b3da448876e6dfa7e8a
2018-02-26 13:18:22 +00:00